From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luis Chamberlain Subject: Re: [RFC v3 07/19] kunit: test: add initial tests Date: Mon, 3 Dec 2018 15:43:55 -0800 Message-ID: <20181203234355.GQ28501@garbanzo.do-not-panic.com> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-8-brendanhiggins@google.com> <20181130034001.GM18410@garbanzo.do-not-panic.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Brendan Higgins Cc: brakmo-b10kYP2dOMg@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kselftest-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shuah-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Rob Herring , Frank Rowand , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, richard-/L3Ra7n9ekc@public.gmane.org, Knut Omang , kieran.bingham-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, Joel Stanley , jdike-OPE4K8JWMJJBDgjK7y7TUQ@public.gmane.org, Tim.Bird-7U/KSKJipcs@public.gmane.org, Kees Cook , linux-um-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org, Julia Lawall , kunit-dev-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Greg KH , Linux Kernel Mailing List , Daniel Vetter , mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org, joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org, khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org List-Id: dri-devel@lists.freedesktop.org On Mon, Dec 03, 2018 at 03:26:26PM -0800, Brendan Higgins wrote: > On Thu, Nov 29, 2018 at 7:40 PM Luis Chamberlain wrote: > > > > On Wed, Nov 28, 2018 at 11:36:24AM -0800, Brendan Higgins wrote: > > > Add a test for string stream along with a simpler example. > > > > > > Signed-off-by: Brendan Higgins > > > --- > > > kunit/Kconfig | 12 ++++++ > > > kunit/Makefile | 4 ++ > > > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ > > > > BTW if you need another more concrete but very simple example I think it > > may be possible to port tools/testing/selftests/sysctl/sysctl.sh + > > lib/test_sysctl.c into a kunit test. Correct me if I'm wrong. > > I think that is pretty doable. I don't know that I want to shoot for > that on the next revision. But I can definitely do it in a later > revision, or a later patchset, unless you would strongly prefer it > now, that is. No rush on my end, just figured I'd mention a simple candidate in case you needed another one to evaluate. Luis