From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v4 04/22] drm/sun4i: frontend: Pass DRM format info to input format helpers Date: Wed, 5 Dec 2018 16:35:45 +0100 Message-ID: <20181205153545.nh6f6pca4ohkluwj@flea> References: <20181205083703.21488-1-paul.kocialkowski@bootlin.com> <20181205083703.21488-5-paul.kocialkowski@bootlin.com> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3taurwh7mcy3bipp" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20181205083703.21488-5-paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Paul Kocialkowski Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Airlie , Chen-Yu Tsai , Maarten Lankhorst , Sean Paul , Thomas Petazzoni , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org --3taurwh7mcy3bipp Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Wed, Dec 05, 2018 at 09:36:45AM +0100, Paul Kocialkowski wrote: > The helper returning the input mode needs to know the number of planes > for the provided format. Passing the fourcc requires iterating through > the format info list in order to return the number of planes. > > Pass the DRM format info structure directly instead to all helpers > related to configuring the input format, since it's available to the > caller. Also rename the input format in the caller function to keep > things consistent. > > Signed-off-by: Paul Kocialkowski Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --3taurwh7mcy3bipp--