From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jordan Crouse Subject: Re: [PATCH 2/2] drm/msm/a6xx: Fix NULL dereference during crashstate capture Date: Mon, 10 Dec 2018 08:39:43 -0700 Message-ID: <20181210153943.GD20602@jcrouse-lnx.qualcomm.com> References: <1544443462-28736-1-git-send-email-smasetty@codeaurora.org> <1544443462-28736-2-git-send-email-smasetty@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1544443462-28736-2-git-send-email-smasetty-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Sharat Masetty Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBEZWMgMTAsIDIwMTggYXQgMDU6MzQ6MjJQTSArMDUzMCwgU2hhcmF0IE1hc2V0dHkg d3JvdGU6Cj4gVGhlIGdwdSBjcmFzaHN0YXRlJ3MgYmFzZSBvYmplY3RzIHJlZ2lzdGVycyBwb2lu dGVyIGNhbiBiZSBOVUxMIGlmIHRoZQo+IHRhcmdldCBpbXBsZW1lbnRhdGlvbiBkZWNpZGVzIHRv IGNhcHR1cmUgdGhlIHJlZ2lzdGVyIGR1bXAgb24gaXRzIG93bi4KPiBUaGlzIHBhdGNoIHNpbXBs eSBjaGVja3MgZm9yIE5VTEwgYmVmb3JlIGRlcmVmZXJlbmNpbmcuCj4gCj4gU2lnbmVkLW9mZi1i eTogU2hhcmF0IE1hc2V0dHkgPHNtYXNldHR5QGNvZGVhdXJvcmEub3JnPgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vbXNtL2FkcmVuby9hZHJlbm9fZ3B1LmMgfCAxNSArKysrKysrKysrLS0tLS0K PiAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2FkcmVub19ncHUuYyBiL2Ry aXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2FkcmVub19ncHUuYwo+IGluZGV4IDQwYmNmMzIuLmEz OWNlYmMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYWRyZW5vX2dw dS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYWRyZW5vX2dwdS5jCj4gQEAg LTQxNSw2ICs0MTUsOSBAQCB2b2lkIGFkcmVub19ncHVfc3RhdGVfZ2V0KHN0cnVjdCBtc21fZ3B1 ICpncHUsIHN0cnVjdCBtc21fZ3B1X3N0YXRlICpzdGF0ZSkKPiAgCQl9Cj4gIAl9Cj4gIAo+ICsJ aWYgKCFhZHJlbm9fZ3B1LT5yZWdpc3RlcnMpCj4gKwkJcmV0dXJuOwo+ICsKClRoaXMgbG9va3Mg Z29vZCAtIHdlIHNob3VsZCBnZXQgaXQgaW4gdGhlIDQuMjEgcHVsbC4KCj4gIAkvKiBDb3VudCB0 aGUgbnVtYmVyIG9mIHJlZ2lzdGVycyAqLwo+ICAJZm9yIChpID0gMDsgYWRyZW5vX2dwdS0+cmVn aXN0ZXJzW2ldICE9IH4wOyBpICs9IDIpCj4gIAkJY291bnQgKz0gYWRyZW5vX2dwdS0+cmVnaXN0 ZXJzW2kgKyAxXSAtCj4gQEAgLTU1MCwxMiArNTUzLDE0IEBAIHZvaWQgYWRyZW5vX3Nob3coc3Ry dWN0IG1zbV9ncHUgKmdwdSwgc3RydWN0IG1zbV9ncHVfc3RhdGUgKnN0YXRlLAo+ICAJCX0KPiAg CX0KPiAgCj4gLQlkcm1fcHV0cyhwLCAicmVnaXN0ZXJzOlxuIik7Cj4gKwlpZiAoc3RhdGUtPm5y X3JlZ2lzdGVycyA+IDApIHsKPiArCQlkcm1fcHV0cyhwLCAicmVnaXN0ZXJzOlxuIik7Cj4gIAo+ IC0JZm9yIChpID0gMDsgaSA8IHN0YXRlLT5ucl9yZWdpc3RlcnM7IGkrKykgewo+IC0JCWRybV9w cmludGYocCwgIiAgLSB7IG9mZnNldDogMHglMDR4LCB2YWx1ZTogMHglMDh4IH1cbiIsCj4gLQkJ CXN0YXRlLT5yZWdpc3RlcnNbaSAqIDJdIDw8IDIsCj4gLQkJCXN0YXRlLT5yZWdpc3RlcnNbKGkg KiAyKSArIDFdKTsKPiArCQlmb3IgKGkgPSAwOyBpIDwgc3RhdGUtPm5yX3JlZ2lzdGVyczsgaSsr KSB7Cj4gKwkJCWRybV9wcmludGYocCwgIiAgLSB7IG9mZnNldDogMHglMDR4LCB2YWx1ZTogMHgl MDh4IH1cbiIsCj4gKwkJCQkJc3RhdGUtPnJlZ2lzdGVyc1tpICogMl0gPDwgMiwKPiArCQkJCQlz dGF0ZS0+cmVnaXN0ZXJzWyhpICogMikgKyAxXSk7Cj4gKwkJfQoKSSBkb24ndCB0aGluayB3ZSBu ZWVkIHRoZSBleHRyYSBpbmRlbnRhdGlvbiBoZXJlIC0gc29tZXRoaW5nIGxpa2UKCmZvciAoaSA9 IDA7IGkgPCBzdGF0ZS0+bnJfcmVnaXN0ZXJzOyBpKyspIHsKKwlpZiAoaSA9PSAwKQorCQlkcm1f cHV0cyhwLCAiUmVnaXN0ZXJzOlxuIik7Cglkcm1fcHJpbnRmKHAsICIgLSB7IG9mZnNldDogMHgl MDR4LCB2YWx1ZTogMHglMDh4IH1cbiIsCgp3b3VsZCBzdWZmaWNlIHNpbmNlIHdlIHdvbid0IGdv IGludG8gdGhlIGxvb3AgaWYgc3RhdGUtPm5yX3JlZ2lzdGVycyA9PSAwLgoKSm9yZGFuCgotLSAK VGhlIFF1YWxjb21tIElubm92YXRpb24gQ2VudGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9mIENvZGUg QXVyb3JhIEZvcnVtLAphIExpbnV4IEZvdW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQcm9qZWN0Cl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkZyZWVkcmVubyBt YWlsaW5nIGxpc3QKRnJlZWRyZW5vQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ZyZWVkcmVubwo=