From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH 3/5] drm/msm/dpu: Plane helper for modifiers Date: Wed, 12 Dec 2018 11:11:36 -0500 Message-ID: <20181212161136.GH154160@art_vandelay> References: <20181211184224.131478-1-frkoenig@google.com> <20181211184224.131478-3-frkoenig@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com [IPv6:2607:f8b0:4864:20::b42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6CE096E971 for ; Wed, 12 Dec 2018 16:11:38 +0000 (UTC) Received: by mail-yb1-xb42.google.com with SMTP id 64so5756615ybe.3 for ; Wed, 12 Dec 2018 08:11:38 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181211184224.131478-3-frkoenig@google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fritz Koenig Cc: sean@poorly.run, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBEZWMgMTEsIDIwMTggYXQgMTA6NDI6MjJBTSAtMDgwMCwgRnJpdHogS29lbmlnIHdy b3RlOgo+IEZpbHRlciBwbGFuZXMgYmFzZWQgb24gdGhlIHN1cHBvcnRlZCBtb2RpZmllcnMKPiAK PiBTaWduZWQtb2ZmLWJ5OiBGcml0eiBLb2VuaWcgPGZya29lbmlnQGdvb2dsZS5jb20+CgpSZXZp ZXdlZC1ieTogU2VhbiBQYXVsIDxzZWFuQHBvb3JseS5ydW4+Cgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfcGxhbmUuYyB8IDE4ICsrKysrKysrKysrKysrKysrKwo+ ICAxIGZpbGUgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfcGxhbmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9t c20vZGlzcC9kcHUxL2RwdV9wbGFuZS5jCj4gaW5kZXggNmE0OWMyNTNiYmRjLi45MzgxYzhhZjc2 ZDcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X3BsYW5l LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfcGxhbmUuYwo+IEBA IC0xNDEwLDYgKzE0MTAsMjMgQEAgc3RhdGljIHZvaWQgZHB1X3BsYW5lX2Vhcmx5X3VucmVnaXN0 ZXIoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUpCj4gIAlkZWJ1Z2ZzX3JlbW92ZV9yZWN1cnNpdmUo cGRwdS0+ZGVidWdmc19yb290KTsKPiAgfQo+ICAKPiArc3RhdGljIGJvb2wgZHB1X3BsYW5lX2Zv cm1hdF9tb2Rfc3VwcG9ydGVkKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICsJCXVpbnQzMl90 IGZvcm1hdCwgdWludDY0X3QgbW9kaWZpZXIpCj4gK3sKPiArCWlmIChtb2RpZmllciA9PSBEUk1f Rk9STUFUX01PRF9MSU5FQVIpCj4gKwkJcmV0dXJuIHRydWU7Cj4gKwo+ICsJaWYgKG1vZGlmaWVy ID09IERSTV9GT1JNQVRfTU9EX1FDT01fQ09NUFJFU1NFRCkgewo+ICsJCWludCBpOwo+ICsJCWZv ciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKHFjb21fY29tcHJlc3NlZF9zdXBwb3J0ZWRfZm9ybWF0 cyk7IGkrKykgewo+ICsJCQlpZiAoZm9ybWF0ID09IHFjb21fY29tcHJlc3NlZF9zdXBwb3J0ZWRf Zm9ybWF0c1tpXSkKPiArCQkJCXJldHVybiB0cnVlOwo+ICsJCX0KPiArCX0KPiArCj4gKwlyZXR1 cm4gZmFsc2U7CgpuaXQ6IFlvdSBjb3VsZCBoYXZlIHJlbW92ZWQgdGhlIHRvcCBjb25kaXRpb25h bCBhbmQganVzdCBkbwogICAgICAgIHJldHVybiBtb2RpZmllciA9PSBEUk1fRk9STUFUX01PRF9M SU5FQVI7IAogICAgIGhlcmUsIGJ1dCB0aGlzIGlzIGNvb2wgdG9vLgoKPiArfQo+ICsKPiAgc3Rh dGljIGNvbnN0IHN0cnVjdCBkcm1fcGxhbmVfZnVuY3MgZHB1X3BsYW5lX2Z1bmNzID0gewo+ICAJ CS51cGRhdGVfcGxhbmUgPSBkcm1fYXRvbWljX2hlbHBlcl91cGRhdGVfcGxhbmUsCj4gIAkJLmRp c2FibGVfcGxhbmUgPSBkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX3BsYW5lLAo+IEBAIC0xNDE5 LDYgKzE0MzYsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9wbGFuZV9mdW5jcyBkcHVfcGxh bmVfZnVuY3MgPSB7Cj4gIAkJLmF0b21pY19kZXN0cm95X3N0YXRlID0gZHB1X3BsYW5lX2Rlc3Ry b3lfc3RhdGUsCj4gIAkJLmxhdGVfcmVnaXN0ZXIgPSBkcHVfcGxhbmVfbGF0ZV9yZWdpc3RlciwK PiAgCQkuZWFybHlfdW5yZWdpc3RlciA9IGRwdV9wbGFuZV9lYXJseV91bnJlZ2lzdGVyLAo+ICsJ CS5mb3JtYXRfbW9kX3N1cHBvcnRlZCA9IGRwdV9wbGFuZV9mb3JtYXRfbW9kX3N1cHBvcnRlZCwK PiAgfTsKPiAgCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX3BsYW5lX2hlbHBlcl9mdW5jcyBk cHVfcGxhbmVfaGVscGVyX2Z1bmNzID0gewo+IC0tIAo+IDIuMjAuMC5yYzIuNDAzLmdkYmMzYjI5 ODA1LWdvb2cKPiAKCi0tIApTZWFuIFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVyLCBHb29nbGUgLyBD aHJvbWl1bSBPUwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK