From: Sean Paul <sean@poorly.run>
To: Fritz Koenig <frkoenig@google.com>
Cc: sean@poorly.run, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/msm/dpu: Initialize supported modifiers
Date: Wed, 12 Dec 2018 11:12:44 -0500 [thread overview]
Message-ID: <20181212161244.GI154160@art_vandelay> (raw)
In-Reply-To: <20181211184224.131478-4-frkoenig@google.com>
On Tue, Dec 11, 2018 at 10:42:23AM -0800, Fritz Koenig wrote:
> Pass list of supported modifiers to plane init.
>
> Signed-off-by: Fritz Koenig <frkoenig@google.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> index 9381c8af76d7..d2d4720f6f8c 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> @@ -119,6 +119,12 @@ struct dpu_plane {
> bool debugfs_default_scale;
> };
>
> +static const uint64_t supported_format_modifiers[] = {
> + DRM_FORMAT_MOD_QCOM_COMPRESSED,
Did you confirm that all the planes support this?
Change is
Reviewed-by: Sean Paul <sean@poorly.run>
> + DRM_FORMAT_MOD_LINEAR,
> + DRM_FORMAT_MOD_INVALID
> +};
> +
> #define to_dpu_plane(x) container_of(x, struct dpu_plane, base)
>
> static struct dpu_kms *_dpu_plane_get_kms(struct drm_plane *plane)
> @@ -1521,7 +1527,7 @@ struct drm_plane *dpu_plane_init(struct drm_device *dev,
>
> ret = drm_universal_plane_init(dev, plane, 0xff, &dpu_plane_funcs,
> format_list, num_formats,
> - NULL, type, NULL);
> + supported_format_modifiers, type, NULL);
> if (ret)
> goto clean_sspp;
>
> --
> 2.20.0.rc2.403.gdbc3b29805-goog
>
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-12-12 16:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 18:42 [PATCH 1/5] drm/msm/dpu: Remove unused format tables Fritz Koenig
2018-12-11 18:42 ` [PATCH 2/5] drm/msm/dpu: Use simple list for plane format init Fritz Koenig
2018-12-12 16:08 ` Sean Paul
2018-12-11 18:42 ` [PATCH 3/5] drm/msm/dpu: Plane helper for modifiers Fritz Koenig
2018-12-12 16:11 ` Sean Paul
2018-12-11 18:42 ` [PATCH 4/5] drm/msm/dpu: Initialize supported modifiers Fritz Koenig
2018-12-12 16:12 ` Sean Paul [this message]
2018-12-12 18:02 ` Fritz Koenig
2018-12-12 20:35 ` Sean Paul
2018-12-11 18:42 ` [PATCH 5/5] drm/msm/dpu: Correct initialization of modifiers Fritz Koenig
2018-12-12 16:13 ` Sean Paul
2018-12-12 16:05 ` [PATCH 1/5] drm/msm/dpu: Remove unused format tables Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212161244.GI154160@art_vandelay \
--to=sean@poorly.run \
--cc=dri-devel@lists.freedesktop.org \
--cc=frkoenig@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox