From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH 5/5] drm/msm/dpu: Correct initialization of modifiers Date: Wed, 12 Dec 2018 11:13:32 -0500 Message-ID: <20181212161332.GJ154160@art_vandelay> References: <20181211184224.131478-1-frkoenig@google.com> <20181211184224.131478-5-frkoenig@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yb1-xb41.google.com (mail-yb1-xb41.google.com [IPv6:2607:f8b0:4864:20::b41]) by gabe.freedesktop.org (Postfix) with ESMTPS id B87738989A for ; Wed, 12 Dec 2018 16:13:34 +0000 (UTC) Received: by mail-yb1-xb41.google.com with SMTP id d136so4138947ybh.10 for ; Wed, 12 Dec 2018 08:13:34 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181211184224.131478-5-frkoenig@google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fritz Koenig Cc: sean@poorly.run, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBEZWMgMTEsIDIwMTggYXQgMTA6NDI6MjRBTSAtMDgwMCwgRnJpdHogS29lbmlnIHdy b3RlOgo+IGFsbG93X2ZiX21vZGlmaWVycyBuZWVkcyB0byBiZSBzZXQgYmVmb3JlIGRybV91bml2 ZXJzYWxfcGxhbmVfaW5pdAo+IGlzIGNhbGxlZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBGcml0eiBL b2VuaWcgPGZya29lbmlnQGdvb2dsZS5jb20+CgpSZXZpZXdlZC1ieTogU2VhbiBQYXVsIDxzZWFu QHBvb3JseS5ydW4+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVf a21zLmMgfCAyMCArKysrKysrKysrLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5z ZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9k cHUxL2RwdV9rbXMuYwo+IGluZGV4IDRkNjdiM2M5NjcwMi4uNTY1NTVjM2E3NTBhIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYwo+IEBAIC05MjYsMTYgKzkyNiw2 IEBAIHN0YXRpYyBpbnQgZHB1X2ttc19od19pbml0KHN0cnVjdCBtc21fa21zICprbXMpCj4gIAkJ Z290byBod19pbnRyX2luaXRfZXJyOwo+ICAJfQo+ICAKPiAtCS8qCj4gLQkgKiBfZHB1X2ttc19k cm1fb2JqX2luaXQgc2hvdWxkIGNyZWF0ZSB0aGUgRFJNIHJlbGF0ZWQgb2JqZWN0cwo+IC0JICog aS5lLiBDUlRDcywgcGxhbmVzLCBlbmNvZGVycywgY29ubmVjdG9ycyBhbmQgc28gZm9ydGgKPiAt CSAqLwo+IC0JcmMgPSBfZHB1X2ttc19kcm1fb2JqX2luaXQoZHB1X2ttcyk7Cj4gLQlpZiAocmMp IHsKPiAtCQlEUFVfRVJST1IoIm1vZGVzZXQgaW5pdCBmYWlsZWQ6ICVkXG4iLCByYyk7Cj4gLQkJ Z290byBkcm1fb2JqX2luaXRfZXJyOwo+IC0JfQo+IC0KPiAgCWRldi0+bW9kZV9jb25maWcubWlu X3dpZHRoID0gMDsKPiAgCWRldi0+bW9kZV9jb25maWcubWluX2hlaWdodCA9IDA7Cj4gIAo+IEBA IC05NTIsNiArOTQyLDE2IEBAIHN0YXRpYyBpbnQgZHB1X2ttc19od19pbml0KHN0cnVjdCBtc21f a21zICprbXMpCj4gIAkgKi8KPiAgCWRldi0+bW9kZV9jb25maWcuYWxsb3dfZmJfbW9kaWZpZXJz ID0gdHJ1ZTsKPiAgCj4gKwkvKgo+ICsJICogX2RwdV9rbXNfZHJtX29ial9pbml0IHNob3VsZCBj cmVhdGUgdGhlIERSTSByZWxhdGVkIG9iamVjdHMKPiArCSAqIGkuZS4gQ1JUQ3MsIHBsYW5lcywg ZW5jb2RlcnMsIGNvbm5lY3RvcnMgYW5kIHNvIGZvcnRoCj4gKwkgKi8KPiArCXJjID0gX2RwdV9r bXNfZHJtX29ial9pbml0KGRwdV9rbXMpOwo+ICsJaWYgKHJjKSB7Cj4gKwkJRFBVX0VSUk9SKCJt b2Rlc2V0IGluaXQgZmFpbGVkOiAlZFxuIiwgcmMpOwo+ICsJCWdvdG8gZHJtX29ial9pbml0X2Vy cjsKPiArCX0KPiArCj4gIAlkcHVfdmJpZl9pbml0X21lbXR5cGVzKGRwdV9rbXMpOwo+ICAKPiAg CXBtX3J1bnRpbWVfcHV0X3N5bmMoJmRwdV9rbXMtPnBkZXYtPmRldik7Cj4gLS0gCj4gMi4yMC4w LnJjMi40MDMuZ2RiYzNiMjk4MDUtZ29vZwo+IAoKLS0gClNlYW4gUGF1bCwgU29mdHdhcmUgRW5n aW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=