From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shayenne Moura Subject: Re: [PATCH 4/7] drm: i915: Delete base.id prints Date: Wed, 19 Dec 2018 15:29:43 -0200 Message-ID: <20181219172943.yvccbanfeod3hcoj@smtp.gmail.com> References: <20181218133821.sykwt6wdeo7uf6o7@smtp.gmail.com> <20181219131254.GR21184@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181219131254.GR21184@phenom.ffwll.local> Sender: linux-kernel-owner@vger.kernel.org To: Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 12/19, Daniel Vetter wrote: > On Tue, Dec 18, 2018 at 11:38:21AM -0200, Shayenne Moura wrote: > > This patch removes base.id prints from drm_display_mode > > objects in i915 files. It removes dependency from drm_mode_object. > > > > Signed-off-by: Shayenne Moura > > Again I think better to switch to DRM_MODE_FMT/ARG. > -Daniel > This one has a different print style. Is it okay to change to DRM_MODE_FMT? Best, Shayenne > > --- > > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > > index 7f455bca528e..61dd7bb3fa85 100644 > > --- a/drivers/gpu/drm/i915/i915_debugfs.c > > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > > @@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs, > > for (i = 0; i < tabs; i++) > > seq_putc(m, '\t'); > > > > - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n", > > - mode->base.id, mode->name, > > + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n", > > + mode->name, > > mode->vrefresh, mode->clock, > > mode->hdisplay, mode->hsync_start, > > mode->hsync_end, mode->htotal, > > -- > > 2.17.1 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch