From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Wu Subject: Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup Date: Mon, 24 Dec 2018 00:10:33 +0100 Message-ID: <20181223231033.GA31596@al> References: <20181223004315.GA11455@al> <20181223005507.28328-1-peter@lekensteyn.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.lekensteyn.nl (mail.lekensteyn.nl [IPv6:2a02:2308::360:1:25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 90E3F6E04E for ; Sun, 23 Dec 2018 23:10:44 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: lkp@01.org, rong.a.chen@intel.com, Daniel Vetter , Linux List Kernel Mailing , dri-devel@lists.freedesktop.org, kraxel@redhat.com, Linus Torvalds List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBEZWMgMjMsIDIwMTggYXQgMDI6NTU6NTJQTSArMDEwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IAo+IAo+IERlbiAyMy4xMi4yMDE4IDAxLjU1LCBza3JldiBQZXRlciBXdToKPiA+ IEFmdGVyIGRybV9mYl9oZWxwZXJfZmJkZXZfc2V0dXAgY2FsbHMgZHJtX2ZiX2hlbHBlcl9pbml0 LAo+ID4gImRldi0+ZmJfaGVscGVyIiB3aWxsIGJlIGluaXRpYWxpemVkIChhbmQgdGh1cyBkcm1f ZmJfaGVscGVyX2Zpbmkgd2lsbAo+ID4gaGF2ZSBzb21lIGVmZmVjdCkuIEFmdGVyIHRoYXQsIGRy bV9mYl9oZWxwZXJfaW5pdGlhbF9jb25maWcgaXMgY2FsbGVkCj4gPiB3aGljaCBtYXkgY2FsbCB0 aGUgImZiX3Byb2JlIiBkcml2ZXIgY2FsbGJhY2suCj4gPiAKPiA+IFRoaXMgZHJpdmVyIGNhbGxi YWNrIG1heSBjYWxsIGRybV9mYl9oZWxwZXJfZGVmaW9faW5pdCAoYXMgaXMgZG9uZSBieQo+ID4g ZHJtX2ZiX2hlbHBlcl9nZW5lcmljX3Byb2JlKSBvciBzZXQgYSBmcmFtZWJ1ZmZlciAoYXMgaXMg ZG9uZSBieSBib2NocykKPiA+IGFzIGRvY3VtZW50ZWQuIFRoZXNlIGFyZSBub3JtYWxseSBjbGVh bmVkIHVwIG9uIGV4aXQgYnkKPiA+IGRybV9mYl9oZWxwZXJfZmJkZXZfdGVhcmRvd24gd2hpY2gg YWxzbyBjYWxscyBkcm1fZmJfaGVscGVyX2ZpbmkuCj4gPiAKPiA+IElmIGFuIGVycm9yIG9jY3Vy cyBhZnRlciAiZmJfcHJvYmUiLCBidXQgYmVmb3JlIHNldHVwIGlzIGNvbXBsZXRlLCB0aGVuCj4g PiBjYWxsaW5nIGp1c3QgZHJtX2ZiX2hlbHBlcl9maW5pIHdpbGwgbGVhayByZXNvdXJjZXMuIFRo aXMgd2FzIHRyaWdnZXJlZAo+ID4gYnkgZGYyMDUyY2M5MjIgKCJib2NoczogY29udmVydCB0byBk cm1fZmJfaGVscGVyX2ZiZGV2X3NldHVwL3RlYXJkb3duIik6Cj4gPiAKPiA+ICAgICAgWyAgIDUw LjAwODAzMF0gYm9jaHNkcm1mYjogZW5hYmxlIENPTkZJR19GQl9MSVRUTEVfRU5ESUFOIHRvIHN1 cHBvcnQgdGhpcyBmcmFtZWJ1ZmZlcgo+ID4gICAgICBbICAgNTAuMDA5NDM2XSBib2Nocy1kcm0g MDAwMDowMDowMi4wOiBbZHJtOmRybV9mYl9oZWxwZXJfZmJkZXZfc2V0dXBdICpFUlJPUiogZmJk ZXY6IEZhaWxlZCB0byBzZXQgY29uZmlndXJhdGlvbiAocmV0PS0zOCkKPiA+ICAgICAgWyAgIDUw LjAxMTQ1Nl0gW2RybV0gSW5pdGlhbGl6ZWQgYm9jaHMtZHJtIDEuMC4wIDIwMTMwOTI1IGZvciAw MDAwOjAwOjAyLjAgb24gbWlub3IgMgo+ID4gICAgICBbICAgNTAuMDEzNjA0XSBXQVJOSU5HOiBD UFU6IDEgUElEOiAxIGF0IGRyaXZlcnMvZ3B1L2RybS9kcm1fbW9kZV9jb25maWcuYzo0NzcgZHJt X21vZGVfY29uZmlnX2NsZWFudXArMHgyODAvMHgyYTAKPiA+ICAgICAgWyAgIDUwLjAxNjE3NV0g Q1BVOiAxIFBJRDogMSBDb21tOiBzd2FwcGVyLzAgVGFpbnRlZDogRyAgICAgICAgICAgICAgICBU IDQuMjAuMC1yYzcgIzEKPiA+ICAgICAgWyAgIDUwLjAxNzczMl0gRUlQOiBkcm1fbW9kZV9jb25m aWdfY2xlYW51cCsweDI4MC8weDJhMAo+ID4gICAgICAuLi4KPiA+ICAgICAgWyAgIDUwLjAyMzE1 NV0gQ2FsbCBUcmFjZToKPiA+ICAgICAgWyAgIDUwLjAyMzE1NV0gID8gYm9jaHNfa21zX2Zpbmkr MHgxZS8weDMwCj4gPiAgICAgIFsgICA1MC4wMjMxNTVdICA/IGJvY2hzX3VubG9hZCsweDE4LzB4 NDAKPiA+IAo+ID4gVGhpcyBjYW4gYmUgcmVwcm9kdWNlZCB3aXRoIFFFTVUgYW5kIENPTkZJR19G Ql9MSVRUTEVfRU5ESUFOPW4uCj4gPiAKPiA+IExpbms6IGh0dHBzOi8vbGttbC5rZXJuZWwub3Jn L3IvMjAxODEyMjEwODMyMjYuR0kyMzMzMkBzaGFvMi1kZWJpYW4KPiA+IExpbms6IGh0dHBzOi8v bGttbC5rZXJuZWwub3JnL3IvMjAxODEyMjMwMDQzMTUuR0ExMTQ1NUBhbAo+ID4gRml4ZXM6IDg3 NDEyMTYzOTZiMiAoImRybS9mYi1oZWxwZXI6IEFkZCBkcm1fZmJfaGVscGVyX2ZiZGV2X3NldHVw L3RlYXJkb3duKCkiKQo+ID4gUmVwb3J0ZWQtYnk6IGtlcm5lbCB0ZXN0IHJvYm90IDxyb25nLmEu Y2hlbkBpbnRlbC5jb20+Cj4gPiBDYzogTm9yYWxmIFRyw7hubmVzIDxub3JhbGZAdHJvbm5lcy5v cmc+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBQZXRlciBXdSA8cGV0ZXJAbGVrZW5zdGV5bi5ubD4KPiA+ IC0tLQo+ID4gICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIHwgMiArLQo+ID4gICAx IGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiA+IAo+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9k cm0vZHJtX2ZiX2hlbHBlci5jCj4gPiBpbmRleCA5ZDY0Zjg3NGY5NjUuLjQzMmUwZjNiOTI2NyAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiA+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiA+IEBAIC0yODYwLDcgKzI4NjAsNyBA QCBpbnQgZHJtX2ZiX2hlbHBlcl9mYmRldl9zZXR1cChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ ID4gICAJcmV0dXJuIDA7Cj4gPiAgIGVycl9kcm1fZmJfaGVscGVyX2Zpbmk6Cj4gPiAtCWRybV9m Yl9oZWxwZXJfZmluaShmYl9oZWxwZXIpOwo+ID4gKwlkcm1fZmJfaGVscGVyX2ZiZGV2X3RlYXJk b3duKGRldik7Cj4gCj4gVGhpcyBjaGFuZ2Ugd2lsbCBicmVhayB0aGUgZXJyb3IgcGF0aCBmb3Ig ZHJtX2ZiZGV2X2dlbmVyaWNfc2V0dXAoKQo+IGJlY2F1c2UgZHJtX2ZiX2hlbHBlcl9nZW5lcmlj X3Byb2JlKCkgY2xlYW5zIHVwIG9uIGVycm9yIGJ1dCBkb2Vzbid0Cj4gY2xlYXIgZHJtX2ZiX2hl bHBlci0+ZmIgcmVzdWx0aW5nIGluIGEgZG91YmxlIGRybV9mcmFtZWJ1ZmZlcl9yZW1vdmUoKS4K ClRoaXMgc2hvdWxkIHByb2JhYmx5IGNvbnNpZGVyZWQgYSBidWcgb2YgZHJtX2ZiX2hlbHBlcl9n ZW5lcmljX3Byb2JlLgpPd25lcnNoaXAgb2YgZmJfaGVscGVyIHNob3VsZCByZW1haW4gd2l0aCB0 aGUgY2FsbGVyLiBUaGUgY2FsbGVyIGNhbgpkZXRlY3QgYW4gZXJyb3IgYW5kIGFjdCBhY2NvcmRp bmdseS4KCj4gTXkgYXNzdW1wdGlvbiBoYXMgYmVlbiB0aGF0IHRoZSBkcm1fZmJfaGVscGVyX2Z1 bmNzLT5mYl9wcm9iZSBjYWxsYmFjawo+IGNsZWFucyB1cCBpdHMgcmVzb3VyY2VzIG9uIGVycm9y LiBDbGVhcmx5IHRoaXMgaXMgbm90IHRoZSBjYXNlIGZvciBib2Nocywgc28KPiBteSB0YWtlIG9u IHRoaXMgaXMgdGhhdCBib2Noc2ZiX2NyZWF0ZSgpIG5lZWRzIHRvIGNsZWFuIHVwIG9uIGVycm9y LgoKVGhhdCBhc3N1bXB0aW9uIHN0aWxsIGhvbGRzIGZvciBib2Nocy4gVGhlIHByb2JsZW0gaXMg dGhpcyBzZXF1ZW5jZToKLSBkcm1fZmJfaGVscGVyX2ZiZGV2X3NldHVwIGlzIGNhbGxlZC4KLSBm Yl9wcm9iZSBzdWNjZWVkcyAodGhpcyBpcyBjcnVjaWFsKS4KLSByZWdpc3Rlcl9mcmFtZWJ1ZmZl ciBmYWlscy4KLSBlcnJvciBwYXRoIG9mIHNldHVwIGlzIHRyaWdnZXJlZC4KCkFzIGZiX2hlbHBl ciBpcyBmdWxseSBzZXR1cCBieSBkcml2ZXJzLCB0aGUgZHJtX2ZiX2hlbHBlciBjb3JlIHNob3Vs ZApmdWxseSBkZWFsbG9jYXRlIGl0IGFnYWluIG9uIHRoZSBlcnJvciBwYXRoIG9yIGVsc2UgYSBs ZWFrIG9jY3Vycy4KCj4gR2VyZCBoYXMgYSBwYXRjaHNldCB0aGF0IHN3aXRjaGVzIGJvY2hzIG92 ZXIgdG8gdGhlIGdlbmVyaWMgZmJkZXYKPiBlbXVsYXRpb24sIGJ1dCBvZmMgdGhhdCBkb2Vzbid0 IGhlbHAgd2l0aCA0LjIwOgo+IGh0dHBzOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9zZXJp ZXMvNTQyNjkvCgpBbmQgdGhhdCBkb2VzIG5vdCBoZWxwIHdpdGggb3RoZXIgdXNlcnMgb2YgdGhl IGRybV9mYl9oZWxwZXIgd2hvIHVzZQpmdW5jdGlvbnMgbGlrZSBkcm1fZmJfaGVscGVyX2RlZmlv X2luaXQuIFRoZXkgd2lsbCBsaWtlbHkgcnVuIGluIHRoZQpzYW1lIHByb2JsZW0uCgpJIGRvbid0 IGhhdmUgYSB3YXkgdG8gdGVzdCB0aW55ZHJtIG9yIG90aGVyIGRyaXZlcnMsIGJ1dCBpZiB5b3Ug Zm9yY2UKcmVnaXN0ZXJfZnJhbWVidWZmZXIgdG8gZmFpbCwgeW91IHNob3VsZCBiZSBhYmxlIHRv IHJlcHJvZHVjZSB0aGUKcHJvYmxlbSB3aXRoIGRybV9mYl9oZWxwZXJfZ2VuZXJpY19wcm9iZS4K LS0gCktpbmQgcmVnYXJkcywKUGV0ZXIgV3UKaHR0cHM6Ly9sZWtlbnN0ZXluLm5sCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=