From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Wu <peter@lekensteyn.nl>
Subject: Re: [PATCH] drm/fb-helper: fix leaks in error path of
 drm_fb_helper_fbdev_setup
Date: Mon, 24 Dec 2018 16:03:02 +0100
Message-ID: <20181224150302.GA2259@al>
References: <20181223004315.GA11455@al>
 <20181223005507.28328-1-peter@lekensteyn.nl>
 <ad4be2e7-b53c-97b5-7029-83f4017e4643@tronnes.org>
 <20181223231033.GA31596@al>
 <80d98ab2-dbf8-8d77-e5ca-07995cef0f1b@tronnes.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail.lekensteyn.nl (mail.lekensteyn.nl
 [IPv6:2a02:2308::360:1:25])
 by gabe.freedesktop.org (Postfix) with ESMTPS id AC5CC6E5E5
 for <dri-devel@lists.freedesktop.org>; Mon, 24 Dec 2018 15:03:10 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <80d98ab2-dbf8-8d77-e5ca-07995cef0f1b@tronnes.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= <noralf@tronnes.org>
Cc: lkp@01.org, rong.a.chen@intel.com, Daniel Vetter <daniel.vetter@ffwll.ch>, Linux List Kernel Mailing <linux-kernel@vger.kernel.org>, dri-devel@lists.freedesktop.org, kraxel@redhat.com, Linus Torvalds <torvalds@linux-foundation.org>
List-Id: dri-devel@lists.freedesktop.org

T24gTW9uLCBEZWMgMjQsIDIwMTggYXQgMDM6NTI6NTVQTSArMDEwMCwgTm9yYWxmIFRyw7hubmVz
IHdyb3RlOgo+IAo+IAo+IERlbiAyNC4xMi4yMDE4IDAwLjEwLCBza3JldiBQZXRlciBXdToKPiA+
IE9uIFN1biwgRGVjIDIzLCAyMDE4IGF0IDAyOjU1OjUyUE0gKzAxMDAsIE5vcmFsZiBUcsO4bm5l
cyB3cm90ZToKPiA+ID4gCj4gPiA+IAo+ID4gPiBEZW4gMjMuMTIuMjAxOCAwMS41NSwgc2tyZXYg
UGV0ZXIgV3U6Cj4gPiA+ID4gQWZ0ZXIgZHJtX2ZiX2hlbHBlcl9mYmRldl9zZXR1cCBjYWxscyBk
cm1fZmJfaGVscGVyX2luaXQsCj4gPiA+ID4gImRldi0+ZmJfaGVscGVyIiB3aWxsIGJlIGluaXRp
YWxpemVkIChhbmQgdGh1cyBkcm1fZmJfaGVscGVyX2Zpbmkgd2lsbAo+ID4gPiA+IGhhdmUgc29t
ZSBlZmZlY3QpLiBBZnRlciB0aGF0LCBkcm1fZmJfaGVscGVyX2luaXRpYWxfY29uZmlnIGlzIGNh
bGxlZAo+ID4gPiA+IHdoaWNoIG1heSBjYWxsIHRoZSAiZmJfcHJvYmUiIGRyaXZlciBjYWxsYmFj
ay4KPiA+ID4gPiAKPiA+ID4gPiBUaGlzIGRyaXZlciBjYWxsYmFjayBtYXkgY2FsbCBkcm1fZmJf
aGVscGVyX2RlZmlvX2luaXQgKGFzIGlzIGRvbmUgYnkKPiA+ID4gPiBkcm1fZmJfaGVscGVyX2dl
bmVyaWNfcHJvYmUpIG9yIHNldCBhIGZyYW1lYnVmZmVyIChhcyBpcyBkb25lIGJ5IGJvY2hzKQo+
ID4gPiA+IGFzIGRvY3VtZW50ZWQuIFRoZXNlIGFyZSBub3JtYWxseSBjbGVhbmVkIHVwIG9uIGV4
aXQgYnkKPiA+ID4gPiBkcm1fZmJfaGVscGVyX2ZiZGV2X3RlYXJkb3duIHdoaWNoIGFsc28gY2Fs
bHMgZHJtX2ZiX2hlbHBlcl9maW5pLgo+ID4gPiA+IAo+ID4gPiA+IElmIGFuIGVycm9yIG9jY3Vy
cyBhZnRlciAiZmJfcHJvYmUiLCBidXQgYmVmb3JlIHNldHVwIGlzIGNvbXBsZXRlLCB0aGVuCj4g
PiA+ID4gY2FsbGluZyBqdXN0IGRybV9mYl9oZWxwZXJfZmluaSB3aWxsIGxlYWsgcmVzb3VyY2Vz
LiBUaGlzIHdhcyB0cmlnZ2VyZWQKPiA+ID4gPiBieSBkZjIwNTJjYzkyMiAoImJvY2hzOiBjb252
ZXJ0IHRvIGRybV9mYl9oZWxwZXJfZmJkZXZfc2V0dXAvdGVhcmRvd24iKToKPiA+ID4gPiAKPiA+
ID4gPiAgICAgICBbICAgNTAuMDA4MDMwXSBib2Noc2RybWZiOiBlbmFibGUgQ09ORklHX0ZCX0xJ
VFRMRV9FTkRJQU4gdG8gc3VwcG9ydCB0aGlzIGZyYW1lYnVmZmVyCj4gPiA+ID4gICAgICAgWyAg
IDUwLjAwOTQzNl0gYm9jaHMtZHJtIDAwMDA6MDA6MDIuMDogW2RybTpkcm1fZmJfaGVscGVyX2Zi
ZGV2X3NldHVwXSAqRVJST1IqIGZiZGV2OiBGYWlsZWQgdG8gc2V0IGNvbmZpZ3VyYXRpb24gKHJl
dD0tMzgpCj4gPiA+ID4gICAgICAgWyAgIDUwLjAxMTQ1Nl0gW2RybV0gSW5pdGlhbGl6ZWQgYm9j
aHMtZHJtIDEuMC4wIDIwMTMwOTI1IGZvciAwMDAwOjAwOjAyLjAgb24gbWlub3IgMgo+ID4gPiA+
ICAgICAgIFsgICA1MC4wMTM2MDRdIFdBUk5JTkc6IENQVTogMSBQSUQ6IDEgYXQgZHJpdmVycy9n
cHUvZHJtL2RybV9tb2RlX2NvbmZpZy5jOjQ3NyBkcm1fbW9kZV9jb25maWdfY2xlYW51cCsweDI4
MC8weDJhMAo+ID4gPiA+ICAgICAgIFsgICA1MC4wMTYxNzVdIENQVTogMSBQSUQ6IDEgQ29tbTog
c3dhcHBlci8wIFRhaW50ZWQ6IEcgICAgICAgICAgICAgICAgVCA0LjIwLjAtcmM3ICMxCj4gPiA+
ID4gICAgICAgWyAgIDUwLjAxNzczMl0gRUlQOiBkcm1fbW9kZV9jb25maWdfY2xlYW51cCsweDI4
MC8weDJhMAo+ID4gPiA+ICAgICAgIC4uLgo+ID4gPiA+ICAgICAgIFsgICA1MC4wMjMxNTVdIENh
bGwgVHJhY2U6Cj4gPiA+ID4gICAgICAgWyAgIDUwLjAyMzE1NV0gID8gYm9jaHNfa21zX2Zpbmkr
MHgxZS8weDMwCj4gPiA+ID4gICAgICAgWyAgIDUwLjAyMzE1NV0gID8gYm9jaHNfdW5sb2FkKzB4
MTgvMHg0MAo+ID4gPiA+IAo+ID4gPiA+IFRoaXMgY2FuIGJlIHJlcHJvZHVjZWQgd2l0aCBRRU1V
IGFuZCBDT05GSUdfRkJfTElUVExFX0VORElBTj1uLgo+ID4gPiA+IAo+ID4gPiA+IExpbms6IGh0
dHBzOi8vbGttbC5rZXJuZWwub3JnL3IvMjAxODEyMjEwODMyMjYuR0kyMzMzMkBzaGFvMi1kZWJp
YW4KPiA+ID4gPiBMaW5rOiBodHRwczovL2xrbWwua2VybmVsLm9yZy9yLzIwMTgxMjIzMDA0MzE1
LkdBMTE0NTVAYWwKPiA+ID4gPiBGaXhlczogODc0MTIxNjM5NmIyICgiZHJtL2ZiLWhlbHBlcjog
QWRkIGRybV9mYl9oZWxwZXJfZmJkZXZfc2V0dXAvdGVhcmRvd24oKSIpCj4gPiA+ID4gUmVwb3J0
ZWQtYnk6IGtlcm5lbCB0ZXN0IHJvYm90IDxyb25nLmEuY2hlbkBpbnRlbC5jb20+Cj4gPiA+ID4g
Q2M6IE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgo+ID4gPiA+IFNpZ25lZC1v
ZmYtYnk6IFBldGVyIFd1IDxwZXRlckBsZWtlbnN0ZXluLm5sPgo+ID4gPiA+IC0tLQo+ID4gPiA+
ICAgIGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMgfCAyICstCj4gPiA+ID4gICAgMSBm
aWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+ID4gCj4gPiA+
ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMgYi9kcml2ZXJz
L2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gPiA+ID4gaW5kZXggOWQ2NGY4NzRmOTY1Li40MzJl
MGYzYjkyNjcgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxw
ZXIuYwo+ID4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiA+ID4g
PiBAQCAtMjg2MCw3ICsyODYwLDcgQEAgaW50IGRybV9mYl9oZWxwZXJfZmJkZXZfc2V0dXAoc3Ry
dWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ID4gPiAgICAJcmV0dXJuIDA7Cj4gPiA+ID4gICAgZXJy
X2RybV9mYl9oZWxwZXJfZmluaToKPiA+ID4gPiAtCWRybV9mYl9oZWxwZXJfZmluaShmYl9oZWxw
ZXIpOwo+ID4gPiA+ICsJZHJtX2ZiX2hlbHBlcl9mYmRldl90ZWFyZG93bihkZXYpOwo+ID4gPiAK
PiA+ID4gVGhpcyBjaGFuZ2Ugd2lsbCBicmVhayB0aGUgZXJyb3IgcGF0aCBmb3IgZHJtX2ZiZGV2
X2dlbmVyaWNfc2V0dXAoKQo+ID4gPiBiZWNhdXNlIGRybV9mYl9oZWxwZXJfZ2VuZXJpY19wcm9i
ZSgpIGNsZWFucyB1cCBvbiBlcnJvciBidXQgZG9lc24ndAo+ID4gPiBjbGVhciBkcm1fZmJfaGVs
cGVyLT5mYiByZXN1bHRpbmcgaW4gYSBkb3VibGUgZHJtX2ZyYW1lYnVmZmVyX3JlbW92ZSgpLgo+
ID4gCj4gPiBUaGlzIHNob3VsZCBwcm9iYWJseSBjb25zaWRlcmVkIGEgYnVnIG9mIGRybV9mYl9o
ZWxwZXJfZ2VuZXJpY19wcm9iZS4KPiA+IE93bmVyc2hpcCBvZiBmYl9oZWxwZXIgc2hvdWxkIHJl
bWFpbiB3aXRoIHRoZSBjYWxsZXIuIFRoZSBjYWxsZXIgY2FuCj4gPiBkZXRlY3QgYW4gZXJyb3Ig
YW5kIGFjdCBhY2NvcmRpbmdseS4KPiA+IAo+ID4gPiBNeSBhc3N1bXB0aW9uIGhhcyBiZWVuIHRo
YXQgdGhlIGRybV9mYl9oZWxwZXJfZnVuY3MtPmZiX3Byb2JlIGNhbGxiYWNrCj4gPiA+IGNsZWFu
cyB1cCBpdHMgcmVzb3VyY2VzIG9uIGVycm9yLiBDbGVhcmx5IHRoaXMgaXMgbm90IHRoZSBjYXNl
IGZvciBib2Nocywgc28KPiA+ID4gbXkgdGFrZSBvbiB0aGlzIGlzIHRoYXQgYm9jaHNmYl9jcmVh
dGUoKSBuZWVkcyB0byBjbGVhbiB1cCBvbiBlcnJvci4KPiA+IAo+ID4gVGhhdCBhc3N1bXB0aW9u
IHN0aWxsIGhvbGRzIGZvciBib2Nocy4gVGhlIHByb2JsZW0gaXMgdGhpcyBzZXF1ZW5jZToKPiA+
IC0gZHJtX2ZiX2hlbHBlcl9mYmRldl9zZXR1cCBpcyBjYWxsZWQuCj4gPiAtIGZiX3Byb2JlIHN1
Y2NlZWRzICh0aGlzIGlzIGNydWNpYWwpLgo+ID4gLSByZWdpc3Rlcl9mcmFtZWJ1ZmZlciBmYWls
cy4KPiA+IC0gZXJyb3IgcGF0aCBvZiBzZXR1cCBpcyB0cmlnZ2VyZWQuCj4gPiAKPiA+IEFzIGZi
X2hlbHBlciBpcyBmdWxseSBzZXR1cCBieSBkcml2ZXJzLCB0aGUgZHJtX2ZiX2hlbHBlciBjb3Jl
IHNob3VsZAo+ID4gZnVsbHkgZGVhbGxvY2F0ZSBpdCBhZ2FpbiBvbiB0aGUgZXJyb3IgcGF0aCBv
ciBlbHNlIGEgbGVhayBvY2N1cnMuCj4gPiAKPiA+ID4gR2VyZCBoYXMgYSBwYXRjaHNldCB0aGF0
IHN3aXRjaGVzIGJvY2hzIG92ZXIgdG8gdGhlIGdlbmVyaWMgZmJkZXYKPiA+ID4gZW11bGF0aW9u
LCBidXQgb2ZjIHRoYXQgZG9lc24ndCBoZWxwIHdpdGggNC4yMDoKPiA+ID4gaHR0cHM6Ly9wYXRj
aHdvcmsuZnJlZWRlc2t0b3Aub3JnL3Nlcmllcy81NDI2OS8KPiA+IAo+ID4gQW5kIHRoYXQgZG9l
cyBub3QgaGVscCB3aXRoIG90aGVyIHVzZXJzIG9mIHRoZSBkcm1fZmJfaGVscGVyIHdobyB1c2UK
PiA+IGZ1bmN0aW9ucyBsaWtlIGRybV9mYl9oZWxwZXJfZGVmaW9faW5pdC4gVGhleSB3aWxsIGxp
a2VseSBydW4gaW4gdGhlCj4gPiBzYW1lIHByb2JsZW0uCj4gPiAKPiA+IEkgZG9uJ3QgaGF2ZSBh
IHdheSB0byB0ZXN0IHRpbnlkcm0gb3Igb3RoZXIgZHJpdmVycywgYnV0IGlmIHlvdSBmb3JjZQo+
ID4gcmVnaXN0ZXJfZnJhbWVidWZmZXIgdG8gZmFpbCwgeW91IHNob3VsZCBiZSBhYmxlIHRvIHJl
cHJvZHVjZSB0aGUKPiA+IHByb2JsZW0gd2l0aCBkcm1fZmJfaGVscGVyX2dlbmVyaWNfcHJvYmUu
Cj4gPiAKPiAKPiBOb3cgSSB1bmRlcnN0YW5kLiBJIGhhdmUgbG9va2VkIGF0IHRoZSBkcml2ZXJz
IHRoYXQgdXNlIGRybV9mYl9oZWxwZXIKPiBhbmQgbm8gb25lIHNlZW0gdG8gaGFuZGxlIHRoZSBj
YXNlIHdoZXJlIHJlZ2lzdGVyX2ZyYW1lYnVmZmVyKCkgaXMKPiBmYWlsaW5nLgo+IAo+IEhlcmUn
cyB3aGF0IGRyaXZlcnMgZG8gd2hlbiBkcm1fZmJfaGVscGVyX2luaXRpYWxfY29uZmlnKCkgZmFp
bHM6Cj4gCj4gRG9lc24ndCBjaGVjazoKPiBhbWRncHUKPiB2aXJ0aW8KPiAKPiBDYWxscyBkcm1f
ZmJfaGVscGVyX2ZpbmkoKToKPiBhcm1hZGEKPiBhc3QKPiBleHlub3MKPiBnbWE1MDAKPiBoaXNp
bGljb24KPiBtZ2FnMjAwCj4gbXNtCj4gbm91dmVhdQo+IG9tYXAKPiByYWRlb24KPiByb2NrY2hp
cAo+IHRlZ3JhCj4gdWRsCj4gYm9jaHMgLSBVc2VzIGRybV9mYl9oZWxwZXJfZmJkZXZfc2V0dXAo
KQo+IHF4bCAtIFVzZXMgZHJtX2ZiX2hlbHBlcl9mYmRldl9zZXR1cCgpCj4gdmJveHZpZGVvIC0g
VXNlcyBkcm1fZmJfaGVscGVyX2ZiZGV2X3NldHVwKCkKPiAKPiBNaWdodCBjbGVhbiB1cCwgbm90
IHN1cmU6Cj4gY2lycnVzCj4gCj4gTG9va3Mgc3VzcGljaW91czoKPiBpOTE1Cj4gCj4gSSBsb29r
ZWQgYXQgYm9jaHMgYmVmb3JlIGl0IHN3aXRjaGVkIHRvIGRybV9mYl9oZWxwZXJfZmJkZXZfc2V0
dXAoKSBhbmQKPiBpdCBhbHNvIGp1c3QgY2FsbGVkIGRybV9mYl9oZWxwZXJfZmluaSgpLgo+IAo+
IEl0IGxvb2tzIGxpa2UgeW91J3ZlIHVuY292ZXJlZCBzb21ldGhpbmcgbm8gb25lIGhhcyB0aG91
Z2ggYWJvdXQgKG9yCj4gbm90IGltcGxlbWVudGVkIGF0IGxlYXN0KS4KPiAKPiBJdCdzIG5vdCBq
dXN0IHRoZSBmcmFtZWJ1ZmZlciB0aGF0J3Mgbm90IGRlc3Ryb3llZCwgdGhlIGJ1ZmZlciBvYmpl
Y3QKPiBpcyBhbHNvIGxlYWtlZC4gZHJtX21vZGVfY29uZmlnX2NsZWFudXAoKSB5ZWxscyBhYm91
dCB0aGUgZnJhbWVidWZmZXIKPiAoYW5kIGZyZWVzIGl0KSwgYnV0IHNheXMgbm90aGluZyBhYm91
dCB0aGUgYnVmZmVyIG9iamVjdC4gSXQgbWlnaHQgYmUKPiB0aGF0IGl0IGNhbid0IGV2ZW4gYmUg
bWFkZSB0byBkZXRlY3QgdGhhdCBzaW5jZSBzb21lIGRyaXZlcnMgZG8gc3BlY2lhbAo+IHN0dWZm
IGZvciB0aGUgZmJkZXYgYnVmZmVyLgo+IAo+IEknbGwgcGljayB1cCBvbiB0aGlzIGFuZCBkbyBz
b21lIHRlc3RpbmcgYWZ0ZXIgdGhlIENocmlzdG1hcyBob2xpZGF5cy4KClRoYW5rcywgdGhlIHdh
cm5pbmcgaXMgYmFkIGZvciBDSSAod2hpY2ggdXNlcyBRRU1VKSwgYnV0IG90aGVyd2lzZSBpdApz
aG91bGQgbm90IGhhdmUgYW55IGVmZmVjdCBvbiByZWd1bGFyIHVzZXJzIHNvIGl0IGNhbiB3YWl0
LgotLSAKS2luZCByZWdhcmRzLApQZXRlciBXdQpodHRwczovL2xla2Vuc3RleW4ubmwKX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp
bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==