From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v1 7/7] drm: remove include of drmP.h from drm_gem_cma_helper.h Date: Thu, 27 Dec 2018 23:22:09 +0100 Message-ID: <20181227222209.GB29366@ravnborg.org> References: <20181226210215.GA27610@ravnborg.org> <20181226210353.13993-7-sam@ravnborg.org> <6c792214-ed92-e942-0e3d-72628c037d00@lechnology.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <6c792214-ed92-e942-0e3d-72628c037d00@lechnology.com> Sender: linux-kernel-owner@vger.kernel.org To: David Lechner Cc: Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Sean Paul , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alexey Brodkin , Yannick Fertre , Philippe Cornu , Benjamin Gaignard , Vincent Abriou , Maxime Coquelin , Alexandre Torgue , Noralf =?iso-8859-1?Q?Tr=F8nnes?= List-Id: dri-devel@lists.freedesktop.org Hi David. Thanks for your comments. On Thu, Dec 27, 2018 at 10:28:07AM -0600, David Lechner wrote: > On 12/26/18 3:03 PM, Sam Ravnborg wrote: > >Fix fallout in various files/drivers. > > > > What fallout is being fixed? The removal of drmP.h from drm_gem_cma_helper.h resulted in some build erros that is fixed by this patch. drmP.h was removed from the header file to make it possible to remove drmP.h on a file-by-file (or driver-by-driver) basis for the rest of gpu/drm/* > It would be helpful if we received the full > patch series for context. It would also be nice to have a more detailed > description in this commit message. The cc: list was too long to include everyone in the cover letter. In v2 I will make the individual commit message self explaning. For v2 I also need to re-vist the changes as I have added include files in some cases where a forward declaration would have been enough. Sam