From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v1 2/2] drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock Date: Fri, 28 Dec 2018 13:06:53 +0100 Message-ID: <20181228120652.GR9058@dvetter-linux.ger.corp.intel.com> References: <20181227231308.16904-1-mironov.ivan@gmail.com> <20181227231308.16904-3-mironov.ivan@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id F105F6E4D0 for ; Fri, 28 Dec 2018 12:06:57 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id f23so17402750edb.3 for ; Fri, 28 Dec 2018 04:06:57 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181227231308.16904-3-mironov.ivan@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ivan Mironov Cc: Maxime Ripard , Eugeniy Paltsev , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, saahriktu , David Airlie , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBEZWMgMjgsIDIwMTggYXQgMDQ6MTM6MDhBTSArMDUwMCwgSXZhbiBNaXJvbm92IHdy b3RlOgo+IFN0cmljdCByZXF1aXJlbWVudCBvZiBwaXhjbG9jayB0byBiZSB6ZXJvIGJyZWFrcyBz dXBwb3J0IG9mIFNETCAxLjIKPiB3aGljaCBjb250YWlucyBoYXJkY29kZWQgdGFibGUgb2Ygc3Vw cG9ydGVkIHZpZGVvIG1vZGVzIHdpdGggbm9uLXplcm8KPiBwaXhjbG9jayB2YWx1ZXNbMV0uCj4g Cj4gVG8gYmV0dGVyIHVuZGVyc3RhbmQgd2hpY2ggcGl4Y2xvY2sgdmFsdWVzIGFyZSBjb25zaWRl cmVkIHZhbGlkIGFuZCBob3cKPiBkcml2ZXIgc2hvdWxkIGhhbmRsZSB0aGVzZSB2YWx1ZXMsIEkg YnJpZWZseSBleGFtaW5lZCBmZXcgZXhpc3RpbmcgZmJkZXYKPiBkcml2ZXJzIGFuZCBkb2N1bWVu dGF0aW9uIGluIERvY3VtZW50YXRpb24vZmIvLiBBbmQgaXQgbG9va3MgbGlrZSB0aGVyZQo+IGFy ZSBubyBzdHJpY3QgcnVsZXMgb24gdGhhdCBhbmQgYWN0dWFsIGJlaGF2aW91ciB2YXJpZXM6Cj4g Cj4gCSogc29tZSBkcml2ZXJzIHRyZWF0IChwaXhjbG9jayA9PSAwKSBhcyAidXNlIGRlZmF1bHRz IiAodXZlc2FmYi5jKTsKPiAJKiBzb21lIHRyZWF0IChwaXhjbG9jayA9PSAwKSBhcyBpbnZhbGlk IHZhbHVlIHdoaWNoIGxlYWRzIHRvCj4gCSAgLUVJTlZBTCAoY2xwczcxMXgtZmIuYyk7Cj4gCSog c29tZSBwYXNzIGNvbnZlcnRlZCBwaXhjbG9jayB2YWx1ZSB0byBoYXJkd2FyZSAodXZlc2FmYi5j KTsKPiAJKiBzb21lIGFyZSB0cnlpbmcgdG8gZmluZCBuZWFyZXN0IHZhbHVlIGZyb20gcHJlZGVm aW5lZCB0YWJsZQo+ICAgICAgICAgICAodmdhMTZmYi5jLCB2aWRlb19neC5jKS4KPiAKPiBHaXZl biB0aGlzLCBJIGJlbGlldmUgdGhhdCBpdCBzaG91bGQgYmUgc2FmZSB0byBqdXN0IGlnbm9yZSB0 aGlzIHZhbHVlIGlmCj4gY2hhbmdpbmcgaXMgbm90IHN1cHBvcnRlZC4gSXQgc2VlbXMgdGhhdCBh bnkgcG9ydGFibGUgZmJkZXYgYXBwbGljYXRpb24KPiB3aGljaCB3YXMgbm90IHdyaXR0ZW4gb25s eSBmb3Igb25lIHNwZWNpZmljIGRldmljZSB3b3JraW5nIHVuZGVyIG9uZQo+IHNwZWNpZmljIGtl cm5lbCB2ZXJzaW9uIHNob3VsZCBub3QgcmVseSBvbiBhbnkgcGFydGljdWxhciBiZWhhdmlvdXIg b2YKPiBwaXhjbG9jayBhbnl3YXkuCj4gCj4gSG93ZXZlciwgd2hpbGUgZW5hYmxpbmcgU0RMMSBh cHBsaWNhdGlvbnMgdG8gd29yayBvdXQgb2YgdGhlIGJveCB3aGVuCj4gdGhlcmUgaXMgbm8gL2V0 Yy9mYi5tb2RlcyB3aXRoIHZhbGlkIHNldHRpbmdzLCB0aGlzIGNoYW5nZSBhZmZlY3RzIHRoZQo+ IHZpZGVvIG1vZGUgY2hvb3NpbmcgbG9naWMgaW4gU0RMLiBEZXBlbmRpbmcgb24gY3VycmVudCBz Y3JlZW4KPiByZXNvbHV0aW9uLCBjb250ZW50cyBvZiAvZXRjL2ZiLm1vZGVzIGFuZCByZXNvbHV0 aW9uIHJlcXVlc3RlZCBieQo+IGFwcGxpY2F0aW9uLCB0aGlzIG1heSBsZWFkIHRvIHVzZXItdmlz aWJsZSBkaWZmZXJlbmNlIChub3QgYWx3YXlzKToKPiBpbWFnZSB3aWxsIGJlIGRpc3BsYXllZCBp biBhIHJpZ2h0IHdheSwgYnV0IGl0IHdpbGwgYmUgYWxpZ25lZCB0byB0aGUKPiBsZWZ0IGluc3Rl YWQgb2YgY2VudGVyLiBUaGVyZSBpcyBubyAicmlnaHQgYmVoYXZpb3VyIiBoZXJlIGFzIHdlbGws IGFzCj4gZW11bGF0ZWQgZmJkZXYsIG9wcG9zaW5nIHRvIG9sZCBmYmRldiBkcml2ZXJzLCBzaW1w bHkgaWdub3JlcyBhbnkKPiByZXF1c3RzIG9mIHZpZGVvIG1vZGUgY2hhbmdlcyB3aXRoIHJlc29s dXRpb25zIHNtYWxsZXIgdGhhbiBjdXJyZW50Lgo+IAo+IEZlZWwgZnJlZSB0byBOQUsgdGhpcyBw YXRjaCBpZiB5b3UgdGhpbmsgdGhhdCBpdCBjYXVzZXMgYnJlYWthZ2Ugb2YKPiB1c2VyLXNwYWNl ID0pLgoKSXQncyBhIHJlZ3Jlc3Npb24sIHdlIGRvbid0IG5hY2sgcmVncmVzc2lvbiBmaXhlcyA6 LSkKCj4gVGhlIGVhc2llc3Qgd2F5IHRvIHJlcHJvZHVjZSB0aGlzIHByb2JsZW0gaXMgdG8gaW5z dGFsbCBzZGwtc29wd2l0aFsyXSwKPiByZW1vdmUgL2V0Yy9mYi5tb2RlcyBmaWxlIGlmIGl0IGV4 aXN0cywgYW5kIHRoZW4gdHJ5IHRvIHJ1biBzb3B3aXRoCj4gZnJvbSBjb25zb2xlIHdpdGhvdXQg WC4gQXQgbGVhc3QgaW4gRmVkb3JhIDI5LCBzb3B3aXRoIG1heSBiZSBzaW1wbHkKPiBpbnN0YWxs ZWQgZnJvbSBzdGFuZGFyZCByZXBvc2l0b3JpZXMuCj4gCj4gWzFdIFNETCAxLjIuMTUgc291cmNl IGNvZGUsIHNyYy92aWRlby9mYmNvbi9TRExfZmJ2aWRlby5jLCB2ZXNhX3RpbWluZ3MKPiBbMl0g aHR0cDovL3NkbC1zb3B3aXRoLnNvdXJjZWZvcmdlLm5ldC8KPiAKPiBTaWduZWQtb2ZmLWJ5OiBJ dmFuIE1pcm9ub3YgPG1pcm9ub3YuaXZhbkBnbWFpbC5jb20+CgpJIHRob3VnaHQgdGhpcyBpcyBh bHNvIGEgcmVncmVzc2lvbiBmaXgsIHNvIGFsc28gbmVlZHMgRml4ZXM6IGFuZCBjYzoKc3RhYmxl PwotRGFuaWVsCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIHwgNyAr KysrKystCj4gIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiBpbmRleCBhZmY1NzZjM2M0ZmIuLmI5NWEwYzIz YzdjOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+IEBAIC0xNjkwLDkgKzE2OTAsMTQg QEAgaW50IGRybV9mYl9oZWxwZXJfY2hlY2tfdmFyKHN0cnVjdCBmYl92YXJfc2NyZWVuaW5mbyAq dmFyLAo+ICAJc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlciA9IGluZm8tPnBhcjsKPiAg CXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0gZmJfaGVscGVyLT5mYjsKPiAgCj4gLQlpZiAo dmFyLT5waXhjbG9jayAhPSAwIHx8IGluX2RiZ19tYXN0ZXIoKSkKPiArCWlmIChpbl9kYmdfbWFz dGVyKCkpCj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gIAo+ICsJaWYgKHZhci0+cGl4Y2xvY2sgIT0g MCkgewo+ICsJCURSTV9ERUJVRygiZmJkZXYgZW11bGF0aW9uIGRvZXNuJ3Qgc3VwcG9ydCBjaGFu Z2luZyB0aGUgcGl4ZWwgY2xvY2ssIHZhbHVlIG9mIHBpeGNsb2NrIGlzIGlnbm9yZWRcbiIpOwo+ ICsJCXZhci0+cGl4Y2xvY2sgPSAwOwo+ICsJfQo+ICsKPiAgCWlmICgoZHJtX2Zvcm1hdF9pbmZv X2Jsb2NrX3dpZHRoKGZiLT5mb3JtYXQsIDApID4gMSkgfHwKPiAgCSAgICAoZHJtX2Zvcm1hdF9p bmZvX2Jsb2NrX2hlaWdodChmYi0+Zm9ybWF0LCAwKSA+IDEpKQo+ICAJCXJldHVybiAtRUlOVkFM Owo+IC0tIAo+IDIuMjAuMQo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIs IEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=