From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Sam Ravnborg <sam@ravnborg.org>,
dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 1/6] drm: include drm_device.h from drm_legacy.h
Date: Fri, 28 Dec 2018 13:10:22 +0100 [thread overview]
Message-ID: <20181228121022.GT9058@dvetter-linux.ger.corp.intel.com> (raw)
In-Reply-To: <877efuvz4r.fsf@intel.com>
On Fri, Dec 28, 2018 at 10:23:00AM +0200, Jani Nikula wrote:
> On Thu, 27 Dec 2018, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Thu, Dec 27, 2018 at 05:04:20PM +0100, Daniel Vetter wrote:
> >> On Thu, Dec 27, 2018 at 02:56:36PM +0200, Jani Nikula wrote:
> >> > Make it easier to drop drmP.h includes.
> >> >
> >> > Cc: Sam Ravnborg <sam@ravnborg.org>
> >> > Cc: Daniel Vetter <daniel@ffwll.ch>
> >> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >> > ---
> >> > include/drm/drm_legacy.h | 1 +
> >> > 1 file changed, 1 insertion(+)
> >> >
> >> > diff --git a/include/drm/drm_legacy.h b/include/drm/drm_legacy.h
> >> > index 8fad66f88e4f..743d7e70c896 100644
> >> > --- a/include/drm/drm_legacy.h
> >> > +++ b/include/drm/drm_legacy.h
> >> > @@ -2,6 +2,7 @@
> >> > #define __DRM_DRM_LEGACY_H__
> >> >
> >> > #include <drm/drm_auth.h>
> >> > +#include <drm/drm_device.h>
> >>
> >> From a quick look, shouldn't a
> >>
> >> struct drm_device;
> >>
> >> forward decl be enough? You might need a pile more forward decl, but
> >> that's all drm_device.h seems to pull in that drm_legacy.h needs.
> >
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> with the forward decl
> > (assuming it all works out).
>
> The forward declaration is not enough, there's a &dev->maplist reference
> in the static inline drm_legacy_findmap().
Missed that, despite that I tried checking for static inlines. And a
static inline for a O(n) lookup ... tempted to just deinline that.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> on either your v1 or a
patch that deinlines the offending function and just uses a forward decl.
Cheers, Daniel
>
> BR,
> Jani.
>
> > -Daniel
> >
> >> -Daniel
> >> >
> >> > /*
> >> > * Legacy driver interfaces for the Direct Rendering Manager
> >> > --
> >> > 2.11.0
> >> >
> >>
> >> --
> >> Daniel Vetter
> >> Software Engineer, Intel Corporation
> >> http://blog.ffwll.ch
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-12-28 12:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 12:56 [PATCH 0/6] drm/i915: drmP.h include removal w/ drm prep work Jani Nikula
2018-12-27 12:56 ` [PATCH 1/6] drm: include drm_device.h from drm_legacy.h Jani Nikula
2018-12-27 16:04 ` Daniel Vetter
2018-12-27 16:08 ` Daniel Vetter
2018-12-28 8:23 ` Jani Nikula
2018-12-28 12:10 ` Daniel Vetter [this message]
2018-12-28 13:05 ` Jani Nikula
2018-12-28 13:04 ` [PATCH v2] drm: un-inline drm_legacy_findmap() Jani Nikula
2018-12-28 14:11 ` Daniel Vetter
2018-12-30 18:57 ` Laurent Pinchart
2018-12-27 12:56 ` [PATCH 2/6] drm: include kernel.h and agp_backend.h from intel-gtt.h Jani Nikula
2018-12-27 16:04 ` Daniel Vetter
2018-12-27 12:56 ` [PATCH 3/6] drm: include idr.h from drm_file.h Jani Nikula
2018-12-27 16:05 ` Daniel Vetter
2018-12-30 19:03 ` Laurent Pinchart
2018-12-27 12:56 ` [PATCH 4/6] drm: include types.h from drm_hdcp.h Jani Nikula
2018-12-27 16:07 ` Daniel Vetter
2018-12-30 19:12 ` Laurent Pinchart
2018-12-27 12:56 ` [PATCH 5/6] drm: include drm_file.h from drm_syncobj.h Jani Nikula
2018-12-27 16:08 ` Daniel Vetter
2018-12-28 8:28 ` [PATCH v2] drm: forward declare struct drm_file in drm_syncobj.h Jani Nikula
2018-12-30 19:16 ` Laurent Pinchart
2018-12-27 12:56 ` [PATCH 6/6] drm/i915: drop all drmP.h includes Jani Nikula
2018-12-27 16:12 ` Daniel Vetter
2018-12-27 16:27 ` Jani Nikula
2018-12-28 11:59 ` Daniel Vetter
2018-12-27 12:59 ` [PATCH 0/6] drm/i915: drmP.h include removal w/ drm prep work Jani Nikula
2018-12-27 16:01 ` Daniel Vetter
2018-12-28 15:01 ` Jani Nikula
2019-01-02 7:47 ` Jani Nikula
2019-01-02 8:25 ` Laurent Pinchart
2019-01-02 9:45 ` Jani Nikula
2018-12-28 12:33 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181228121022.GT9058@dvetter-linux.ger.corp.intel.com \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox