From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v1 2/2] drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock Date: Mon, 7 Jan 2019 11:10:22 +0100 Message-ID: <20190107101022.GA21184@phenom.ffwll.local> References: <20181227231308.16904-1-mironov.ivan@gmail.com> <20181227231308.16904-3-mironov.ivan@gmail.com> <20181228120652.GR9058@dvetter-linux.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 491356E2B7 for ; Mon, 7 Jan 2019 10:10:27 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id a20so296010edc.8 for ; Mon, 07 Jan 2019 02:10:27 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ivan Mironov Cc: Maxime Ripard , Eugeniy Paltsev , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, saahriktu , David Airlie , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCBKYW4gMDUsIDIwMTkgYXQgMDk6MjE6MjFQTSArMDUwMCwgSXZhbiBNaXJvbm92IHdy b3RlOgo+IE9uIEZyaSwgMjAxOC0xMi0yOCBhdCAxMzowNiArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiA+IE9uIEZyaSwgRGVjIDI4LCAyMDE4IGF0IDA0OjEzOjA4QU0gKzA1MDAsIEl2YW4g TWlyb25vdiB3cm90ZToKPiA+ID4gU3RyaWN0IHJlcXVpcmVtZW50IG9mIHBpeGNsb2NrIHRvIGJl IHplcm8gYnJlYWtzIHN1cHBvcnQgb2YgU0RMIDEuMgo+ID4gPiB3aGljaCBjb250YWlucyBoYXJk Y29kZWQgdGFibGUgb2Ygc3VwcG9ydGVkIHZpZGVvIG1vZGVzIHdpdGggbm9uLXplcm8KPiA+ID4g cGl4Y2xvY2sgdmFsdWVzWzFdLgo+ID4gPiAKPiA+ID4gVG8gYmV0dGVyIHVuZGVyc3RhbmQgd2hp Y2ggcGl4Y2xvY2sgdmFsdWVzIGFyZSBjb25zaWRlcmVkIHZhbGlkIGFuZCBob3cKPiA+ID4gZHJp dmVyIHNob3VsZCBoYW5kbGUgdGhlc2UgdmFsdWVzLCBJIGJyaWVmbHkgZXhhbWluZWQgZmV3IGV4 aXN0aW5nIGZiZGV2Cj4gPiA+IGRyaXZlcnMgYW5kIGRvY3VtZW50YXRpb24gaW4gRG9jdW1lbnRh dGlvbi9mYi8uIEFuZCBpdCBsb29rcyBsaWtlIHRoZXJlCj4gPiA+IGFyZSBubyBzdHJpY3QgcnVs ZXMgb24gdGhhdCBhbmQgYWN0dWFsIGJlaGF2aW91ciB2YXJpZXM6Cj4gPiA+IAo+ID4gPiAJKiBz b21lIGRyaXZlcnMgdHJlYXQgKHBpeGNsb2NrID09IDApIGFzICJ1c2UgZGVmYXVsdHMiICh1dmVz YWZiLmMpOwo+ID4gPiAJKiBzb21lIHRyZWF0IChwaXhjbG9jayA9PSAwKSBhcyBpbnZhbGlkIHZh bHVlIHdoaWNoIGxlYWRzIHRvCj4gPiA+IAkgIC1FSU5WQUwgKGNscHM3MTF4LWZiLmMpOwo+ID4g PiAJKiBzb21lIHBhc3MgY29udmVydGVkIHBpeGNsb2NrIHZhbHVlIHRvIGhhcmR3YXJlICh1dmVz YWZiLmMpOwo+ID4gPiAJKiBzb21lIGFyZSB0cnlpbmcgdG8gZmluZCBuZWFyZXN0IHZhbHVlIGZy b20gcHJlZGVmaW5lZCB0YWJsZQo+ID4gPiAgICAgICAgICAgKHZnYTE2ZmIuYywgdmlkZW9fZ3gu YykuCj4gPiA+IAo+ID4gPiBHaXZlbiB0aGlzLCBJIGJlbGlldmUgdGhhdCBpdCBzaG91bGQgYmUg c2FmZSB0byBqdXN0IGlnbm9yZSB0aGlzIHZhbHVlIGlmCj4gPiA+IGNoYW5naW5nIGlzIG5vdCBz dXBwb3J0ZWQuIEl0IHNlZW1zIHRoYXQgYW55IHBvcnRhYmxlIGZiZGV2IGFwcGxpY2F0aW9uCj4g PiA+IHdoaWNoIHdhcyBub3Qgd3JpdHRlbiBvbmx5IGZvciBvbmUgc3BlY2lmaWMgZGV2aWNlIHdv cmtpbmcgdW5kZXIgb25lCj4gPiA+IHNwZWNpZmljIGtlcm5lbCB2ZXJzaW9uIHNob3VsZCBub3Qg cmVseSBvbiBhbnkgcGFydGljdWxhciBiZWhhdmlvdXIgb2YKPiA+ID4gcGl4Y2xvY2sgYW55d2F5 Lgo+ID4gPiAKPiA+ID4gSG93ZXZlciwgd2hpbGUgZW5hYmxpbmcgU0RMMSBhcHBsaWNhdGlvbnMg dG8gd29yayBvdXQgb2YgdGhlIGJveCB3aGVuCj4gPiA+IHRoZXJlIGlzIG5vIC9ldGMvZmIubW9k ZXMgd2l0aCB2YWxpZCBzZXR0aW5ncywgdGhpcyBjaGFuZ2UgYWZmZWN0cyB0aGUKPiA+ID4gdmlk ZW8gbW9kZSBjaG9vc2luZyBsb2dpYyBpbiBTREwuIERlcGVuZGluZyBvbiBjdXJyZW50IHNjcmVl bgo+ID4gPiByZXNvbHV0aW9uLCBjb250ZW50cyBvZiAvZXRjL2ZiLm1vZGVzIGFuZCByZXNvbHV0 aW9uIHJlcXVlc3RlZCBieQo+ID4gPiBhcHBsaWNhdGlvbiwgdGhpcyBtYXkgbGVhZCB0byB1c2Vy LXZpc2libGUgZGlmZmVyZW5jZSAobm90IGFsd2F5cyk6Cj4gPiA+IGltYWdlIHdpbGwgYmUgZGlz cGxheWVkIGluIGEgcmlnaHQgd2F5LCBidXQgaXQgd2lsbCBiZSBhbGlnbmVkIHRvIHRoZQo+ID4g PiBsZWZ0IGluc3RlYWQgb2YgY2VudGVyLiBUaGVyZSBpcyBubyAicmlnaHQgYmVoYXZpb3VyIiBo ZXJlIGFzIHdlbGwsIGFzCj4gPiA+IGVtdWxhdGVkIGZiZGV2LCBvcHBvc2luZyB0byBvbGQgZmJk ZXYgZHJpdmVycywgc2ltcGx5IGlnbm9yZXMgYW55Cj4gPiA+IHJlcXVzdHMgb2YgdmlkZW8gbW9k ZSBjaGFuZ2VzIHdpdGggcmVzb2x1dGlvbnMgc21hbGxlciB0aGFuIGN1cnJlbnQuCj4gPiA+IAo+ ID4gPiBGZWVsIGZyZWUgdG8gTkFLIHRoaXMgcGF0Y2ggaWYgeW91IHRoaW5rIHRoYXQgaXQgY2F1 c2VzIGJyZWFrYWdlIG9mCj4gPiA+IHVzZXItc3BhY2UgPSkuCj4gPiAKPiA+IEl0J3MgYSByZWdy ZXNzaW9uLCB3ZSBkb24ndCBuYWNrIHJlZ3Jlc3Npb24gZml4ZXMgOi0pCj4gPiAKPiA+ID4gVGhl IGVhc2llc3Qgd2F5IHRvIHJlcHJvZHVjZSB0aGlzIHByb2JsZW0gaXMgdG8gaW5zdGFsbCBzZGwt c29wd2l0aFsyXSwKPiA+ID4gcmVtb3ZlIC9ldGMvZmIubW9kZXMgZmlsZSBpZiBpdCBleGlzdHMs IGFuZCB0aGVuIHRyeSB0byBydW4gc29wd2l0aAo+ID4gPiBmcm9tIGNvbnNvbGUgd2l0aG91dCBY LiBBdCBsZWFzdCBpbiBGZWRvcmEgMjksIHNvcHdpdGggbWF5IGJlIHNpbXBseQo+ID4gPiBpbnN0 YWxsZWQgZnJvbSBzdGFuZGFyZCByZXBvc2l0b3JpZXMuCj4gPiA+IAo+ID4gPiBbMV0gU0RMIDEu Mi4xNSBzb3VyY2UgY29kZSwgc3JjL3ZpZGVvL2ZiY29uL1NETF9mYnZpZGVvLmMsIHZlc2FfdGlt aW5ncwo+ID4gPiBbMl0gaHR0cDovL3NkbC1zb3B3aXRoLnNvdXJjZWZvcmdlLm5ldC8KPiA+ID4g Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IEl2YW4gTWlyb25vdiA8bWlyb25vdi5pdmFuQGdtYWlsLmNv bT4KPiA+IAo+ID4gSSB0aG91Z2h0IHRoaXMgaXMgYWxzbyBhIHJlZ3Jlc3Npb24gZml4LCBzbyBh bHNvIG5lZWRzIEZpeGVzOiBhbmQgY2M6Cj4gPiBzdGFibGU/Cj4gPiAtRGFuaWVsCj4gCj4gVGhp cyBwYXJ0aWN1bGFyIHBhdGNoIGZpeGVzIGEgYnVnIHRoYXQgZXhpc3RlZCBmb3IgMTAgeWVhcnMg dW5ub3RpY2VkLgo+IEFyZSAiRml4ZXM6IiBhbmQgIkNjOiBzdGFibGUiIHJlYWxseSByZXF1aXJl ZD8KPiAKPiAicGl4Y2xvY2sgIT0gMCIgY2hlY2sgd2FzIGludHJvZHVjZWQgaW4gdGhpcyBmaWxl IGJ5IDc4NWI5M2VmOGMzMDkKPiAoImRybS9rbXM6IG1vdmUgZHJpdmVyIHNwZWNpZmljIGZiIGNv bW1vbiBjb2RlIHRvIGhlbHBlciBmdW5jdGlvbnMKPiAodjIpIikuIEJ1dCBhY3R1YWxseSBzaW1p bGFyIGNvZGUgZXhpc3RlZCBpbiB0aGUgZGV2aWNlLXNwZWNpZmljCj4gZHJpdmVycyBldmVuIGVh cmxpZXIuCgpBZmF1aSA3ODViOTNlZjhjMzA5IGJyb2tlIGV4aXN0aW5nIHVzZXJzcGFjZS4gQnJv a2VuIHVzZXJzcGFjZSwgYnV0CmV4aXN0aW5nIHVzZXJzcGFjZSwgYW5kIGhlbmNlIHdlIG5lZWQg dG8gZml4IHRoaXMgcmVncmVzc2lvbi4gVGhhdCdzIHRoZQpydWxlcyB3aXRoIGxpbnV4IHVwc3Ry ZWFtLCBleGlzdGluZyB1c2Vyc3BhY2UgaXMgbmV2ZXIgYWxsb3dlZCB0byBicmVhaywKZXZlbiBp ZiBpdCBkb2VzIHJlYWxseSBzdHVwaWQgdGhpbmdzLiBIZW5jZSBDYzogc3RhYmxlLgotRGFuaWVs Cgo+IAo+ID4gCj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIu YyB8IDcgKysrKysrLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f ZmJfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gPiA+IGluZGV4 IGFmZjU3NmMzYzRmYi4uYjk1YTBjMjNjN2M4IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJf aGVscGVyLmMKPiA+ID4gQEAgLTE2OTAsOSArMTY5MCwxNCBAQCBpbnQgZHJtX2ZiX2hlbHBlcl9j aGVja192YXIoc3RydWN0IGZiX3Zhcl9zY3JlZW5pbmZvICp2YXIsCj4gPiA+ICAJc3RydWN0IGRy bV9mYl9oZWxwZXIgKmZiX2hlbHBlciA9IGluZm8tPnBhcjsKPiA+ID4gIAlzdHJ1Y3QgZHJtX2Zy YW1lYnVmZmVyICpmYiA9IGZiX2hlbHBlci0+ZmI7Cj4gPiA+ICAKPiA+ID4gLQlpZiAodmFyLT5w aXhjbG9jayAhPSAwIHx8IGluX2RiZ19tYXN0ZXIoKSkKPiA+ID4gKwlpZiAoaW5fZGJnX21hc3Rl cigpKQo+ID4gPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiA+ID4gIAo+ID4gPiArCWlmICh2YXItPnBp eGNsb2NrICE9IDApIHsKPiA+ID4gKwkJRFJNX0RFQlVHKCJmYmRldiBlbXVsYXRpb24gZG9lc24n dCBzdXBwb3J0IGNoYW5naW5nIHRoZSBwaXhlbCBjbG9jaywgdmFsdWUgb2YgcGl4Y2xvY2sgaXMg aWdub3JlZFxuIik7Cj4gPiA+ICsJCXZhci0+cGl4Y2xvY2sgPSAwOwo+ID4gPiArCX0KPiA+ID4g Kwo+ID4gPiAgCWlmICgoZHJtX2Zvcm1hdF9pbmZvX2Jsb2NrX3dpZHRoKGZiLT5mb3JtYXQsIDAp ID4gMSkgfHwKPiA+ID4gIAkgICAgKGRybV9mb3JtYXRfaW5mb19ibG9ja19oZWlnaHQoZmItPmZv cm1hdCwgMCkgPiAxKSkKPiA+ID4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gPiA+IC0tIAo+ID4gPiAy LjIwLjEKPiA+ID4gCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50 ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==