From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 1/4] drm/vc4: Wait for display list synchronization when completing commit Date: Wed, 9 Jan 2019 21:34:00 +0100 Message-ID: <20190109203400.GU21184@phenom.ffwll.local> References: <20190108145056.2276-1-paul.kocialkowski@bootlin.com> <20190108145056.2276-2-paul.kocialkowski@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C17189A98 for ; Wed, 9 Jan 2019 20:34:05 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id y56so8376022edd.11 for ; Wed, 09 Jan 2019 12:34:05 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Paul Kocialkowski Cc: Maxime Ripard , Thomas Petazzoni , Eben Upton , David Airlie , Boris Brezillon , Linux Kernel Mailing List , dri-devel List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKYW4gMDksIDIwMTkgYXQgMDU6NTI6MjBQTSArMDEwMCwgUGF1bCBLb2NpYWxrb3dz a2kgd3JvdGU6Cj4gSGkgRGFuaWVsLAo+IAo+IE9uIFR1ZSwgMjAxOS0wMS0wOCBhdCAxOToyMSAr MDEwMCwgRGFuaWVsIFZldHRlciB3cm90ZToKPiA+IE9uIFR1ZSwgSmFuIDgsIDIwMTkgYXQgMzo1 MSBQTSBQYXVsIEtvY2lhbGtvd3NraQo+ID4gPHBhdWwua29jaWFsa293c2tpQGJvb3RsaW4uY29t PiB3cm90ZToKPiA+ID4gRHVyaW5nIGFuIGF0b21pYyBjb21taXQsIHRoZSBIVlMgaXMgY29uZmln dXJlZCB3aXRoIGEgZGlzcGxheSBsaXN0Cj4gPiA+IGZvciB0aGUgY2hhbm5lbCBtYXRjaGluZyB0 aGUgYXNzb2NpYXRlZCBDUlRDLiBUaGUgUGl4ZWwgVmFsdmUgKENSVEMpCj4gPiA+IGFuZCBlbmNv ZGVyIGFyZSBhbHNvIGNvbmZpZ3VyZWQgZm9yIHRoZSBuZXcgc2V0dXAgYXQgdGhhdCB0aW1lLgo+ ID4gPiBXaGlsZSB0aGUgUGl4ZWwgVmFsdmUgYW5kIGVuY29kZXIgYXJlIHJlY29uZmlndXJlZCBz eW5jaHJvbm91c2x5LCB0aGUKPiA+ID4gSFZTIGlzIG9ubHkgcmVjb25maWd1cmVkIGFmdGVyIHRo ZSBkaXNwbGF5IGxpc3QgYWRkcmVzcyAoRElTUExJU1QpIGhhcwo+ID4gPiBiZWVuIHVwZGF0ZWQg dG8gdGhlIGN1cnJlbnQgZGlzcGxheSBsaXN0IGFkZHJlc3MgKERJU1BMQUNUWCksIHdoaWNoIGlz Cj4gPiA+IHRoZSByZXNwb25zaWJpbGl0eSBvZiB0aGUgaGFyZHdhcmUuCj4gPiA+IAo+ID4gPiBU aGUgdGltZSBmcmFtZSBkdXJpbmcgd2hpY2ggdGhlIEhWUyBpcyBzdGlsbCBydW5uaW5nIG9uIGl0 cyBwcmV2aW91cwo+ID4gPiBjb25maWd1cmF0aW9uIGJ1dCB0aGUgQ1JUQyBhbmQgZW5jb2RlciBo YXZlIGJlZW4gcmVjb25maWd1cmVkIGFscmVhZHkKPiA+ID4gY2FuIGxlYWQgdG8gYSBudW1iZXIg b2Ygc3luY2hyb25pemF0aW9uIGlzc3Vlcy4gVGhleSB3aWxsIGV2ZW50dWFsbHkKPiA+ID4gY2F1 c2UgZXJyb3JzIHJlcG9ydGVkIG9uIHRoZSBGSUZPcywgc3VjaCBhcyB1bmRlcnJ1bnMuCj4gPiA+ IAo+ID4gPiBXaXRoIHVuZGVycnVuIGRldGVjdGlvbiBlbmFibGVkIChmcm9tIEJvcmlzIEJyZXpp bGxvbidzIHNlcmllcyksIHRoaXMKPiA+ID4gbGVhZHMgdG8gdW5yZWxpYWJsZSB1bmRlcnJ1biBk ZXRlY3Rpb24gd2l0aCByYW5kb20gZmFsc2UgcG9zaXRpdmVzLgo+ID4gPiAKPiA+ID4gVG8gZW5z dXJlIGEgY29oZXJlbnQgc3RhdGUsIHdhaXQgZm9yIGVhY2ggZW5hYmxlZCBjaGFubmVsIG9mIHRo ZSBIVlMKPiA+ID4gdG8gc3luY2hyb25pemUgaXRzIGN1cnJlbnQgZGlzcGxheSBsaXN0IGFkZHJl c3MuIFRoaXMgZml4ZXMgdGhlIGlzc3VlCj4gPiA+IG9mIHJhbmRvbSB1bmRlcnJ1biByZXBvcnRp bmcgb24gY29tbWl0cy4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IFBhdWwgS29jaWFsa293 c2tpIDxwYXVsLmtvY2lhbGtvd3NraUBib290bGluLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2 ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kcnYuaCAgfCAgMSArCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0v dmM0L3ZjNF9odnMuYyAgfCAxNyArKysrKysrKysrKysrKysrKwo+ID4gPiAgZHJpdmVycy9ncHUv ZHJtL3ZjNC92YzRfa21zLmMgIHwgIDIgKysKPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS92YzQvdmM0 X3JlZ3MuaCB8ICAyICsrCj4gPiA+ICA0IGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKykK PiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kcnYuaCBi L2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2Rydi5oCj4gPiA+IGluZGV4IGMyNGIwNzhmMDU5My4u OTU1ZjE1N2Y1YWQwIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9k cnYuaAo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kcnYuaAo+ID4gPiBAQCAt NzcyLDYgKzc3Miw3IEBAIHZvaWQgdmM0X2lycV9yZXNldChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 KTsKPiA+ID4gIGV4dGVybiBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIHZjNF9odnNfZHJpdmVyOwo+ ID4gPiAgdm9pZCB2YzRfaHZzX2R1bXBfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4g PiA+ICBpbnQgdmM0X2h2c19kZWJ1Z2ZzX3JlZ3Moc3RydWN0IHNlcV9maWxlICptLCB2b2lkICp1 bnVzZWQpOwo+ID4gPiArdm9pZCB2YzRfaHZzX3N5bmNfZGxpc3Qoc3RydWN0IGRybV9kZXZpY2Ug KmRldik7Cj4gPiA+IAo+ID4gPiAgLyogdmM0X2ttcy5jICovCj4gPiA+ICBpbnQgdmM0X2ttc19s b2FkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL3ZjNC92YzRfaHZzLmMgYi9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9odnMuYwo+ID4g PiBpbmRleCA1ZDhjNzQ5Yzk3NDkuLjFiYTYwYjhlMGMyZCAxMDA2NDQKPiA+ID4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL3ZjNC92YzRfaHZzLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3Zj NC92YzRfaHZzLmMKPiA+ID4gQEAgLTE2Niw2ICsxNjYsMjMgQEAgc3RhdGljIGludCB2YzRfaHZz X3VwbG9hZF9saW5lYXJfa2VybmVsKHN0cnVjdCB2YzRfaHZzICpodnMsCj4gPiA+ICAgICAgICAg cmV0dXJuIDA7Cj4gPiA+ICB9Cj4gPiA+IAo+ID4gPiArdm9pZCB2YzRfaHZzX3N5bmNfZGxpc3Qo c3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ID4gK3sKPiA+ID4gKyAgICAgICBzdHJ1Y3QgdmM0 X2RldiAqdmM0ID0gdG9fdmM0X2RldihkZXYpOwo+ID4gPiArICAgICAgIHVuc2lnbmVkIGludCBp Owo+ID4gPiArICAgICAgIGludCByZXQ7Cj4gPiA+ICsKPiA+ID4gKyAgICAgICBmb3IgKGkgPSAw OyBpIDwgU0NBTEVSX0NIQU5ORUxTX0NPVU5UOyBpKyspIHsKPiA+ID4gKyAgICAgICAgICAgICAg IGlmICghKEhWU19SRUFEKFNDQUxFUl9ESVNQQ1RSTFgoaSkpICYgU0NBTEVSX0RJU1BDVFJMWF9F TkFCTEUpKQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKPiA+ID4gKwo+ ID4gPiArICAgICAgICAgICAgICAgcmV0ID0gd2FpdF9mb3IoSFZTX1JFQUQoU0NBTEVSX0RJU1BM QUNUWChpKSkgPT0KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEhWU19SRUFE KFNDQUxFUl9ESVNQTElTVFgoaSkpLCAxMDAwKTsKPiA+ID4gKyAgICAgICAgICAgICAgIFdBUk4o cmV0LCAiVGltZW91dCB3YWl0aW5nIGZvciBjaGFubmVsICVkIGRpc3BsYXkgbGlzdCBzeW5jXG4i LAo+ID4gPiArICAgICAgICAgICAgICAgICAgICBpKTsKPiA+ID4gKyAgICAgICB9Cj4gPiA+ICt9 Cj4gPiA+ICsKPiA+ID4gIHN0YXRpYyBpbnQgdmM0X2h2c19iaW5kKHN0cnVjdCBkZXZpY2UgKmRl diwgc3RydWN0IGRldmljZSAqbWFzdGVyLCB2b2lkICpkYXRhKQo+ID4gPiAgewo+ID4gPiAgICAg ICAgIHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYgPSB0b19wbGF0Zm9ybV9kZXZpY2UoZGV2 KTsKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2ttcy5jIGIvZHJp dmVycy9ncHUvZHJtL3ZjNC92YzRfa21zLmMKPiA+ID4gaW5kZXggMDQ5MGVkYjE5MmExLi4yZDY2 YTJiNTdhOTEgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2ttcy5j Cj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2ttcy5jCj4gPiA+IEBAIC0xNTUs NiArMTU1LDggQEAgdmM0X2F0b21pY19jb21wbGV0ZV9jb21taXQoc3RydWN0IGRybV9hdG9taWNf c3RhdGUgKnN0YXRlKQo+ID4gPiAKPiA+ID4gICAgICAgICBkcm1fYXRvbWljX2hlbHBlcl9jb21t aXRfaHdfZG9uZShzdGF0ZSk7Cj4gPiA+IAo+ID4gPiArICAgICAgIHZjNF9odnNfc3luY19kbGlz dChkZXYpOwo+ID4gCj4gPiBGcm9tIHlvdXIgZGVzY3JpcHRpb24gSSdkIGhhdmUgZ3Vlc3NlZCB5 b3Ugd2FudCB0aGlzIGJldHdlZW4gd2hlbiB5b3UKPiA+IHVwZGF0ZSB0aGUgcGxhbmVzIGFuZCB0 aGUgY3J0Yywgc28gc29tZXdoZXJlIGJldHdlZW4gY29tbWl0X3BsYW5lcygpCj4gPiBhbmQgY29t bWl0X21vZGVzZXRfZW5hYmxlcygpLiBBdCBsZWFzdCBJIGhhdmUgbm8gaWRlYSBob3cgd2FpdGlu ZyBoZXJlCj4gPiBjYW4gcHJldmVudCB1bmRlcnJ1bnMsIGJ5IHRoaXMgcG9pbnQgdGhlcmUncyBu byBmdXJ0aGVyIGh3IHByb2dyYW1taW5nCj4gPiBoYXBwZW5pbmcuCj4gCj4gT25lIHRoaW5nIHRo YXQgSSBkaWQgbm90IG1lbnRpb24gaXMgdGhhdCB0aGUgZGlzcGxheSBsaXN0ICh0aGF0Cj4gY29u ZmlndXJlcyB0aGUgcGxhbmVzKSBpcyBvbmx5IHNldCBhdCBjcnRjX2VuYWJsZSB0aW1lIChhbmQg dGFrZW4gaW50bwo+IGFjY291bnQgYnkgdGhlIGhhcmR3YXJlIGxhdGVyKS4KPiAKPiBIb3dldmVy LCBldmVuIGNhbGxpbmcgdmM0X2h2c19zeW5jX2RsaXN0IHJpZ2h0IGF0IHRoZSBlbmQgb2YKPiBj cnRjX2VuYWJsZSBkb2Vzbid0IGRvIGVpdGhlciAodGhlIG9sZCBkaXNwbGF5IGxpc3QganVzdCBz dGlja3MpLiBJdAo+IG9ubHkgc2VlbXMgdG8gd29yayBhZnRlciB0aGUgSERNSSBlbmNvZGVyIGVu YWJsZSBzdGVwIGFuZCBJIGRvbid0IGtub3cKPiBhbnkgZ29vZCByZWFzb24gd2h5Lgo+IAo+IEkg ZGlkbid0IGZpbmQgYW55IGRlc2NyaXB0aW9uIG9mIHdoZW4gdGhhdCBkbGlzdCBzeW5jIG1lY2hh bmlzbSBpcwo+IHN1cHBvc2VkIHRvIHRha2UgcGxhY2UgYW5kIHdoYXQgcGFydGljdWxhciBldmVu dCB0cmlnZ2VycyBpdC4gUGVyaGFwcwo+IGl0IGlzIHRyaWdnZXJlZCBieSBhIHNpZ25hbCBvcmln aW5hdGluZyBmcm9tIHRoZSBlbmNvZGVyPyBJZiBhbnlvbmUgaGFzCj4gaW5zaWdodCBvbiB0aGUg aGFyZHdhcmUsIGZlZWwgZnJlZSB0byBzaGVkIHNvbWUgbGlnaHQgaGVyZSA6KQoKTWF5YmUgbXkg Y29uY2VybiB3YXNuJ3QgY2xlYXI6IEkgaGF2ZSBubyBpZGVhIHdoeSB5b3UgbmVlZCB0aGlzIGV4 YWN0bHkKYW5kIGhvdyB5b3VyIGh3IHdvcmtzLiBPbmx5IHRoaW5nIEkgbWVhbnQgdG8gaGlnaGxp Z2h0IGlzIHRoYXQgc2luY2UgYWxsCnlvdSdyZSBkb2luZyBpcyB3YWl0IGEgYml0LCB0aGVuIHRo ZSBvbmx5IHJlYXNvbiBJIGNhbiBjb21lIHVwIHdpdGggd2h5CnRoYXQgd2FpdCBkb2VzIGFueXRo aW5nIGlzIGNsZWFudXBfcGxhbmVzKCkgbGF0ZXIgb24uIEFuZCBpZiB0aGF0J3MgdGhlCmNhc2Us IHRoZW4geW91IGFsc28gbmVlZCB0byBzdWZmaWNpZW50bHkgZGVsYXkgdGhlIGZsaXBfZG9uZSBz aWduYWxsaW5nIHRvCnVzZXJzcGFjZSAoaS5lLiBzZW5kaW5nIG91dCB0aGUgY3J0Y19zdGF0ZS0+ ZXZlbnQgdmJsYW5rIGV2ZW50KS4KCkJ1dCBJJ20gcmVhbGx5IG5vdCB1bmRlcnN0YW5kaW5nIHdo YXQgdGhlIGh3IGRvZXMgYW5kIGhvdyB5b3VyIHBhdGNoIGhlcmUKaGVscHMgYXQgYWxsLiBJdCBq dXN0IGxvb2tlZCByZWFsbHkgc3RyYW5nZSBmcm9tIGEgYXRvbWljIGttcyBwb3YuCi1EYW5pZWwK Cj4gCj4gQ2hlZXJzIGFuZCB0aGFua3MgZm9yIHRoZSByZXZpZXcsCj4gCj4gUGF1bAo+IAo+ID4g T25seSBleGNlcHRpb24gaXMgaWYgeW91IGhhdmUgYW4gSU9NTVUgd2hpY2ggY2FuIGZhdWx0LCBp bgo+ID4gd2hpY2ggY2FzZSB0aGUgY2xlYW51cF9wbGFuZXMgbWlnaHQgcmVtb3ZlIHRoZSBidWZm ZXJzIHByZW1hdHVyZWx5Lgo+ID4gQnV0IGlmIHRoYXQncyB0aGUgcHJvYmxlbSwgdGhlbiB5b3Vy IHNlbWFudGljcyBvZiB0aGUgZmxpcF9kb25lIGV2ZW50Cj4gPiBhcmUgd3JvbmcgLSB3aGVuIGZs aXBfZG9uZSBpcyBzaWduYWxsZWQsIHRoZSBodyBtdXN0IGhhdmUgc3RvcHBlZAo+ID4gc2Nhbm5p bmcgb3V0IHRoZSBvbGQgcGxhbmVzLCBzaW5jZSB1c2Vyc3BhY2UgZXhwZWN0cyB0byBiZSBhYmxl IHRvCj4gPiBzdGFydCBvdmVyd3JpdGluZy9yZXVzaW5nIHRoZW0uCj4gPiAtRGFuaWVsCj4gPiAK PiA+ID4gKwo+ID4gPiAgICAgICAgIGRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2ZsaXBfZG9u ZShkZXYsIHN0YXRlKTsKPiA+ID4gCj4gPiA+ICAgICAgICAgZHJtX2F0b21pY19oZWxwZXJfY2xl YW51cF9wbGFuZXMoZGV2LCBzdGF0ZSk7Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vdmM0L3ZjNF9yZWdzLmggYi9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9yZWdzLmgKPiA+ID4g aW5kZXggOTMxMDg4MDE0MjcyLi41MGM2NTMzMDlhZWMgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS92YzQvdmM0X3JlZ3MuaAo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdmM0 L3ZjNF9yZWdzLmgKPiA+ID4gQEAgLTIxMiw2ICsyMTIsOCBAQAo+ID4gPiAKPiA+ID4gICNkZWZp bmUgUFZfSEFDVF9BQ1QgICAgICAgICAgICAgICAgICAgICAgICAgICAgMHgzMAo+ID4gPiAKPiA+ ID4gKyNkZWZpbmUgU0NBTEVSX0NIQU5ORUxTX0NPVU5UICAgICAgICAgICAgICAgICAgMwo+ID4g PiArCj4gPiA+ICAjZGVmaW5lIFNDQUxFUl9ESVNQQ1RSTCAgICAgICAgICAgICAgICAgICAgICAg ICAweDAwMDAwMDAwCj4gPiA+ICAvKiBHbG9iYWwgcmVnaXN0ZXIgZm9yIGNsb2NrIGdhdGluZyB0 aGUgSFZTICovCj4gPiA+ICAjIGRlZmluZSBTQ0FMRVJfRElTUENUUkxfRU5BQkxFICAgICAgICAg ICAgICAgICAgICAgICAgQklUKDMxKQo+ID4gPiAtLQo+ID4gPiAyLjIwLjEKPiA+ID4gCj4gPiAK PiA+IAo+IC0tIAo+IFBhdWwgS29jaWFsa293c2tpLCBCb290bGluCj4gRW1iZWRkZWQgTGludXgg YW5kIGtlcm5lbCBlbmdpbmVlcmluZwo+IGh0dHBzOi8vYm9vdGxpbi5jb20KPiAKCi0tIApEYW5p ZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxv Zy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK