From: Sam Ravnborg <sam@ravnborg.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v6] drm/panel: Add a driver for the TPO TPG110
Date: Thu, 10 Jan 2019 09:40:20 +0100 [thread overview]
Message-ID: <20190110084020.GA29446@ravnborg.org> (raw)
In-Reply-To: <20190110081104.GB5213@ulmo>
Hi Thierry.
> > + case TPG110_RES_480X272:
> > + dev_info(tpg->dev, "480x272 RGB");
> > + break;
> > + case TPG110_RES_640X480:
> > + dev_info(tpg->dev, "640x480 RGB");
> > + break;
> > + case TPG110_RES_800X480:
> > + dev_info(tpg->dev, "800x480 RGB");
> > + break;
> > + default:
> > + dev_info(tpg->dev, "ILLEGAL RESOLUTION");
>
> dev_err()? Also, perhaps make this some proper error message and include
> the invalid value?
>
> Also I just noticed that the above informational messages all lack a \n
> at the end.
The "\n" is optional these days.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-01-10 8:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 13:53 [PATCH v6] drm/panel: Add a driver for the TPO TPG110 Linus Walleij
2019-01-09 18:58 ` Sam Ravnborg
2019-01-10 8:11 ` Thierry Reding
2019-01-10 8:40 ` Sam Ravnborg [this message]
2019-01-10 20:01 ` Jagan Teki
2019-01-11 19:53 ` Linus Walleij
2019-01-11 21:53 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110084020.GA29446@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox