dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Liviu Dudau <liviu@dudau.co.uk>
To: Uma Shankar <uma.shankar@intel.com>
Cc: intel-gfx@lists.freedesktop.org, ville.syrjala@intel.com,
	maarten.lankhorst@intel.com, dri-devel@lists.freedesktop.org
Subject: Re: [v4 05/12] drm: Add HDR capability field to plane structure
Date: Thu, 10 Jan 2019 10:47:21 +0000	[thread overview]
Message-ID: <20190110104720.GK20342@bart.dudau.co.uk> (raw)
In-Reply-To: <1546938687-27306-6-git-send-email-uma.shankar@intel.com>

Hi Uma,

On Tue, Jan 08, 2019 at 02:41:20PM +0530, Uma Shankar wrote:
> Hardware may have HDR capability on certain plane
> engines. Enabling the same in drm plane structure
> so that this can be communicated to user space.
> 
> Each drm driver should set this flag to true for planes
> which support HDR.
> 
> v2: Rebase
> 
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> ---
>  include/drm/drm_plane.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
> index 6078c70..206eefc 100644
> --- a/include/drm/drm_plane.h
> +++ b/include/drm/drm_plane.h
> @@ -638,6 +638,9 @@ struct drm_plane {
>  	/** @type: Type of plane, see &enum drm_plane_type for details. */
>  	enum drm_plane_type type;
>  
> +	/* Value of true:1 means HDR is supported */
> +	bool hdr_supported;
> +

I don't see where this is used, am I missing something? You attach the property
to the connector, I don't see how the planes get involved in the end.

Best regards,
Liviu


>  	/**
>  	 * @index: Position inside the mode_config.list, can be used as an array
>  	 * index. It is invariant over the lifetime of the plane.
> -- 
> 1.9.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
           ________________________________________________________
  ________|                                                        |_______
  \       |  With enough courage, you can do without a reputation  |      /
   \      |                                  -- Rhett Butler       |     /
   /      |________________________________________________________|     \
  /__________)                                                  (_________\
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-01-10 10:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08  9:11 [v4 00/12] Add HDR Metadata Parsing and handling in DRM layer Uma Shankar
2019-01-08  9:11 ` [v4 01/12] drm: Add HDR source metadata property Uma Shankar
2019-01-09  0:51   ` [Intel-gfx] " kbuild test robot
2019-01-10 11:03   ` Liviu Dudau
2019-01-08  9:11 ` [v4 02/12] drm: Parse HDR metadata info from EDID Uma Shankar
2019-01-08  9:11 ` [v4 03/12] drm: Parse Colorimetry data block " Uma Shankar
2019-01-09  2:57   ` [Intel-gfx] " kbuild test robot
2019-01-08  9:11 ` [v4 04/12] drm/i915: Attach HDR metadata property to connector Uma Shankar
2019-01-08  9:11 ` [v4 05/12] drm: Add HDR capability field to plane structure Uma Shankar
2019-01-09  5:09   ` kbuild test robot
2019-01-10 10:47   ` Liviu Dudau [this message]
2019-01-10 11:45     ` Shankar, Uma
2019-01-08  9:11 ` [v4 06/12] drm: Implement HDR output metadata set and get property handling Uma Shankar
2019-01-08  9:11 ` [v4 07/12] drm: Enable HDR infoframe support Uma Shankar
2019-01-09  2:19   ` kbuild test robot
2019-01-09  7:19   ` kbuild test robot
2019-01-08  9:11 ` [v4 08/12] drm/i915: Write HDR infoframe and send to panel Uma Shankar
2019-01-08  9:11 ` [v4 09/12] drm/i915: [DO NOT MERGE] hack for glk board outputs Uma Shankar
2019-01-08  9:11 ` [v4 10/12] drm/i915: Add HLG EOTF Uma Shankar
2019-01-08 19:45   ` Matt Roper
2019-01-09 12:08     ` Shankar, Uma
2019-01-08  9:11 ` [v4 11/12] drm/i915: Enable infoframes on GLK+ for HDR Uma Shankar
2019-01-08  9:11 ` [v4 12/12] drm/i915:Enabled Modeset when HDR Infoframe changes Uma Shankar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190110104720.GK20342@bart.dudau.co.uk \
    --to=liviu@dudau.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@intel.com \
    --cc=uma.shankar@intel.com \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox