From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 2/4] drm/atmel-hlcdc: do not swap w/h of the crtc when a plane is rotated Date: Thu, 10 Jan 2019 18:48:25 +0100 Message-ID: <20190110184816.63350396@bbrezillon> References: <20190110151020.30468-1-peda@axentia.se> <20190110151020.30468-3-peda@axentia.se> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190110151020.30468-3-peda@axentia.se> Sender: linux-kernel-owner@vger.kernel.org To: Peter Rosin Cc: "linux-kernel@vger.kernel.org" , Alexandre Belloni , David Airlie , "dri-devel@lists.freedesktop.org" , Boris Brezillon , "linux-arm-kernel@lists.infradead.org" List-Id: dri-devel@lists.freedesktop.org On Thu, 10 Jan 2019 15:10:39 +0000 Peter Rosin wrote: > The destination crtc rectangle is independent of source plane rotation. > > Signed-off-by: Peter Rosin > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > index ea8fc0deb814..d6f93f029020 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > @@ -642,9 +642,6 @@ static int atmel_hlcdc_plane_atomic_check(struct drm_plane *p, > * Swap width and size in case of 90 or 270 degrees rotation > */ > if (drm_rotation_90_or_270(state->base.rotation)) { > - tmp = state->crtc_w; > - state->crtc_w = state->crtc_h; > - state->crtc_h = tmp; Again, I guess I assumed ->crtc_h/w were the width and height before rotation when I initially added rotation support. This change might break users too. > tmp = state->src_w; > state->src_w = state->src_h; > state->src_h = tmp;