From: Daniel Vetter <daniel@ffwll.ch>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
"Michel Dänzer" <michel@daenzer.net>
Subject: Re: [PATCH v2 0/6] drm: byteorder fixes
Date: Fri, 11 Jan 2019 11:26:04 +0100 [thread overview]
Message-ID: <20190111102604.GV21184@phenom.ffwll.local> (raw)
In-Reply-To: <20190111094342.ppyenhpunbwd22vl@sirius.home.kraxel.org>
On Fri, Jan 11, 2019 at 10:43:42AM +0100, Gerd Hoffmann wrote:
> On Fri, Jan 11, 2019 at 10:11:09AM +0100, Daniel Vetter wrote:
> > On Fri, Jan 11, 2019 at 10:08 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
> > >
> > > On Fri, Jan 11, 2019 at 01:17:47AM -0500, Ilia Mirkin wrote:
> > > > Hi Gerd,
> > > >
> > > > What happened with this series (and the next one)?
> > >
> > > Landed upstream in 4.20.
> > >
> > > > Semi-relatedly, I wonder if it wouldn't be better to just dump the
> > > > BIG_ENDIAN flag and just define the "host" format to be the right one
> > > > for a consistent little-endian interpretation.
> > >
> > > Not fully sure what you mean here.
> > >
> > > The big endian flag is needed to specify RGB565 or XRGB1555 format in
> > > big endian byte order. For 32 bit depth we don't need it because
> > > XRGB8888 big endian == BGRX8888 little endian (see also
> > > include/drm/drm_fourcc.h).
> >
> > Yeah we'd need to add a few more fourcc codes for the missing
> > big-endian versions.
>
> If we do that then yes we can drop the BIG_ENDIAN flag.
>
> Not sure what the userspace API implications are,
> ADDFB2 ioctl comes to mind.
>
> > Aside from that I like Ilia's idea of removing
> > the BIG_ENDIAN flag, it causes lots of aliasing among formats, doesn't
> > change anything with others, and we probably have a huge mess already
> > ...
>
> Shouldn't be too messy. The place where the DRM_FORMAT_HOST_* formats
> are defined (include/drm/drm_fourcc.h) is almost the only place where
> DRM_FORMAT_BIG_ENDIAN is used, and for the DRM_FORMAT_HOST_* users the
> switch should be transparent.
Yeah we'd need to review current userspace, but I suspect the overlap of
"uses addfb2" and "runs on BE platform" is 0.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-01-11 10:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 6:04 [PATCH v2 0/6] drm: byteorder fixes Gerd Hoffmann
2018-09-05 6:04 ` [PATCH v2 1/6] drm: replace DRIVER_PREFER_XBGR_30BPP driver flag with mode_config quirk Gerd Hoffmann
2018-09-05 6:04 ` [PATCH v2 2/6] drm: byteorder: add DRM_FORMAT_HOST_* Gerd Hoffmann
2018-09-05 6:04 ` [PATCH v2 3/6] drm: do not mask out DRM_FORMAT_BIG_ENDIAN Gerd Hoffmann
2018-09-05 6:04 ` [PATCH v2 4/6] drm: fix drm_mode_addfb() on big endian machines Gerd Hoffmann
2018-09-05 18:19 ` Daniel Vetter
2018-09-06 7:18 ` Gerd Hoffmann
2018-09-05 6:04 ` [PATCH v2 5/6] drm/bochs: fix DRM_FORMAT_* handling for " Gerd Hoffmann
2018-09-05 6:04 ` [PATCH v2 6/6] drm/virtio: fix DRM_FORMAT_* handling Gerd Hoffmann
2019-01-11 6:17 ` [PATCH v2 0/6] drm: byteorder fixes Ilia Mirkin
2019-01-11 9:08 ` Gerd Hoffmann
2019-01-11 9:11 ` Daniel Vetter
2019-01-11 9:43 ` Gerd Hoffmann
2019-01-11 10:26 ` Daniel Vetter [this message]
2019-01-11 13:08 ` Ilia Mirkin
2019-01-11 13:53 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111102604.GV21184@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox