dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Russell King <linux@armlinux.org.uk>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 6/7] drm/tda998x: Don't set dpms hook
Date: Fri, 11 Jan 2019 22:55:42 +0100	[thread overview]
Message-ID: <20190111215542.GE21184@phenom.ffwll.local> (raw)
In-Reply-To: <cb611d0b-7869-3d7c-57f5-adbbbc140800@tronnes.org>

On Fri, Jan 11, 2019 at 04:41:21PM +0100, Noralf Trønnes wrote:
> Den 17.12.2018 20.43, skrev Daniel Vetter:
> > Doesn't do anything for atomic drivers.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Russell King <linux@armlinux.org.uk>
> > ---
> >  drivers/gpu/drm/i2c/tda998x_drv.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
> > index a7c39f39793f..f8a1d70a31c7 100644
> > --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> > +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> > @@ -1122,7 +1122,6 @@ static void tda998x_connector_destroy(struct drm_connector *connector)
> >  }
> >  
> >  static const struct drm_connector_funcs tda998x_connector_funcs = {
> > -	.dpms = drm_helper_connector_dpms,
> >  	.reset = drm_atomic_helper_connector_reset,
> >  	.fill_modes = drm_helper_probe_single_connector_modes,
> >  	.detect = tda998x_connector_detect,
> > 
> 
> Acked-by: Noralf Trønnes <noralf@tronnes.org>

Thanks for taking a look. The next patch unfortunately needs a lot more
work, and quite some coordination with other trees, due to all the
in-flight drmP.h cleanups. I think I'll wait a bit before resending that
one again.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-01-11 21:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 19:42 [PATCH 1/7] drm/ch7006: Stop using drm_crtc_force_disable Daniel Vetter
2018-12-17 19:42 ` [PATCH 2/7] drm/nouveau: " Daniel Vetter
2018-12-17 19:42 ` [PATCH 3/7] drm: Unexport drm_crtc_force_disable Daniel Vetter
     [not found] ` <20181217194303.14397-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-12-17 19:43   ` [PATCH 4/7] drm: Move the legacy kms disable_all helper to crtc helpers Daniel Vetter
2018-12-17 19:43   ` [PATCH 7/7] drm: Split out drm_probe_helper.h Daniel Vetter
     [not found]     ` <20181217194303.14397-7-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-12-17 20:47       ` [Intel-gfx] " Rodrigo Vivi
2018-12-18  9:27         ` Benjamin Gaignard
     [not found]           ` <CA+M3ks7+gd6zSsoQ1861nEYddObwPXU9RmD_KGP=Si2KyV6LhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-01-11 14:56             ` Daniel Vetter
2018-12-17 19:43 ` [PATCH 5/7] drm/arc: Don't set the dpms hook Daniel Vetter
2019-01-11 15:41   ` Noralf Trønnes
2018-12-17 19:43 ` [PATCH 6/7] drm/tda998x: Don't set " Daniel Vetter
2019-01-11 15:41   ` Noralf Trønnes
2019-01-11 21:55     ` Daniel Vetter [this message]
2019-01-11 22:22       ` Russell King - ARM Linux
2019-01-12 12:03         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190111215542.GE21184@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux@armlinux.org.uk \
    --cc=noralf@tronnes.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox