From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH V7 2/2] drm/panel: Add Sitronix ST7701 panel driver Date: Sat, 12 Jan 2019 11:14:09 +0100 Message-ID: <20190112101409.GA14273@ravnborg.org> References: <20190111124714.19566-1-jagan@amarulasolutions.com> <20190111124714.19566-2-jagan@amarulasolutions.com> <20190111211931.GA29735@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id A46016E2F8 for ; Sat, 12 Jan 2019 10:14:13 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jagan Teki Cc: David Airlie , Sean Paul , linux-kernel , dri-devel , Thierry Reding , Michael Trimarchi , linux-amarula@amarulasolutions.com List-Id: dri-devel@lists.freedesktop.org SGkgSmFnYW4uCgo+IE9uIFNhdCwgSmFuIDEyLCAyMDE5IGF0IDI6NDkgQU0gU2FtIFJhdm5ib3Jn IDxzYW1AcmF2bmJvcmcub3JnPiB3cm90ZToKPiA+Cj4gPiBIaSBKYWdhbi4KPiA+Cj4gPiBHYXZl IHRoaXMgYW5vdGhlciBtb3JlIGRldGFpbGVkIHJlYWQgLSB0cmlnZ2VyZWQgc29tZSBhZGRpdGlv bmFsIGNvbW1lbnRzLgo+ID4gRGVwaXRlIHRoZSBjb21tZW50cyBpdCBsb29rcyBnb29kLCBhbmQg dGhpcyBpcyBhbGwgbW9yZSBvcgo+ID4gbGVzcyBjb3NtZXRpYyBpbXByb3ZlbWVudHMuCj4gCj4g VGhhbmtzIGZvciB0aGUgcmV2aWV3Lgo+IAo+ID4KPiA+ICAgICAgICAgU2FtCj4gPgo+ID4gPiAr c3RydWN0IHN0NzcwMV9wYW5lbF9kZXNjIHsKPiA+ID4gKyAgICAgY29uc3Qgc3RydWN0IGRybV9k aXNwbGF5X21vZGUgKm1vZGU7Cj4gPiA+ICsgICAgIHVuc2lnbmVkIGludCBsYW5lczsKPiA+ID4g KyAgICAgdW5zaWduZWQgbG9uZyBmbGFnczsKPiA+ID4gKyAgICAgZW51bSBtaXBpX2RzaV9waXhl bF9mb3JtYXQgZm9ybWF0Owo+ID4gPiArICAgICBjb25zdCBjaGFyICpjb25zdCAqc3VwcGx5X25h bWVzOwo+ID4gPiArICAgICB1bnNpZ25lZCBpbnQgbnVtX3N1cHBsaWVzOwo+ID4gPiArICAgICB1 bnNpZ25lZCBpbnQgcGFuZWxfc2xlZXBfZGVsYXk7Cj4gPiA+ICt9Owo+ID4gPiArCj4gPiA+ICtz dHJ1Y3Qgc3Q3NzAxIHsKPiA+ID4gKyAgICAgc3RydWN0IGRybV9wYW5lbCBwYW5lbDsKPiA+ID4g KyAgICAgc3RydWN0IG1pcGlfZHNpX2RldmljZSAqZHNpOwo+ID4gPiArICAgICBjb25zdCBzdHJ1 Y3Qgc3Q3NzAxX3BhbmVsX2Rlc2MgKmRlc2M7Cj4gPiA+ICsKPiA+ID4gKyAgICAgc3RydWN0IGJh Y2tsaWdodF9kZXZpY2UgKmJhY2tsaWdodDsKPiA+ID4gKyAgICAgc3RydWN0IHJlZ3VsYXRvcl9i dWxrX2RhdGEgKnN1cHBsaWVzOwo+ID4gPiArICAgICB1bnNpZ25lZCBpbnQgbnVtX3N1cHBsaWVz Owo+ID4gSSBjYW5ub3Qgc2VlIHRoYXQgbnVtX3N1cHBsaWVzIGluIHRoaXMgc3RydWN0IGFyZSB1 c2VkPwo+IAo+IFllcyBpdCBpcyB1c2VkIGluIHRoZSBjb2RlLCBwbGVhc2UgY2hlY2sgaW4gc3Ry dWN0IHN0NzcwMV9wYW5lbF9kZXNjLgpJIGhhdmUgYXBwbGllZCB0aGUgcGF0Y2ggYW5kIGRlbGV0 ZWQgbnVtX3N1cHBsaWVzIC0gbm93IGJ1aWxkIGVycm9ycy4KU28gbnVtX3N1cHBsaWVzIGluIHN0 cnVjdCBzdDc3MDEgaXMgbm90IHVzZWQgYW5kIHNob3VsZCBiZSBkZWxldGVkLgoKPiA+ID4gK3N0 YXRpYyBpbnQgc3Q3NzAxX3ByZXBhcmUoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwpCj4gPiA+ICt7 Cj4gPiA+ICsgICAgIHN0cnVjdCBzdDc3MDEgKnN0NzcwMSA9IHBhbmVsX3RvX3N0NzcwMShwYW5l bCk7Cj4gPiA+ICsgICAgIGludCByZXQ7Cj4gPiA+ICsKPiA+ID4gKyAgICAgZ3Bpb2Rfc2V0X3Zh bHVlKHN0NzcwMS0+cmVzZXQsIDApOwo+ID4gPiArICAgICBtc2xlZXAoMjApOwo+ID4gPiArCj4g PiA+ICsgICAgIHJldCA9IHJlZ3VsYXRvcl9idWxrX2VuYWJsZShzdDc3MDEtPmRlc2MtPm51bV9z dXBwbGllcywKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0NzcwMS0+ c3VwcGxpZXMpOwo+ID4gPiArICAgICBpZiAocmV0IDwgMCkKPiA+ID4gKyAgICAgICAgICAgICBy ZXR1cm4gcmV0Owo+ID4gPiArICAgICBtc2xlZXAoMjApOwo+ID4gPiArCj4gPiA+ICsgICAgIGdw aW9kX3NldF92YWx1ZShzdDc3MDEtPnJlc2V0LCAxKTsKPiA+ID4gKyAgICAgbXNsZWVwKDIwKTsK PiA+ID4gKwo+ID4gPiArICAgICBncGlvZF9zZXRfdmFsdWUoc3Q3NzAxLT5yZXNldCwgMCk7Cj4g PiA+ICsgICAgIG1zbGVlcCgzMCk7Cj4gPiA+ICsKPiA+ID4gKyAgICAgZ3Bpb2Rfc2V0X3ZhbHVl KHN0NzcwMS0+cmVzZXQsIDEpOwo+ID4gPiArICAgICBtc2xlZXAoMTUwKTsKPiA+ID4gKwo+ID4g PiArICAgICBzdDc3MDFfaW5pdF9zZXF1ZW5jZShzdDc3MDEpOwo+ID4gPiArCj4gPiA+ICsgICAg IHJldHVybiAwOwo+ID4gPiArfQo+ID4gPiArCj4gPgo+ID4gPiArc3RhdGljIGludCBzdDc3MDFf dW5wcmVwYXJlKHN0cnVjdCBkcm1fcGFuZWwgKnBhbmVsKQo+ID4gPiArewo+ID4gPiArICAgICBz dHJ1Y3Qgc3Q3NzAxICpzdDc3MDEgPSBwYW5lbF90b19zdDc3MDEocGFuZWwpOwo+ID4gPiArCj4g PiA+ICsgICAgIFNUNzcwMV9EU0koc3Q3NzAxLCBNSVBJX0RDU19FWElUX1NMRUVQX01PREUsIDB4 MDApOwoKU2hvdWxkIHRoaXMgYmUgTUlQSV9EQ1NfRU5URVJfU0xFRVBfTU9ERT8KCk5vdGUgLSB5 b3UgaGF2ZSBzaG9ydGN1dHMgZm90IHRoZSBzdGFuZGFyZCBjb21tYW5kcyBsaWtlCmluIHRoaXMg Y2FzZToKCgltaXBpX2RzaV9kY3NfZW50ZXJfc2xlZXBfbW9kZShzdDc3MDEtPmRzaSk7CgpUaGF5 IGNvdWxkIGJlIGludHJvZHVjZWQgaW4gbWFueSBwYWxjZXMsIGJ1dCBJIGFsc28gbGlrZSBob3cg YWxsIHRoZQpjb21tYW5kcyBmb2xsb3dzIGEgY29uc2lzdGVudCB3YXkgdG8gYmUgaXNzdWVkLgpT byBjb25zaWRlciB0aGlzIG9ubHkgaWYgdGhpcyB3YXMgbmV3IGZvciB5b3UuCgoKPiA+ID4gKwo+ ID4gPiArICAgICBtc2xlZXAoc3Q3NzAxLT5zbGVlcF9kZWxheSk7Cj4gPiA+ICsKPiA+ID4gKyAg ICAgZ3Bpb2Rfc2V0X3ZhbHVlKHN0NzcwMS0+cmVzZXQsIDApOwo+ID4gPiArCj4gPiA+ICsgICAg IGdwaW9kX3NldF92YWx1ZShzdDc3MDEtPnJlc2V0LCAxKTsKPiA+ID4gKwo+ID4gPiArICAgICBn cGlvZF9zZXRfdmFsdWUoc3Q3NzAxLT5yZXNldCwgMCk7Cj4gPiBObyB0aW1pbmcgY29uc3RyYWlu cyBoZXJlPyBJbiBwcmVwYXJlIHRoZXJlIGFyZSBzbGVlcHMgaW50ZXJtaXhlZC4KPiAKPiBEZWxh eSB3aGlsZSBkb2luZyB1bnByYXJlIGlzIG5vdCBuZWVkZWQgSSBzdXBwb3NlLgoKSWYgdGhlIHB1 cnBvc2UgaXMgYWxvbmUgdG8gcmVzZXQgdGhlIGRpc3BsYXkgdGhlbiBhIHNpbmdsZSB3cml0ZSAn MCcKc2hvdWxkIGRvIGl0IEkgdGhpbmsKQW5kIHRoZXJlIGlzIGEgcmVxdWlyZW1lbnQgdGhhdCBp dCBtdXN0IGJlIGxvdyBmb3IgYSBtaW5pbXVtIG9mIDEwIHVzCndoaWNoIHdvdWxkIGJlIGdvb2Qg dG8gaGF2ZSBoZXJlLgoKSSBhc2xvIGZvdW5kIGluIGNoYXB0ZXIgOS4gKHBhZ2UgMTYzIC0gc2Vj b25kIGxpbmUpIHRoaXMgc3RhdGVtZW50OgoiVkREQSBhbmQgVkRESSBtdXN0IGJlIHBvd2VyZWQg ZG93biB3aXRoIG1pbmltdW0gMTIwbXNlYy4iCgpUaGlzIGlzIHNpbWlsYXIgdG8gdGhlIHVucHJl cGFyZSBkZWxheSB0byBiZSBmb3VuZCBpbiBzaW1wbGUtcGFuZWwuYwpTbyBhbiB1bnByZXBhcmUg ZGVsYXkgc2VlbXMgaW4gb3JkZXIgaGVyZS4KCgo+ID4gPiArc3RhdGljIGNvbnN0IHN0cnVjdCBz dDc3MDFfcGFuZWxfZGVzYyB0czg1NTBiX2Rlc2MgPSB7Cj4gPiA+ICsgICAgIC5tb2RlID0gJnRz ODU1MGJfbW9kZSwKPiA+ID4gKyAgICAgLmxhbmVzID0gMiwKPiA+ID4gKyAgICAgLmZsYWdzID0g TUlQSV9EU0lfTU9ERV9WSURFTywKPiA+ID4gKyAgICAgLmZvcm1hdCA9IE1JUElfRFNJX0ZNVF9S R0I4ODgsCj4gPiA+ICsgICAgIC5zdXBwbHlfbmFtZXMgPSB0czg1NTBiX3N1cHBseV9uYW1lcywK PiA+ID4gKyAgICAgLm51bV9zdXBwbGllcyA9IEFSUkFZX1NJWkUodHM4NTUwYl9zdXBwbHlfbmFt ZXMpLAo+ID4gPiArICAgICAucGFuZWxfc2xlZXBfZGVsYXkgPSA4MCwgLyogcGFuZWwgbmVlZCBl eHRyYSA4MG1zIGZvciBzbGVlcCBvdXQgY21kICovCj4gPiBJbiB0aGUgb25seSBwbGFjZSB0aGlz IGlzIHVzZWQgdGhlcmUgaXMgYWRkZWQgMTIwIG1zIHRvby4KPiA+IExvb2tzIGluY29uc2lzdGVu dCAtIGRvIHdlIGhhdmUgdGhlIHNhbWUgZGVsYXkgdHdpY2U/Cj4gCj4gMTIwbXMgaXMgdGhlIG9u ZSByZWNvbW1lbmRlZCBieSBzdDc3MDEgY29udHJvbGxlciBkZWxheSBhZnRlciBhIHNsZWVwCj4g b3V0IGNvbW1hbmQsIHBsZWFzZSBjaGVjayBpdCBpbiBkYXRhc2hlZXQgWzFdLCBwYWdlIDE4OC4g QW5kIHRoaXMgODBtcwo+IGlzIHNwZWNpZmljIHRvIFRTODU1MEIgcGFuZWwgYXMgcGVyIEJTUCBj b2RlIHRoaXMgZG9lc24ndCBoYXZlIHByb3Blcgo+IGRvY3VtZW50YXRpb24gYnV0IHRoZSBCU1Ag Y29kZSBkb2luZyB0aGlzIGV4dHJhIDgwbXMuCgpPSywgdGhhbmtzIGZvciB0aGUgcG9pbnRlciB0 byB0aGUgZGF0YXNoZWV0LgoKPiBbMV0gaHR0cDovL3d3dy5zdGFydGVrLWxjZC5jb20vcmVzL3N0 YXJ0ZWtsY2QvcGRyZXMvMjAxNzA1LzIwMTcwNTEyMTQ0MjQyOTA0LnBkZgoKCglTYW0KX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==