From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] [RFC] drm_hwcomposer: Add support for Arm Framebuffer Compression (AFBC) modifiers. Date: Tue, 15 Jan 2019 13:05:47 +0100 Message-ID: <20190115120547.GL10517@phenom.ffwll.local> References: <1547479696-14376-1-git-send-email-ayan.halder@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6437E6ECAF for ; Tue, 15 Jan 2019 12:05:52 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id f23so2354812edb.3 for ; Tue, 15 Jan 2019 04:05:52 -0800 (PST) Content-Disposition: inline In-Reply-To: <1547479696-14376-1-git-send-email-ayan.halder@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ayan Halder Cc: "seanpaul@google.com" , Liviu Dudau , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "malidp@foss.arm.com" , nd List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKYW4gMTQsIDIwMTkgYXQgMDM6Mjg6MjdQTSArMDAwMCwgQXlhbiBIYWxkZXIgd3Jv dGU6Cj4gT25lIG5lZWRzIHRvIHRyYW5zbGF0ZSB0aGUgR3JhbGxvYyBidWZmZXIgZmxhZ3MgZm9y IEFGQkMgKGVnCj4gTUFMSV9HUkFMTE9DX0lOVEZNVF9BRkJDX0JBU0lDKSB0byB0aGUgY29ycmVz cG9uZGluZyBsaW51eCBrZXJuZWwgZHJtIG1vZGlmaWVycy4KPiBUaGlzIGdldHMgcGFzc2VkIHRv IGxpYmRybSB2aWEgZHJtTW9kZUFkZEZCMldpdGhNb2RpZmllcnMuCj4gCj4gU2lnbmVkLW9mZi1i eTogQXlhbiBLdW1hciBIYWxkZXIgPGF5YW4uaGFsZGVyQGFybS5jb20+Cj4gCj4gLy0tIE5vdGUg Zm9yIHJldmlld2VyCj4gSSB3YXMgYWJsZSB0byBnZXQgdGhpcyB3b3JraW5nIGZvciBBbmRyb2lk IFAgb24gSnVubyB3aXRoIE1hbGkgRFA2NTAgYW5kIE1hbGkKPiBUODYwIGdwdSh3aXRoIHNvbWUg YWRkaXRpb25hbCBoYWNrcykuIEkgaGF2ZSBub3QgeWV0IHZhbGlkYXRlZCB0aGlzIGhpa2V5OTYw Lgo+IAo+IEkgaGF2ZSB1c2VkIHRoZSBmb2xsb3dpbmcgY29tcG9uZW50czotCj4gMS4gR3JhbGxv YyAoZnJvbSBodHRwczovL2FuZHJvaWQuZ29vZ2xlc291cmNlLmNvbS9kZXZpY2UvbGluYXJvL2hp a2V5LysvbWFzdGVyL2dyYWxsb2M5NjApCj4gICAtIEJ1aWx0IHdpdGggTUFMSV9NTVNTPTEKPiAy LiBMaWJkcm0gKGZyb20gZ2l0Oi8vYW5vbmdpdC5mcmVlZGVza3RvcC5vcmcvbWVzYS9kcm0pCj4g ICAtIFlvdSB3b3VsZCBuZWVkIGRybV9mb3VyY2MuaCBhbmQgZ3JhbGxvY19oYW5kbGUuaAo+IC0t LwoKSSB0aG91Z2h0IGRybV9od2NvbXBvc2VyIGhhcyBzd2l0Y2hlZCBvdmVyIHRvIGdpdGxhYiBt ZXJnZSByZXF1ZXN0cz8KUkVBRE1FIGF0IGxlYXN0IHNheXMgc286CgpodHRwczovL2dpdGxhYi5m cmVlZGVza3RvcC5vcmcvZHJtLWh3Y29tcG9zZXIvZHJtLWh3Y29tcG9zZXIKCkNoZWVycywgRGFu aWVsCgo+IC0tLQo+ICBwbGF0Zm9ybWRybWdlbmVyaWMuY3BwIHwgNDIgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIHBsYXRmb3JtZHJtZ2VuZXJpYy5oICAgfCAg MiArKwo+ICBwbGF0Zm9ybWhpc2kuY3BwICAgICAgIHwgMTQgKysrKysrKysrKysrLS0KPiAgMyBm aWxlcyBjaGFuZ2VkLCA1NiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9wbGF0Zm9ybWRybWdlbmVyaWMuY3BwIGIvcGxhdGZvcm1kcm1nZW5lcmljLmNwcAo+ IGluZGV4IDUwM2MwNGEuLmE1MjAyMjQgMTAwNjQ0Cj4gLS0tIGEvcGxhdGZvcm1kcm1nZW5lcmlj LmNwcAo+ICsrKyBiL3BsYXRmb3JtZHJtZ2VuZXJpYy5jcHAKPiBAQCAtMTgsNiArMTgsNyBAQAo+ ICAKPiAgI2luY2x1ZGUgInBsYXRmb3JtZHJtZ2VuZXJpYy5oIgo+ICAjaW5jbHVkZSAiZHJtZGV2 aWNlLmgiCj4gKyNpbmNsdWRlICJtYWxpX2dyYWxsb2NfZm9ybWF0cy5oIgo+ICAjaW5jbHVkZSAi cGxhdGZvcm0uaCIKPiAgCj4gICNpbmNsdWRlIDxkcm0vZHJtX2ZvdXJjYy5oPgo+IEBAIC04Myw2 ICs4NCwzMSBAQCB1aW50MzJfdCBEcm1HZW5lcmljSW1wb3J0ZXI6OkNvbnZlcnRIYWxGb3JtYXRU b0RybSh1aW50MzJfdCBoYWxfZm9ybWF0KSB7Cj4gICAgfQo+ICB9Cj4gIAo+ICt1aW50NjRfdCBE cm1HZW5lcmljSW1wb3J0ZXI6OkNvbnZlcnRHcmFsbG9jRm9ybWF0VG9Ecm1Nb2RpZmllcnModWlu dDY0X3QgZmxhZ3MsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBib29sIGlzX3JnYikgewo+ICsgIHVpbnQ2NF90IGZlYXR1 cmVzID0gMDsKPiArCj4gKyAgaWYgKGZsYWdzICYgTUFMSV9HUkFMTE9DX0lOVEZNVF9BRkJDX0JB U0lDKQo+ICsgICAgZmVhdHVyZXMgfD0gQUZCQ19GT1JNQVRfTU9EX0JMT0NLX1NJWkVfMTZ4MTY7 Cj4gKwo+ICsgIGlmIChpc19yZ2IpCj4gKyAgICBmZWF0dXJlcyB8PSBBRkJDX0ZPUk1BVF9NT0Rf WVRSOwo+ICsKPiArICBpZiAoZmxhZ3MgJiBNQUxJX0dSQUxMT0NfSU5URk1UX0FGQkNfU1BMSVRC TEspCj4gKyAgICBmZWF0dXJlcyB8PSAoQUZCQ19GT1JNQVRfTU9EX1NQTElUIHwgQUZCQ19GT1JN QVRfTU9EX1NQQVJTRSk7Cj4gKwo+ICsgIGlmIChmbGFncyAmIE1BTElfR1JBTExPQ19JTlRGTVRf QUZCQ19XSURFQkxLKQo+ICsgICAgZmVhdHVyZXMgfD0gQUZCQ19GT1JNQVRfTU9EX0JMT0NLX1NJ WkVfMzJ4ODsKPiArCj4gKyAgaWYgKGZsYWdzICYgTUFMSV9HUkFMTE9DX0lOVEZNVF9BRkJDX1RJ TEVEX0hFQURFUlMpCj4gKyAgICBmZWF0dXJlcyB8PSBBRkJDX0ZPUk1BVF9NT0RfVElMRUQ7Cj4g Kwo+ICsgIGlmIChmZWF0dXJlcykKPiArICAgIHJldHVybiBEUk1fRk9STUFUX01PRF9BUk1fQUZC QyhmZWF0dXJlcyk7Cj4gKyAgZWxzZQo+ICsgICAgcmV0dXJuIDA7Cj4gK30KPiArCj4gIHVpbnQz Ml90IERybUdlbmVyaWNJbXBvcnRlcjo6RHJtRm9ybWF0VG9CaXRzUGVyUGl4ZWwodWludDMyX3Qg ZHJtX2Zvcm1hdCkgewo+ICAgIHN3aXRjaCAoZHJtX2Zvcm1hdCkgewo+ICAgICAgY2FzZSBEUk1f Rk9STUFUX0FSR0I4ODg4Ogo+IEBAIC0xMDEsNiArMTI3LDIyIEBAIHVpbnQzMl90IERybUdlbmVy aWNJbXBvcnRlcjo6RHJtRm9ybWF0VG9CaXRzUGVyUGl4ZWwodWludDMyX3QgZHJtX2Zvcm1hdCkg ewo+ICAgIH0KPiAgfQo+ICAKPiArYm9vbCBEcm1HZW5lcmljSW1wb3J0ZXI6OklzRHJtRm9ybWF0 UmdiKHVpbnQzMl90IGRybV9mb3JtYXQpIHsKPiArICBzd2l0Y2ggKGRybV9mb3JtYXQpIHsKPiAr ICAgIGNhc2UgRFJNX0ZPUk1BVF9BUkdCODg4ODoKPiArICAgIGNhc2UgRFJNX0ZPUk1BVF9YQkdS ODg4ODoKPiArICAgIGNhc2UgRFJNX0ZPUk1BVF9BQkdSODg4ODoKPiArICAgIGNhc2UgRFJNX0ZP Uk1BVF9CR1I4ODg6Cj4gKyAgICBjYXNlIERSTV9GT1JNQVRfQkdSNTY1Ogo+ICsgICAgICByZXR1 cm4gdHJ1ZTsKPiArICAgIGNhc2UgRFJNX0ZPUk1BVF9ZVlU0MjA6Cj4gKyAgICAgIHJldHVybiBm YWxzZTsKPiArICAgIGRlZmF1bHQ6Cj4gKyAgICAgIEFMT0dFKCJVbnN1cHBvcnRlZCBmb3JtYXQg JXUgYXNzdW1pbmcgcmdiPyIsIGRybV9mb3JtYXQpOwo+ICsgICAgICByZXR1cm4gdHJ1ZTsKPiAr ICB9Cj4gK30KPiArCj4gIGludCBEcm1HZW5lcmljSW1wb3J0ZXI6OkltcG9ydEJ1ZmZlcihidWZm ZXJfaGFuZGxlX3QgaGFuZGxlLCBod2NfZHJtX2JvX3QgKmJvKSB7Cj4gICAgZ3JhbGxvY19oYW5k bGVfdCAqZ3JfaGFuZGxlID0gZ3JhbGxvY19oYW5kbGUoaGFuZGxlKTsKPiAgICBpZiAoIWdyX2hh bmRsZSkKPiBkaWZmIC0tZ2l0IGEvcGxhdGZvcm1kcm1nZW5lcmljLmggYi9wbGF0Zm9ybWRybWdl bmVyaWMuaAo+IGluZGV4IDIzM2JhNTUuLjQzY2I2MTggMTAwNjQ0Cj4gLS0tIGEvcGxhdGZvcm1k cm1nZW5lcmljLmgKPiArKysgYi9wbGF0Zm9ybWRybWdlbmVyaWMuaAo+IEBAIC0zNiw2ICszNiw4 IEBAIGNsYXNzIERybUdlbmVyaWNJbXBvcnRlciA6IHB1YmxpYyBJbXBvcnRlciB7Cj4gICAgYm9v bCBDYW5JbXBvcnRCdWZmZXIoYnVmZmVyX2hhbmRsZV90IGhhbmRsZSkgb3ZlcnJpZGU7Cj4gIAo+ ICAgIHVpbnQzMl90IENvbnZlcnRIYWxGb3JtYXRUb0RybSh1aW50MzJfdCBoYWxfZm9ybWF0KTsK PiArICB1aW50NjRfdCBDb252ZXJ0R3JhbGxvY0Zvcm1hdFRvRHJtTW9kaWZpZXJzKHVpbnQ2NF90 IGZsYWdzLCBib29sIGlzX3JnYik7Cj4gKyAgYm9vbCBJc0RybUZvcm1hdFJnYih1aW50MzJfdCBk cm1fZm9ybWF0KTsKPiAgICB1aW50MzJfdCBEcm1Gb3JtYXRUb0JpdHNQZXJQaXhlbCh1aW50MzJf dCBkcm1fZm9ybWF0KTsKPiAgCj4gICBwcml2YXRlOgo+IGRpZmYgLS1naXQgYS9wbGF0Zm9ybWhp c2kuY3BwIGIvcGxhdGZvcm1oaXNpLmNwcAo+IGluZGV4IDc2ZmUxZTcuLjFjYjdlMmMgMTAwNjQ0 Cj4gLS0tIGEvcGxhdGZvcm1oaXNpLmNwcAo+ICsrKyBiL3BsYXRmb3JtaGlzaS5jcHAKPiBAQCAt NzEsNiArNzEsOSBAQCBpbnQgSGlzaUltcG9ydGVyOjpJbml0KCkgewo+ICB9Cj4gIAo+ICBpbnQg SGlzaUltcG9ydGVyOjpJbXBvcnRCdWZmZXIoYnVmZmVyX2hhbmRsZV90IGhhbmRsZSwgaHdjX2Ry bV9ib190ICpibykgewo+ICsgIGJvb2wgaXNfcmdiOwo+ICsgIHVpbnQ2NF90IG1vZGlmaWVyc1s0 XSA9IHswfTsKPiArCj4gICAgbWVtc2V0KGJvLCAwLCBzaXplb2YoaHdjX2RybV9ib190KSk7Cj4g IAo+ICAgIHByaXZhdGVfaGFuZGxlX3QgY29uc3QgKmhuZCA9IHJlaW50ZXJwcmV0X2Nhc3Q8cHJp dmF0ZV9oYW5kbGVfdCBjb25zdCAqPigKPiBAQCAtOTQsNiArOTcsMTAgQEAgaW50IEhpc2lJbXBv cnRlcjo6SW1wb3J0QnVmZmVyKGJ1ZmZlcl9oYW5kbGVfdCBoYW5kbGUsIGh3Y19kcm1fYm9fdCAq Ym8pIHsKPiAgICBpZiAoZm10IDwgMCkKPiAgICAgIHJldHVybiBmbXQ7Cj4gIAo+ICsgIGlzX3Jn YiA9IElzRHJtRm9ybWF0UmdiKGZtdCk7Cj4gKyAgbW9kaWZpZXJzWzBdID0gQ29udmVydEdyYWxs b2NGb3JtYXRUb0RybU1vZGlmaWVycyhobmQtPmludGVybmFsX2Zvcm1hdCwKPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlzX3JnYik7Cj4gKwo+ ICAgIGJvLT53aWR0aCA9IGhuZC0+d2lkdGg7Cj4gICAgYm8tPmhlaWdodCA9IGhuZC0+aGVpZ2h0 Owo+ICAgIGJvLT5oYWxfZm9ybWF0ID0gaG5kLT5yZXFfZm9ybWF0Owo+IEBAIC0xMjksOCArMTM2 LDExIEBAIGludCBIaXNpSW1wb3J0ZXI6OkltcG9ydEJ1ZmZlcihidWZmZXJfaGFuZGxlX3QgaGFu ZGxlLCBod2NfZHJtX2JvX3QgKmJvKSB7Cj4gICAgICAgIGJyZWFrOwo+ICAgIH0KPiAgCj4gLSAg cmV0ID0gZHJtTW9kZUFkZEZCMihkcm1fLT5mZCgpLCBiby0+d2lkdGgsIGJvLT5oZWlnaHQsIGJv LT5mb3JtYXQsCj4gLSAgICAgICAgICAgICAgICAgICAgICBiby0+Z2VtX2hhbmRsZXMsIGJvLT5w aXRjaGVzLCBiby0+b2Zmc2V0cywgJmJvLT5mYl9pZCwgMCk7Cj4gKyAgcmV0ID0gZHJtTW9kZUFk ZEZCMldpdGhNb2RpZmllcnMoZHJtXy0+ZmQoKSwgYm8tPndpZHRoLCBiby0+aGVpZ2h0LAo+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvLT5mb3JtYXQsIGJvLT5nZW1faGFu ZGxlcywgYm8tPnBpdGNoZXMsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Ym8tPm9mZnNldHMsIG1vZGlmaWVycywgJmJvLT5mYl9pZCwKPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBtb2RpZmllcnNbMF0gPyBEUk1fTU9ERV9GQl9NT0RJRklFUlMgOiAw KTsKPiArCj4gICAgaWYgKHJldCkgewo+ICAgICAgQUxPR0UoImNvdWxkIG5vdCBjcmVhdGUgZHJt IGZiICVkIiwgcmV0KTsKPiAgICAgIHJldHVybiByZXQ7Cj4gLS0gCj4gMi43LjQKPiAKPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApEYW5p ZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxv Zy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK