From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR Date: Tue, 15 Jan 2019 16:15:49 +0100 Message-ID: <20190115151549.GP10517@phenom.ffwll.local> References: <20190115102755.16183-1-daniel.vetter@ffwll.ch> <20190115103829.GC18959@kroah.com> <20190115121228.GO10517@phenom.ffwll.local> <20190115134553.GD30742@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190115134553.GD30742@kroah.com> Sender: linux-kernel-owner@vger.kernel.org To: Greg Kroah-Hartman Cc: DRI Development , LKML , Daniel Vetter , Hans de Goede , Bartlomiej Zolnierkiewicz , Alexander Kapshuk List-Id: dri-devel@lists.freedesktop.org On Tue, Jan 15, 2019 at 02:45:53PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 15, 2019 at 01:12:28PM +0100, Daniel Vetter wrote: > > On Tue, Jan 15, 2019 at 11:38:29AM +0100, Greg Kroah-Hartman wrote: > > > On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote: > > > > It's a debug hack flag useful to work around driver bugs. That's not a > > > > good idea for a new driver. Especially for a new drm driver. > > > > > > > > Aside: the fbdev support should probably be converted over to the new > > > > generic fbdev support. > > > > > > > > Signed-off-by: Daniel Vetter > > > > Cc: Greg Kroah-Hartman > > > > Cc: Hans de Goede > > > > Cc: Daniel Vetter > > > > Cc: Bartlomiej Zolnierkiewicz > > > > Cc: Alexander Kapshuk > > > > --- > > > > drivers/staging/vboxvideo/vbox_fb.c | 5 ----- > > > > 1 file changed, 5 deletions(-) > > > > > > > > > > Reviewed-by: Greg Kroah-Hartman > > > > Since Hans wants to destage vboxvideo this cycle probably best I merge > > this through drm-misc? Just to make sure it's not lost. > > Feel free to do so! Applied, thanks for your review. I think 2/2 is directly staging material for you (somehow get_maintainers.pl didn't add you to the cc: list, not sure why ...). -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch