From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 23/23] drm/qxl: add overflow checks to qxl_mode_dumb_create() Date: Fri, 18 Jan 2019 18:32:33 +0200 Message-ID: <20190118163233.GM20097@intel.com> References: <20190118122020.27596-1-kraxel@redhat.com> <20190118122020.27596-24-kraxel@redhat.com> <20190118154944.GH3271@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190118154944.GH3271@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spice-devel-bounces@lists.freedesktop.org Sender: "Spice-devel" To: Gerd Hoffmann , dri-devel@lists.freedesktop.org, Dave Airlie , David Airlie , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , open list List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKYW4gMTgsIDIwMTkgYXQgMDQ6NDk6NDRQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBGcmksIEphbiAxOCwgMjAxOSBhdCAwMToyMDoyMFBNICswMTAwLCBHZXJkIEhv ZmZtYW5uIHdyb3RlOgo+ID4gU2lnbmVkLW9mZi1ieTogR2VyZCBIb2ZmbWFubiA8a3JheGVsQHJl ZGhhdC5jb20+Cj4gCj4gV2UgYWxyZWFkeSBkbyBhbGwgcmVhc29uYWJsZSBvdmVyZmxvdyBjaGVj a3MgaW4gZHJtX21vZGVfY3JlYXRlX2R1bWIoKS4gSWYKPiB5b3UgZG9uJ3QgdHJ1c3QgdGhlbSBJ IHRoaW5rIHdvdWxkIGJlIGJldHRlciB0aW1lIHNwZW50IHR5cGluZyBhbiBpZ3QgdG8KPiB0ZXN0 IHRoaXMgdGhhbiBhZGRpbmcgcmVkdW5kYW50IGNoZWNrIGluIGFsbCBkcml2ZXJzLgo+IAo+IFlv dSdyZSBhbHNvIG1pc3Npbmcgb25lIGNoZWNrIGZvciBicHAgdW5kZXJmbG93cyA6LSkKCkJUVyBJ IGp1c3Qgbm90aWNlZCB0aGF0IHdlIGRvbid0IHNlZW0gdG8gdmFsaWRhdGluZyAKY3JlYXRlX2R1 bWItPmZsYWdzIGF0IGFsbC4gU29tZW9uZSBzaG91bGQgcHJvYmFibHkgYWRkIHNvbWUKY2hlY2tz IGZvciB0aGF0LCBvciBtYXJrIGl0IGFzIGRlcHJlY2F0ZWQgaW4gY2FzZSB3ZSBhbHJlYWR5Cmxv c3QgdGhlIGJhdHRsZSB3aXRoIHVzZXJzcGFjZSBzdGFjayBnYXJiYWdlLgoKPiAtRGFuaWVsCj4g Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vcXhsL3F4bF9kdW1iLmMgfCAxMCArKysrKyst LS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkK PiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2R1bWIuYyBiL2Ry aXZlcnMvZ3B1L2RybS9xeGwvcXhsX2R1bWIuYwo+ID4gaW5kZXggMjcyZDE5YjY3Ny4uYmVkNmQw NmVlNCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2R1bWIuYwo+ID4g KysrIGIvZHJpdmVycy9ncHUvZHJtL3F4bC9xeGxfZHVtYi5jCj4gPiBAQCAtMzcsMTEgKzM3LDEz IEBAIGludCBxeGxfbW9kZV9kdW1iX2NyZWF0ZShzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiwK PiA+ICAJdWludDMyX3QgaGFuZGxlOwo+ID4gIAlpbnQgcjsKPiA+ICAJc3RydWN0IHF4bF9zdXJm YWNlIHN1cmY7Cj4gPiAtCXVpbnQzMl90IHBpdGNoLCBmb3JtYXQ7Cj4gPiArCXVpbnQzMl90IHBp dGNoLCBzaXplLCBmb3JtYXQ7Cj4gPiAgCj4gPiAtCXBpdGNoID0gYXJncy0+d2lkdGggKiAoKGFy Z3MtPmJwcCArIDEpIC8gOCk7Cj4gPiAtCWFyZ3MtPnNpemUgPSBwaXRjaCAqIGFyZ3MtPmhlaWdo dDsKPiA+IC0JYXJncy0+c2l6ZSA9IEFMSUdOKGFyZ3MtPnNpemUsIFBBR0VfU0laRSk7Cj4gPiAr CWlmIChjaGVja19tdWxfb3ZlcmZsb3coYXJncy0+d2lkdGgsICgoYXJncy0+YnBwICsgMSkgLyA4 KSwgJnBpdGNoKSkKPiA+ICsJCXJldHVybiAtRUlOVkFMOwo+ID4gKwlpZiAoY2hlY2tfbXVsX292 ZXJmbG93KHBpdGNoLCBhcmdzLT5oZWlnaHQsICZzaXplKSkKPiA+ICsJCXJldHVybiAtRUlOVkFM Owo+ID4gKwlhcmdzLT5zaXplID0gQUxJR04oc2l6ZSwgUEFHRV9TSVpFKTsKPiA+ICAKPiA+ICAJ c3dpdGNoIChhcmdzLT5icHApIHsKPiA+ICAJY2FzZSAxNjoKPiA+IC0tIAo+ID4gMi45LjMKPiA+ IAo+IAo+IC0tIAo+IERhbmllbCBWZXR0ZXIKPiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29y cG9yYXRpb24KPiBodHRwOi8vYmxvZy5mZndsbC5jaAo+IF9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpTcGljZS1kZXZl bCBtYWlsaW5nIGxpc3QKU3BpY2UtZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vc3BpY2UtZGV2ZWwK