From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH 07/11] drm/tinydrm/repaper: Use devm_drm_dev_*() Date: Sun, 20 Jan 2019 23:22:36 +0100 Message-ID: <20190120222236.GB24538@ravnborg.org> References: <20190120114318.49199-1-noralf@tronnes.org> <20190120114318.49199-8-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A76689834 for ; Sun, 20 Jan 2019 22:22:40 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190120114318.49199-8-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: david@lechnology.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTm9yYWxmLgoKT24gU3VuLCBKYW4gMjAsIDIwMTkgYXQgMTI6NDM6MTRQTSArMDEwMCwgTm9y YWxmIFRyw7hubmVzIHdyb3RlOgo+IFVzZSBkZXZtX2RybV9kZXZfaW5pdCgpLCBkZXZtX2RybV9k ZXZfcmVnaXN0ZXJfd2l0aF9mYmRldigpIGFuZCBkcm9wCj4gdXNpbmcgdGlueWRybV9kZXZpY2Uu Cj4gCj4gU2lnbmVkLW9mZi1ieTogTm9yYWxmIFRyw7hubmVzIDxub3JhbGZAdHJvbm5lcy5vcmc+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS90aW55ZHJtL3JlcGFwZXIuYyB8IDYzICsrKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQwIGluc2VydGlvbnMo KyksIDIzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdGlu eWRybS9yZXBhcGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vdGlueWRybS9yZXBhcGVyLmMKPiBpbmRl eCAzMTQxMjQxY2E4ZjAuLjRjODIwNTU2NTY2OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vdGlueWRybS9yZXBhcGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdGlueWRybS9yZXBh cGVyLmMKPiBAQCAtMzQsNyArMzQsNyBAQAo+ICAjaW5jbHVkZSA8ZHJtL2RybV9nZW1fZnJhbWVi dWZmZXJfaGVscGVyLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJtX3JlY3QuaD4KPiAgI2luY2x1ZGUg PGRybS9kcm1fdmJsYW5rLmg+Cj4gLSNpbmNsdWRlIDxkcm0vdGlueWRybS90aW55ZHJtLmg+Cj4g KyNpbmNsdWRlIDxkcm0vZHJtX3NpbXBsZV9rbXNfaGVscGVyLmg+Cj4gICNpbmNsdWRlIDxkcm0v dGlueWRybS90aW55ZHJtLWhlbHBlcnMuaD4KPiAgCj4gICNkZWZpbmUgUkVQQVBFUl9SSURfRzJf Q09HX0lECTB4MTIKPiBAQCAtNjAsNyArNjAsOCBAQCBlbnVtIHJlcGFwZXJfZXBkX2JvcmRlcl9i eXRlIHsKPiAgfTsKPiAgCj4gIHN0cnVjdCByZXBhcGVyX2VwZCB7Cj4gLQlzdHJ1Y3QgdGlueWRy bV9kZXZpY2UgdGlueWRybTsKPiArCXN0cnVjdCBkcm1fZGV2aWNlIGJhc2U7Cj4gKwlzdHJ1Y3Qg ZHJtX3NpbXBsZV9kaXNwbGF5X3BpcGUgcGlwZTsKPiAgCXN0cnVjdCBzcGlfZGV2aWNlICpzcGk7 Cj4gIAo+ICAJc3RydWN0IGdwaW9fZGVzYyAqcGFuZWxfb247Cj4gQEAgLTg5LDEwICs5MCw5IEBA IHN0cnVjdCByZXBhcGVyX2VwZCB7Cj4gIAlib29sIHBhcnRpYWw7Cj4gIH07Cj4gIAo+IC1zdGF0 aWMgaW5saW5lIHN0cnVjdCByZXBhcGVyX2VwZCAqCj4gLWVwZF9mcm9tX3Rpbnlkcm0oc3RydWN0 IHRpbnlkcm1fZGV2aWNlICp0ZGV2KQo+ICtzdGF0aWMgaW5saW5lIHN0cnVjdCByZXBhcGVyX2Vw ZCAqZHJtX3RvX2VwZChzdHJ1Y3QgZHJtX2RldmljZSAqZHJtKQo+ICB7Cj4gLQlyZXR1cm4gY29u dGFpbmVyX29mKHRkZXYsIHN0cnVjdCByZXBhcGVyX2VwZCwgdGlueWRybSk7Cj4gKwlyZXR1cm4g Y29udGFpbmVyX29mKGRybSwgc3RydWN0IHJlcGFwZXJfZXBkLCBiYXNlKTsKPiAgfQo+ICAKPiAg c3RhdGljIGludCByZXBhcGVyX3NwaV90cmFuc2ZlcihzdHJ1Y3Qgc3BpX2RldmljZSAqc3BpLCB1 OCBoZWFkZXIsCj4gQEAgLTUzMCw4ICs1MzAsNyBAQCBzdGF0aWMgaW50IHJlcGFwZXJfZmJfZGly dHkoc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4gIHsKPiAgCXN0cnVjdCBkcm1fZ2VtX2Nt YV9vYmplY3QgKmNtYV9vYmogPSBkcm1fZmJfY21hX2dldF9nZW1fb2JqKGZiLCAwKTsKPiAgCXN0 cnVjdCBkbWFfYnVmX2F0dGFjaG1lbnQgKmltcG9ydF9hdHRhY2ggPSBjbWFfb2JqLT5iYXNlLmlt cG9ydF9hdHRhY2g7Cj4gLQlzdHJ1Y3QgdGlueWRybV9kZXZpY2UgKnRkZXYgPSBmYi0+ZGV2LT5k ZXZfcHJpdmF0ZTsKPiAtCXN0cnVjdCByZXBhcGVyX2VwZCAqZXBkID0gZXBkX2Zyb21fdGlueWRy bSh0ZGV2KTsKPiArCXN0cnVjdCByZXBhcGVyX2VwZCAqZXBkID0gZHJtX3RvX2VwZChmYi0+ZGV2 KTsKPiAgCXN0cnVjdCBkcm1fcmVjdCBjbGlwOwo+ICAJdTggKmJ1ZiA9IE5VTEw7Cj4gIAlpbnQg cmV0ID0gMDsKPiBAQCAtNjQ2LDggKzY0NSw3IEBAIHN0YXRpYyB2b2lkIHJlcGFwZXJfcGlwZV9l bmFibGUoc3RydWN0IGRybV9zaW1wbGVfZGlzcGxheV9waXBlICpwaXBlLAo+ICAJCQkJc3RydWN0 IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICAJCQkJc3RydWN0IGRybV9wbGFuZV9zdGF0 ZSAqcGxhbmVfc3RhdGUpCj4gIHsKPiAtCXN0cnVjdCB0aW55ZHJtX2RldmljZSAqdGRldiA9IHBp cGVfdG9fdGlueWRybShwaXBlKTsKPiAtCXN0cnVjdCByZXBhcGVyX2VwZCAqZXBkID0gZXBkX2Zy b21fdGlueWRybSh0ZGV2KTsKPiArCXN0cnVjdCByZXBhcGVyX2VwZCAqZXBkID0gZHJtX3RvX2Vw ZChwaXBlLT5jcnRjLmRldik7Cj4gIAlzdHJ1Y3Qgc3BpX2RldmljZSAqc3BpID0gZXBkLT5zcGk7 Cj4gIAlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmc3BpLT5kZXY7Cj4gIAlib29sIGRjX29rID0gZmFs c2U7Cj4gQEAgLTc4MSw4ICs3NzksNyBAQCBzdGF0aWMgdm9pZCByZXBhcGVyX3BpcGVfZW5hYmxl KHN0cnVjdCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlwZSAqcGlwZSwKPiAgCj4gIHN0YXRpYyB2b2lk IHJlcGFwZXJfcGlwZV9kaXNhYmxlKHN0cnVjdCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlwZSAqcGlw ZSkKPiAgewo+IC0Jc3RydWN0IHRpbnlkcm1fZGV2aWNlICp0ZGV2ID0gcGlwZV90b190aW55ZHJt KHBpcGUpOwo+IC0Jc3RydWN0IHJlcGFwZXJfZXBkICplcGQgPSBlcGRfZnJvbV90aW55ZHJtKHRk ZXYpOwo+ICsJc3RydWN0IHJlcGFwZXJfZXBkICplcGQgPSBkcm1fdG9fZXBkKHBpcGUtPmNydGMu ZGV2KTsKPiAgCXN0cnVjdCBzcGlfZGV2aWNlICpzcGkgPSBlcGQtPnNwaTsKPiAgCXVuc2lnbmVk IGludCBsaW5lOwo+ICAKPiBAQCAtODU2LDYgKzg1MywyMyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0 IGRybV9zaW1wbGVfZGlzcGxheV9waXBlX2Z1bmNzIHJlcGFwZXJfcGlwZV9mdW5jcyA9IHsKPiAg CS5wcmVwYXJlX2ZiID0gZHJtX2dlbV9mYl9zaW1wbGVfZGlzcGxheV9waXBlX3ByZXBhcmVfZmIs Cj4gIH07Cj4gIAo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9tb2RlX2NvbmZpZ19mdW5jcyBy ZXBhcGVyX21vZGVfY29uZmlnX2Z1bmNzID0gewo+ICsJLmZiX2NyZWF0ZSA9IGRybV9nZW1fZmJf Y3JlYXRlX3dpdGhfZGlydHksCj4gKwkuYXRvbWljX2NoZWNrID0gZHJtX2F0b21pY19oZWxwZXJf Y2hlY2ssCj4gKwkuYXRvbWljX2NvbW1pdCA9IGRybV9hdG9taWNfaGVscGVyX2NvbW1pdCwKPiAr fTsKPiArCj4gK3N0YXRpYyB2b2lkIHJlcGFwZXJfcmVsZWFzZShzdHJ1Y3QgZHJtX2RldmljZSAq ZHJtKQo+ICt7Cj4gKwlzdHJ1Y3QgcmVwYXBlcl9lcGQgKmVwZCA9IGRybV90b19lcGQoZHJtKTsK PiArCj4gKwlEUk1fREVCVUdfRFJJVkVSKCJcbiIpOwo+ICsKPiArCWRybV9tb2RlX2NvbmZpZ19j bGVhbnVwKGRybSk7Cj4gKwlkcm1fZGV2X2ZpbmkoZHJtKTsKPiArCWtmcmVlKGVwZCk7Cj4gK30K PiArCj4gIHN0YXRpYyBjb25zdCB1aW50MzJfdCByZXBhcGVyX2Zvcm1hdHNbXSA9IHsKPiAgCURS TV9GT1JNQVRfWFJHQjg4ODgsCj4gIH07Cj4gQEAgLTg5NCw2ICs5MDgsNyBAQCBzdGF0aWMgc3Ry dWN0IGRybV9kcml2ZXIgcmVwYXBlcl9kcml2ZXIgPSB7Cj4gIAkuZHJpdmVyX2ZlYXR1cmVzCT0g RFJJVkVSX0dFTSB8IERSSVZFUl9NT0RFU0VUIHwgRFJJVkVSX1BSSU1FIHwKPiAgCQkJCSAgRFJJ VkVSX0FUT01JQywKPiAgCS5mb3BzCQkJPSAmcmVwYXBlcl9mb3BzLAo+ICsJLnJlbGVhc2UJCT0g cmVwYXBlcl9yZWxlYXNlLAo+ICAJRFJNX0dFTV9DTUFfVk1BUF9EUklWRVJfT1BTLAo+ICAJLm5h bWUJCQk9ICJyZXBhcGVyIiwKPiAgCS5kZXNjCQkJPSAiUGVydmFzaXZlIERpc3BsYXlzIFJlUGFw ZXIgZS1pbmsgcGFuZWxzIiwKPiBAQCAtOTI3LDcgKzk0Miw2IEBAIHN0YXRpYyBpbnQgcmVwYXBl cl9wcm9iZShzdHJ1Y3Qgc3BpX2RldmljZSAqc3BpKQo+ICAJY29uc3Qgc3RydWN0IG9mX2Rldmlj ZV9pZCAqbWF0Y2g7Cj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ICAJc3Ry dWN0IGRldmljZSAqZGV2ID0gJnNwaS0+ZGV2Owo+IC0Jc3RydWN0IHRpbnlkcm1fZGV2aWNlICp0 ZGV2Owo+ICAJZW51bSByZXBhcGVyX21vZGVsIG1vZGVsOwo+ICAJY29uc3QgY2hhciAqdGhlcm1h bF96b25lOwo+ICAJc3RydWN0IHJlcGFwZXJfZXBkICplcGQ7Cj4gQEAgLTk1MiwxMCArOTY2LDIw IEBAIHN0YXRpYyBpbnQgcmVwYXBlcl9wcm9iZShzdHJ1Y3Qgc3BpX2RldmljZSAqc3BpKQo+ICAJ CX0KPiAgCX0KPiAgCj4gLQllcGQgPSBkZXZtX2t6YWxsb2MoZGV2LCBzaXplb2YoKmVwZCksIEdG UF9LRVJORUwpOwo+ICsJZXBkID0ga3phbGxvYyhzaXplb2YoKmVwZCksIEdGUF9LRVJORUwpOwo+ ICAJaWYgKCFlcGQpCj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+ICsJZHJtID0gJmVwZC0+YmFz ZTsKPiArCXJldCA9IGRldm1fZHJtX2Rldl9pbml0KGRldiwgZHJtLCAmcmVwYXBlcl9kcml2ZXIp Owo+ICsJaWYgKHJldCkgewo+ICsJCWtmcmVlKGVwZCk7Cj4gKwkJcmV0dXJuIHJldDsKPiArCX0K SGVyZSB5b3UgZ28gdG8gdGhlIHRyb3VibGUgYW5kIGZyZWUgZXBkIG9uIGVycm9yLgoKPiArCj4g Kwlkcm1fbW9kZV9jb25maWdfaW5pdChkcm0pOwo+ICsJZHJtLT5tb2RlX2NvbmZpZy5mdW5jcyA9 ICZyZXBhcGVyX21vZGVfY29uZmlnX2Z1bmNzOwo+ICsKPiAgCWVwZC0+c3BpID0gc3BpOwo+ICAK PiAgCWVwZC0+cGFuZWxfb24gPSBkZXZtX2dwaW9kX2dldChkZXYsICJwYW5lbC1vbiIsIEdQSU9E X09VVF9MT1cpOwo+IEBAIC0xMDY2LDMyICsxMDkwLDI1IEBAIHN0YXRpYyBpbnQgcmVwYXBlcl9w cm9iZShzdHJ1Y3Qgc3BpX2RldmljZSAqc3BpKQo+ICAJaWYgKCFlcGQtPmN1cnJlbnRfZnJhbWUp Cj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+IC0JdGRldiA9ICZlcGQtPnRpbnlkcm07Cj4gLQo+ IC0JcmV0ID0gZGV2bV90aW55ZHJtX2luaXQoZGV2LCB0ZGV2LCAmcmVwYXBlcl9kcml2ZXIpOwo+ IC0JaWYgKHJldCkKPiAtCQlyZXR1cm4gcmV0Owo+IC0KPiAtCWRybSA9IHRkZXYtPmRybTsKPiAg Cj4gIAljb25uZWN0b3IgPSBkcm1fc2ltcGxlX2Nvbm5lY3Rvcl9jcmVhdGUoZHJtLCBEUk1fTU9E RV9DT05ORUNUT1JfVklSVFVBTCwgbW9kZSwgMCk7Cj4gIAlpZiAoSVNfRVJSKGNvbm5lY3Rvcikp Cj4gIAkJcmV0dXJuIFBUUl9FUlIoY29ubmVjdG9yKTsKPiAgCj4gLQlyZXQgPSBkcm1fc2ltcGxl X2Rpc3BsYXlfcGlwZV9pbml0KGRybSwgJnRkZXYtPnBpcGUsICZyZXBhcGVyX3BpcGVfZnVuY3Ms Cj4gKwlyZXQgPSBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlwZV9pbml0KGRybSwgJmVwZC0+cGlwZSwg JnJlcGFwZXJfcGlwZV9mdW5jcywKPiAgCQkJCQkgICByZXBhcGVyX2Zvcm1hdHMsIEFSUkFZX1NJ WkUocmVwYXBlcl9mb3JtYXRzKSwKPiAgCQkJCQkgICBOVUxMLCBjb25uZWN0b3IpOwo+ICAJaWYg KHJldCkKPiAgCQlyZXR1cm4gcmV0OwpCdXQgbGF0ZXIgaW4gdGhlIHNhbWUgZnVuY3Rpb24gZXBk IGlzIG5vdCBmcmVlZC4KTG9va3MgbGlrZSBhIGxlYWs/Ck5vdGhpbmcgbmV3IGlmIHRoaXMgaXMg Y29ycmVjdCBidXQganVzdCBzcG90dGVkIGl0LgoKPiAgCj4gIAlkcm1fc2ltcGxlX2Nvbm5lY3Rv cl9zZXRfbW9kZV9jb25maWcoY29ubmVjdG9yKTsKPiAtCWRybV9tb2RlX2NvbmZpZ19yZXNldCh0 ZGV2LT5kcm0pOwo+ICsJZHJtX21vZGVfY29uZmlnX3Jlc2V0KGRybSk7Cj4gIAo+ICAJc3BpX3Nl dF9kcnZkYXRhKHNwaSwgZHJtKTsKPiAgCj4gIAlEUk1fREVCVUdfRFJJVkVSKCJTUEkgc3BlZWQ6 ICV1TUh6XG4iLCBzcGktPm1heF9zcGVlZF9oeiAvIDEwMDAwMDApOwo+ICAKPiAtCXJldHVybiBk ZXZtX3Rpbnlkcm1fcmVnaXN0ZXIodGRldik7Cj4gKwlyZXR1cm4gZGV2bV9kcm1fZGV2X3JlZ2lz dGVyX3dpdGhfZmJkZXYoZHJtLCAwKTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgcmVwYXBlcl9z aHV0ZG93bihzdHJ1Y3Qgc3BpX2RldmljZSAqc3BpKQoKCglTYW0KX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==