From: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Sean Paul <seanpaul@google.com>,
dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [v2,2/3] drm/vkms: Add basic CRTC initialization
Date: Mon, 21 Jan 2019 06:57:03 -0200 [thread overview]
Message-ID: <20190121085703.k44frdyepbpc33j7@smtp.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1901180144280.1647@nanos.tec.linutronix.de>
On 01/18, Thomas Gleixner wrote:
> Rodrigo,
>
> On Wed, 16 May 2018, Rodrigo Siqueira wrote:
>
> All files added by this commit have inconsistent license information:
>
> > --- /dev/null
> > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c
> > @@ -0,0 +1,35 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + */
>
> > --- /dev/null
> > +++ b/drivers/gpu/drm/vkms/vkms_output.c
> > @@ -0,0 +1,91 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + */
>
> > --- /dev/null
> > +++ b/drivers/gpu/drm/vkms/vkms_plane.c
> > @@ -0,0 +1,46 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + */
>
> The SPDX license identifier says GPL v2 only, but the license notice says
> GPL v2 or later. This is just wrong.
>
> Please decide which one to use and please also remove the boiler plate
> text. It is redundant.
>
> See Documentation/process/license-rules.rst
>
> Please fix ASAP, add a Fixes tag and cc stable.
Hi Thomas,
Thanks for your feedback. I'll try to send a patch for fix this issue
today.
Best Regards
Rodrigo Siqueira
> Thanks,
>
> tglx
--
Rodrigo Siqueira
https://siqueira.tech
Graduate Student
Department of Computer Science
University of São Paulo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-01-21 9:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 23:55 [PATCH v2 0/3] Expanding the basic vkms features Rodrigo Siqueira
2018-05-16 23:55 ` [PATCH v2 1/3] drm/vkms: Add mode_config initialization Rodrigo Siqueira
2018-05-16 23:56 ` [PATCH v2 2/3] drm/vkms: Add basic CRTC initialization Rodrigo Siqueira
2018-05-20 6:22 ` Haneen Mohammed
2018-05-20 14:28 ` Rodrigo Siqueira
2018-05-20 16:44 ` Haneen Mohammed
2018-05-20 18:41 ` Rodrigo Siqueira
2018-05-23 8:53 ` Daniel Vetter
2018-05-24 2:24 ` Haneen Mohammed
2019-01-18 0:51 ` [v2,2/3] " Thomas Gleixner
2019-01-21 8:57 ` Rodrigo Siqueira [this message]
2018-05-16 23:56 ` [PATCH v2 3/3] drm/vkms: Add extra information about vkms Rodrigo Siqueira
2018-05-17 19:42 ` [PATCH v2 0/3] Expanding the basic vkms features Haneen Mohammed
2018-05-23 8:55 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121085703.k44frdyepbpc33j7@smtp.gmail.com \
--to=rodrigosiqueiramelo@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=kstewart@linuxfoundation.org \
--cc=seanpaul@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).