From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 11/11] drm/fb-helper: generic: Don't take module ref for fbcon Date: Mon, 21 Jan 2019 10:05:22 +0100 Message-ID: <20190121090522.GJ3271@phenom.ffwll.local> References: <20190120114318.49199-1-noralf@tronnes.org> <20190120114318.49199-12-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id CE9A76E726 for ; Mon, 21 Jan 2019 09:05:26 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id a20so15930669edc.8 for ; Mon, 21 Jan 2019 01:05:26 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190120114318.49199-12-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: david@lechnology.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBKYW4gMjAsIDIwMTkgYXQgMTI6NDM6MThQTSArMDEwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IEl0J3Mgbm93IHNhZmUgdG8gbGV0IGZiY29uIHVuYmluZCBhdXRvbWF0aWNhbGx5 IG9uIGZiZGV2IHVucmVnaXN0ZXIuCj4gVGhlIGNyYXNoIHByb2JsZW0gd2FzIGZpeGVkIGluIGNv bW1pdCAyMTIyYjQwNTgwZGQKPiAoImZiZGV2OiBmYmNvbjogRml4IHVucmVnaXN0ZXIgY3Jhc2gg d2hlbiBtb3JlIHRoYW4gb25lIGZyYW1lYnVmZmVyIikKPiAKPiBTaWduZWQtb2ZmLWJ5OiBOb3Jh bGYgVHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2RybV9mYl9oZWxwZXIuYyB8IDYgKysrKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlv bnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fZmJfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gaW5kZXgg MzFmY2Y5NGJmODI1Li41ZDAzMjdmNjAzYmIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2RybV9mYl9oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMK PiBAQCAtMjk5OSw3ICsyOTk5LDggQEAgc3RhdGljIGludCBkcm1fZmJkZXZfZmJfb3BlbihzdHJ1 Y3QgZmJfaW5mbyAqaW5mbywgaW50IHVzZXIpCj4gIHsKPiAgCXN0cnVjdCBkcm1fZmJfaGVscGVy ICpmYl9oZWxwZXIgPSBpbmZvLT5wYXI7Cj4gIAo+IC0JaWYgKCF0cnlfbW9kdWxlX2dldChmYl9o ZWxwZXItPmRldi0+ZHJpdmVyLT5mb3BzLT5vd25lcikpCj4gKwkvKiBObyBuZWVkIHRvIHRha2Ug YSByZWYgZm9yIGZiY29uIGJlY2F1c2UgaXQgdW5iaW5kcyBvbiB1bnJlZ2lzdGVyICovCj4gKwlp ZiAodXNlciAmJiAhdHJ5X21vZHVsZV9nZXQoZmJfaGVscGVyLT5kZXYtPmRyaXZlci0+Zm9wcy0+ b3duZXIpKQoKTW9kdWxlIHJlZmNvdW50ICE9IGRyaXZlciByZWZjb3VudC4gWW91IGNhbiBhbHdh eXMgdW5iaW5kIGEgZHJpdmVyIHRocm91Z2gKdGhlIHN5c2ZzIHVuYmluZCBmaWxlLCBubyBtYXR0 ZXIgd2hldGhlciB0aGUgbW9kdWxlIGlzIHBpbm5lZCBvciBub3QuIFNvIEkKdGhpbmsgcGlubmcg dGhlIG1vZHVsZSBpcyBzdGlsbCB0aGUgcmlnaHQgdGhpbmcgdG8gZG8sIGp1c3QgdG8gYXZvaWQg cmFjZXMKYW5kIGZ1biBzdHVmZi4KCmJ0dywgSSBsb29rZWQgaW50byBtYWtpbmcgZmJkZXYgaG90 dW5wbHVnIHNhZmUgKGkuZS4gZHJtX2Rldl9lbnRlci9leGl0LApidXQgZm9yIGZiZGV2KSBvdmVy IHRoZSBob2xpZGF5cy4gRml4aW5nIHRoYXQgcHJvcGVybHkgZm9yIGZiZGV2IHVzZXJzcGFjZQpj bGllbnRzIGxvb2tzIGxpa2Ugc2VyaW91cyBhbW91bnRzIG9mIHdvcmssIGFuZCBJIHRoaW5rIGl0 J3MgaW1wb3NzaWJsZQpmb3IgZmJjb24uIE9yIGF0IGxlYXN0IEkgZGlkbid0IGNvbWUgdXAgd2l0 aCBhIHdvcmthYmxlIGlkZWEgdG8gc3ByaW5rbGUKdGhlIGRldl9lbnRlci9leGl0IHN0dWZmIGFy b3VuZC4gRm9yIHRoZSB1c2Vyc3BhY2Ugc2lkZSB0aGUgYmFzaWMKaW5mcmFzdHJ1Y3R1cmUgd2l0 aCBnZXRfZmJfaW5mbygpIGFuZCBwdXRfZmJfaW5mbygpIGlzIHRoZXJlIGFscmVhZHkuCgpDaGVl cnMsIERhbmllbAoKPiAgCQlyZXR1cm4gLUVOT0RFVjsKPiAgCj4gIAlyZXR1cm4gMDsKPiBAQCAt MzAwOSw3ICszMDEwLDggQEAgc3RhdGljIGludCBkcm1fZmJkZXZfZmJfcmVsZWFzZShzdHJ1Y3Qg ZmJfaW5mbyAqaW5mbywgaW50IHVzZXIpCj4gIHsKPiAgCXN0cnVjdCBkcm1fZmJfaGVscGVyICpm Yl9oZWxwZXIgPSBpbmZvLT5wYXI7Cj4gIAo+IC0JbW9kdWxlX3B1dChmYl9oZWxwZXItPmRldi0+ ZHJpdmVyLT5mb3BzLT5vd25lcik7Cj4gKwlpZiAodXNlcikKPiArCQltb2R1bGVfcHV0KGZiX2hl bHBlci0+ZGV2LT5kcml2ZXItPmZvcHMtPm93bmVyKTsKPiAgCj4gIAlyZXR1cm4gMDsKPiAgfQo+ IC0tIAo+IDIuMjAuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVs IENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=