From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 01/11] drm: Add devm_drm_dev_init/register Date: Tue, 22 Jan 2019 10:35:18 +0100 Message-ID: <20190122093518.GV3271@phenom.ffwll.local> References: <20190120114318.49199-1-noralf@tronnes.org> <20190120114318.49199-2-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 726E76EC23 for ; Tue, 22 Jan 2019 09:35:22 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id y56so18687448edd.11 for ; Tue, 22 Jan 2019 01:35:22 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190120114318.49199-2-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: david@lechnology.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBKYW4gMjAsIDIwMTkgYXQgMTI6NDM6MDhQTSArMDEwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IFRoaXMgYWRkcyByZXNvdXJjZSBtYW5hZ2VkIChkZXZyZXMpIHZlcnNpb25zIG9m IGRybV9kZXZfaW5pdCgpIGFuZAo+IGRybV9kZXZfcmVnaXN0ZXIoKS4KPiAKPiBBbHNvIGFkZGVk IGlzIGRldm1fZHJtX2Rldl9yZWdpc3Rlcl93aXRoX2ZiZGV2KCkgd2hpY2ggc2V0cyB1cCBnZW5l cmljCj4gZmJkZXYgZW11bGF0aW9uIGFzIHdlbGwuCj4gCj4gZGV2bV9kcm1fZGV2X3JlZ2lzdGVy KCkgaXNuJ3QgZXhwb3J0ZWQgc2luY2UgdGhlcmUgYXJlIG5vIHVzZXJzLgo+IAo+IFNpZ25lZC1v ZmYtYnk6IE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgo+IC0tLQo+ICBEb2N1 bWVudGF0aW9uL2RyaXZlci1tb2RlbC9kZXZyZXMudHh0IHwgICA0ICsKPiAgZHJpdmVycy9ncHUv ZHJtL2RybV9kcnYuYyAgICAgICAgICAgICB8IDEwNiArKysrKysrKysrKysrKysrKysrKysrKysr Kwo+ICBpbmNsdWRlL2RybS9kcm1fZHJ2LmggICAgICAgICAgICAgICAgIHwgICA2ICsrCj4gIDMg ZmlsZXMgY2hhbmdlZCwgMTE2IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1l bnRhdGlvbi9kcml2ZXItbW9kZWwvZGV2cmVzLnR4dCBiL0RvY3VtZW50YXRpb24vZHJpdmVyLW1v ZGVsL2RldnJlcy50eHQKPiBpbmRleCBiMjc3Y2FmY2U3MWUuLjZlZWJjMjhkNGMyMSAxMDA2NDQK PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RyaXZlci1tb2RlbC9kZXZyZXMudHh0Cj4gKysrIGIvRG9j dW1lbnRhdGlvbi9kcml2ZXItbW9kZWwvZGV2cmVzLnR4dAo+IEBAIC0yNTQsNiArMjU0LDEwIEBA IERNQQo+ICAgIGRtYW1fcG9vbF9jcmVhdGUoKQo+ICAgIGRtYW1fcG9vbF9kZXN0cm95KCkKPiAg Cj4gK0RSTQo+ICsgIGRldm1fZHJtX2Rldl9pbml0KCkKPiArICBkZXZtX2RybV9kZXZfcmVnaXN0 ZXJfd2l0aF9mYmRldigpCj4gKwo+ICBHUElPCj4gICAgZGV2bV9ncGlvZF9nZXQoKQo+ICAgIGRl dm1fZ3Bpb2RfZ2V0X2luZGV4KCkKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9k cnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2LmMKPiBpbmRleCAzODE1ODFiMDFkNDguLjEy MTI5NzcyYmU0NSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Rydi5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2RybV9kcnYuYwo+IEBAIC0zNiw2ICszNiw3IEBACj4gIAo+ICAj aW5jbHVkZSA8ZHJtL2RybV9jbGllbnQuaD4KPiAgI2luY2x1ZGUgPGRybS9kcm1fZHJ2Lmg+Cj4g KyNpbmNsdWRlIDxkcm0vZHJtX2ZiX2hlbHBlci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybVAuaD4K PiAgCj4gICNpbmNsdWRlICJkcm1fY3J0Y19pbnRlcm5hbC5oIgo+IEBAIC04NzEsNiArODcyLDEx MSBAQCB2b2lkIGRybV9kZXZfdW5yZWdpc3RlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICB9 Cj4gIEVYUE9SVF9TWU1CT0woZHJtX2Rldl91bnJlZ2lzdGVyKTsKPiAgCj4gK3N0YXRpYyB2b2lk IGRldm1fZHJtX2Rldl9pbml0X3JlbGVhc2Uodm9pZCAqZGF0YSkKPiArewo+ICsJZHJtX2Rldl9w dXQoZGF0YSk7Cj4gK30KPiArCj4gKy8qKgo+ICsgKiBkZXZtX2RybV9kZXZfaW5pdCAtIFJlc291 cmNlIG1hbmFnZWQgZHJtX2Rldl9pbml0KCkKPiArICogQHBhcmVudDogUGFyZW50IGRldmljZSBv YmplY3QKPiArICogQGRldjogRFJNIGRldmljZQo+ICsgKiBAZHJpdmVyOiBEUk0gZHJpdmVyCj4g KyAqCj4gKyAqIE1hbmFnZWQgZHJtX2Rldl9pbml0KCkuIFRoZSBEUk0gZGV2aWNlIGluaXRpYWxp emVkIHdpdGggdGhpcyBmdW5jdGlvbiBpcwo+ICsgKiBhdXRvbWF0aWNhbGx5IHJlbGVhc2VkIG9u IGRyaXZlciBkZXRhY2guIFlvdSBtdXN0IHN1cHBseSBhCj4gKyAqICZkcm1fZHJpdmVyLnJlbGVh c2UgY2FsbGJhY2sgdG8gY29udHJvbCB0aGUgZmluYWxpemF0aW9uIGV4cGxpY2l0bHkuCj4gKyAq Cj4gKyAqIE5vdGU6IFRoaXMgZnVuY3Rpb24gbXVzdCBiZSB1c2VkIHRvZ2V0aGVyIHdpdGgKPiAr ICogZGV2bV9kcm1fZGV2X3JlZ2lzdGVyX3dpdGhfZmJkZXYoKS4KPiArICoKPiArICogUkVUVVJO UzoKPiArICogMCBvbiBzdWNjZXNzLCBvciBlcnJvciBjb2RlIG9uIGZhaWx1cmUuCj4gKyAqLwo+ ICtpbnQgZGV2bV9kcm1fZGV2X2luaXQoc3RydWN0IGRldmljZSAqcGFyZW50LAo+ICsJCSAgICAg IHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gKwkJICAgICAgc3RydWN0IGRybV9kcml2ZXIgKmRy aXZlcikKPiArewo+ICsJaW50IHJldDsKPiArCj4gKwlpZiAoV0FSTl9PTighcGFyZW50IHx8ICFk cml2ZXItPnJlbGVhc2UpKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsKPiArCXJldCA9IGRybV9k ZXZfaW5pdChkZXYsIGRyaXZlciwgcGFyZW50KTsKPiArCWlmIChyZXQpCj4gKwkJcmV0dXJuIHJl dDsKPiArCj4gKwkvKgo+ICsJICogVGhpcyBpcyBhIHRlbXBvcmFyeSByZWxlYXNlIGFjdGlvbiB0 aGF0IGlzIHVzZWQgaWYgcHJvYmluZyBmYWlscwo+ICsJICogYmVmb3JlIGRldm1fZHJtX2Rldl9y ZWdpc3RlcigpIGlzIGNhbGxlZC4KPiArCSAqLwo+ICsJcmV0ID0gZGV2bV9hZGRfYWN0aW9uKHBh cmVudCwgZGV2bV9kcm1fZGV2X2luaXRfcmVsZWFzZSwgZGV2KTsKPiArCWlmIChyZXQpCj4gKwkJ ZGV2bV9kcm1fZGV2X2luaXRfcmVsZWFzZShkZXYpOwo+ICsKPiArCXJldHVybiByZXQ7Cj4gK30K PiArRVhQT1JUX1NZTUJPTChkZXZtX2RybV9kZXZfaW5pdCk7Cj4gKwo+ICtzdGF0aWMgdm9pZCBk ZXZtX2RybV9kZXZfcmVnaXN0ZXJfcmVsZWFzZSh2b2lkICpkYXRhKQo+ICt7Cj4gKwlkcm1fZGV2 X3VucGx1ZyhkYXRhKTsKPiArfQo+ICsKPiArc3RhdGljIGludCBkZXZtX2RybV9kZXZfcmVnaXN0 ZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiArewo+ICsJaW50IHJldDsKPiArCj4gKwlyZXQg PSBkcm1fZGV2X3JlZ2lzdGVyKGRldiwgMCk7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7 Cj4gKwo+ICsJLyoKPiArCSAqIFRoaXMgaGFzIG5vdyBzZXJ2ZWQgaXQncyBwdXJwb3NlLCByZW1v dmUgaXQgdG8gbm90IG1lc3MgdXAgcmVmCj4gKwkgKiBjb3VudGluZy4KPiArCSAqLwo+ICsJZGV2 bV9yZW1vdmVfYWN0aW9uKGRldi0+ZGV2LCBkZXZtX2RybV9kZXZfaW5pdF9yZWxlYXNlLCBkZXYp Owo+ICsKPiArCXJldCA9IGRldm1fYWRkX2FjdGlvbihkZXYtPmRldiwgZGV2bV9kcm1fZGV2X3Jl Z2lzdGVyX3JlbGVhc2UsIGRldik7CgpJZiB0aGlzIGZhaWxzIEkgdGhpbmsgdGhlIGNsZWFudXAg d291bGQgZ28gd3JvbmcuIEkgdGhpbmsgc2ltcGxlciBpZiB5b3UKbmV2ZXIgcmVtb3ZlIHRoZSBk ZXZtIGFjdGlvbiBmcm9tIGRldl9pbml0LCBhbmQganVzdCBncmFiIGFuIGFkZGl0aW9uYWwKZHJt X2Rldl9nZXQoKSByZWZlcmVuY2UgaGVyZSBmb3IgZHJtX2Rldl91bnBsdWcuIFdlIGFsc28gbmVl ZCB0aGF0IGZvcgpjb3JyZWN0IG9uaW9uIGNsZWFudXAgaW4sIHNvIHRoYXQgZm9yIGEgbm9ybWFs IHVuYmluZC9kcml2ZXIgdW5sb2FkIHdlIGNhbgpzdGlsbCBkbzoKCjEuIGRybV9kZXZfdW5yZWdp c3RlcigpIHRocm91Z2ggZHJtX2Rldl91bnBsdWcoKQoKMi4gZHJtX2F0b21pY19oZWxwZXJfc2h1 dGRvd24oKSBhbmQgc2ltaWxhciB0aGluZ3MgKG5lZWRzIHRoZSBkcm1fZGV2aWNlCnRvIHN0aWxs IGJlIGFyb3VuZCkKCjMuIGRybV9kZXZfcHV0KCkKCkkgdGhpbmsgdGhhdCdsbCBnaXZlIHVzIHRo ZSBjbGVhbmVyIG9uaW9uIHVud3JhcHBpbmcgaW4gdGhlCnVubG9hZC9ob3R1bnBsdWcvZXJyb3Ig Y2FzZSBjbGVhbnVwIGNhc2VzLgoKQWxzbywgdGhpcyBhbGxvd3MgZHJpdmVycyB0byBzdGFydCB1 c2luZyBkZXZtX2RybV9kZXZfaW5pdCB3aXRob3V0IGhhdmluZwp0byB1c2UgZGV2bV9kcm1fZGV2 X3JlZ2lzdGVyKCksIHdoaWNoIHRoZXkgaGF2ZSB0byBkbyBpZiB0aGV5IHN0aWxsIGhhdmUKbm9u LWRldm0taWZpZWQgdGhpbmdzIGluIHN0ZXAgMiBhYm92ZSBpbiB0aGVyZSB1bmJpbmQgY2FsbGJh Y2suCi1EYW5pZWwKCj4gKwlpZiAocmV0KQo+ICsJCWRldm1fZHJtX2Rldl9yZWdpc3Rlcl9yZWxl YXNlKGRldik7Cj4gKwo+ICsJcmV0dXJuIHJldDsKPiArfQo+ICsKPiArLyoqCj4gKyAqIGRldm1f ZHJtX2Rldl9yZWdpc3Rlcl93aXRoX2ZiZGV2IC0gUmVzb3VyY2UgbWFuYWdlZCBkcm1fZGV2X3Jl Z2lzdGVyKCkKPiArICogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbmNsdWRp bmcgZ2VuZXJpYyBmYmRldiBlbXVsYXRpb24KPiArICogQGRldjogRFJNIGRldmljZSB0byByZWdp c3Rlcgo+ICsgKiBAZmJkZXZfYnBwOiBQcmVmZXJyZWQgYml0cyBwZXIgcGl4ZWwgZm9yIGZiZGV2 IChvcHRpb25hbCkKPiArICoKPiArICogTWFuYWdlZCBkcm1fZGV2X3JlZ2lzdGVyKCkgdGhhdCBh bHNvIGNhbGxzIGRybV9mYmRldl9nZW5lcmljX3NldHVwKCkuCj4gKyAqIFRoZSBEUk0gZGV2aWNl IHJlZ2lzdGVyZWQgd2l0aCB0aGlzIGZ1bmN0aW9uIGlzIGF1dG9tYXRpY2FsbHkgdW5yZWdpc3Rl cmVkIG9uCj4gKyAqIGRyaXZlciBkZXRhY2ggdXNpbmcgZHJtX2Rldl91bnBsdWcoKS4KPiArICoK PiArICogTm90ZTogVGhpcyBmdW5jdGlvbiBtdXN0IGJlIHVzZWQgdG9nZXRoZXIgd2l0aCBkZXZt X2RybV9kZXZfaW5pdCgpLgo+ICsgKgo+ICsgKiBGb3IgdGVzdGluZyBkcml2ZXIgZGV0YWNoIGNh biBiZSB0cmlnZ2VyZWQgbWFudWFsbHkgYnkgd3JpdGluZyB0byB0aGUgZHJpdmVyCj4gKyAqICd1 bmJpbmQnIGZpbGUuCj4gKyAqCj4gKyAqIFJFVFVSTlM6Cj4gKyAqIDAgb24gc3VjY2VzcywgbmVn YXRpdmUgZXJyb3IgY29kZSBvbiBmYWlsdXJlLgo+ICsgKi8KPiAraW50IGRldm1fZHJtX2Rldl9y ZWdpc3Rlcl93aXRoX2ZiZGV2KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gKwkJCQkgICAgIHVu c2lnbmVkIGludCBmYmRldl9icHApCj4gK3sKPiArCWludCByZXQ7Cj4gKwo+ICsJcmV0ID0gZGV2 bV9kcm1fZGV2X3JlZ2lzdGVyKGRldik7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4g Kwo+ICsJZHJtX2ZiZGV2X2dlbmVyaWNfc2V0dXAoZGV2LCBmYmRldl9icHApOwo+ICsKPiArCXJl dHVybiAwOwo+ICt9Cj4gK0VYUE9SVF9TWU1CT0woZGV2bV9kcm1fZGV2X3JlZ2lzdGVyX3dpdGhf ZmJkZXYpOwo+ICsKPiAgLyoqCj4gICAqIGRybV9kZXZfc2V0X3VuaXF1ZSAtIFNldCB0aGUgdW5p cXVlIG5hbWUgb2YgYSBEUk0gZGV2aWNlCj4gICAqIEBkZXY6IGRldmljZSBvZiB3aGljaCB0byBz ZXQgdGhlIHVuaXF1ZSBuYW1lCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9kcnYuaCBi L2luY2x1ZGUvZHJtL2RybV9kcnYuaAo+IGluZGV4IDM1YWYyM2Y1ZmEwZC4uYzNmMDQ3N2YyZTdm IDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9kcnYuaAo+ICsrKyBiL2luY2x1ZGUvZHJt L2RybV9kcnYuaAo+IEBAIC02MjgsNiArNjI4LDEyIEBAIHN0cnVjdCBkcm1fZGV2aWNlICpkcm1f ZGV2X2FsbG9jKHN0cnVjdCBkcm1fZHJpdmVyICpkcml2ZXIsCj4gIGludCBkcm1fZGV2X3JlZ2lz dGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGxvbmcgZmxhZ3MpOwo+ICB2b2lk IGRybV9kZXZfdW5yZWdpc3RlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgCj4gK2ludCBk ZXZtX2RybV9kZXZfaW5pdChzdHJ1Y3QgZGV2aWNlICpwYXJlbnQsCj4gKwkJICAgICAgc3RydWN0 IGRybV9kZXZpY2UgKmRldiwKPiArCQkgICAgICBzdHJ1Y3QgZHJtX2RyaXZlciAqZHJpdmVyKTsK PiAraW50IGRldm1fZHJtX2Rldl9yZWdpc3Rlcl93aXRoX2ZiZGV2KHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsCj4gKwkJCQkgICAgIHVuc2lnbmVkIGludCBmYmRldl9icHApOwo+ICsKPiAgdm9pZCBk cm1fZGV2X2dldChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgdm9pZCBkcm1fZGV2X3B1dChz dHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgdm9pZCBkcm1fcHV0X2RldihzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2KTsKPiAtLSAKPiAyLjIwLjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK