From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v5 07/17] drm/sun4i: sun6i_mipi_dsi: Refactor vertical video start delay Date: Tue, 22 Jan 2019 12:14:08 +0100 Message-ID: <20190122111408.4zlhecsxywulvrfy@flea> References: <20181211164900.wfmkmbrbj3nmlb3h@flea> <20190107141158.zaimizk4rlqa6xli@flea> <20190108085829.clianbtjovu3oieq@flea> <20190112164319.whr7gwvl4oux5svz@flea> <20190116191756.ajzzaga43srk77dk@flea> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1896234736==" Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id BC63B6E2F9 for ; Tue, 22 Jan 2019 11:14:19 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jagan Teki Cc: Stephen Boyd , Michael Turquette , linux-sunxi , linux-kernel , dri-devel , Chen-Yu Tsai , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-clk , linux-arm-kernel List-Id: dri-devel@lists.freedesktop.org --===============1896234736== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lpmn2jm2w26y3xo2" Content-Disposition: inline --lpmn2jm2w26y3xo2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 17, 2019 at 10:02:12AM +0530, Jagan Teki wrote: > On Thu, Jan 17, 2019 at 12:48 AM Maxime Ripard > wrote: > > > > On Sun, Jan 13, 2019 at 01:07:41AM +0530, Jagan Teki wrote: > > > > > > > > Again, I cannot help you without the datasheet for the pane= ls you're > > > > > > > > trying to submit. > > > > > > > > > > > > > > The panel bound with Sitronix ST7701 IC > > > > > > > http://www.startek-lcd.com/res/starteklcd/pdres/201705/201705= 12144242904.pdf > > > > > > > > > > > > It's the controller, not the panel > > > > > > > > > > As I said before, the datasheet of that panel doesn't have any > > > > > information except electrical characteristics and used IC which is > > > > > ST7701. > > > > > > > > > > I have one more panel, which is from Bananapi, S070WV20-CT16 ICN6= 21 > > > > > please find the attachment for the same. > > > > > > > > > > Here is some more details of the same. > > > > > > > > > > https://github.com/yesnoandor/x300/blob/master/kernel/arch/arm/bo= ot/dts/erobbing/x300/x300.dtsi#L81 > > > > > https://github.com/wxzed/Raspberry_5MIPI_Display/blob/master/I2C_= Slave/USER/main.c#L15 > > > > > > > > > > https://github.com/eliot-shao/qcom/blob/master/icn6211_cxn0102/ke= rnel/drivers/video/msm/mdss/mdss_i2c_interface.c#L152 > > > > > matches timings for > > > > > https://github.com/eliot-shao/qcom/blob/master/icn6211_cxn0102/ke= rnel/arch/arm/boot/dts/qcom/dsi-mipi-2-rgb_1280p_video.dtsi#L20 > > > > > > > > > > https://github.com/zestroly/micromat/blob/master/test/raspberry/I= CN6211.cpp#L169 > > > > > > > > Where did you get the timings from then? > > > > > > You mean drm_mode timings, the same panel with RGB available in > > > panel-simple[1], and dsi driver in Mailing list[2] and actual DSI > > > sequence commands from BSP[3] > > > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it/commit/drivers/gpu/drm/panel/panel-simple.c?id=3D7ad8b41cd8f5c2842646d01= cdd576663caee04a7 > > > [2] https://patchwork.kernel.org/patch/10680331/ > > > [3] https://github.com/BPI-SINOVOIP/BPI-M64-bsp/blob/master/linux-sun= xi/drivers/video/sunxi/disp2/disp/lcd/S070WV20_MIPI_RGB.c > > > > So you had no reliable source for the timings then? How do you know if > > all your patches that are timing related are right then? >=20 > I don't understand your point, or may be I confused with many links > that I attached in previous mail. >=20 > 1. Patch for same panel timings are already in Mainline that was > tested on one of the board. [1] > 2. Driver from AW, released bsp from BPI-M64-bsp [3] >=20 > Do you think the above two points are not valid sources? I'm saying that the only valid source is the datasheet or a DSI analyzer. Maxmie --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --lpmn2jm2w26y3xo2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXEb7AAAKCRDj7w1vZxhR xS0fAQDHNLlvyCOc0d7sfDgkpCCnV2uB18j9NbgTDPWP1QmK1AD/XDTH92oI17hs 5fb6v71atKI/c3In5qsOSLUKIicisAQ= =fPrs -----END PGP SIGNATURE----- --lpmn2jm2w26y3xo2-- --===============1896234736== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1896234736==--