From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Subject: Re: [PATCH libdrm 1/2] xf86drm: fallback to MODALIAS for OF less platform devices Date: Wed, 23 Jan 2019 11:04:24 +0000 Message-ID: <20190123110424.pted67xfp6nlw7qz@intel.com> References: <20190123104518.7332-1-emil.l.velikov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id AAC6C6EEE8 for ; Wed, 23 Jan 2019 11:04:26 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190123104518.7332-1-emil.l.velikov@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkbmVzZGF5LCAyMDE5LTAxLTIzIDEwOjQ1OjE3ICswMDAwLCBFbWlsIFZlbGlrb3Ygd3Jv dGU6Cj4gRnJvbTogRW1pbCBWZWxpa292IDxlbWlsLnZlbGlrb3ZAY29sbGFib3JhLmNvbT4KPiAK PiBTb21lIGRldmljZXMgY2FuIGxhY2sgT0YgZGF0YSBvciBpdCBtYXkgbm90IGJlIGF2YWlsYWJs ZSBpbiB0aGUgdWV2ZW50Cj4gZmlsZS4gRmFsbGJhY2sgdG8gdGhlIE1PREFMSUFTIGRhdGEgaW4g dGhvc2UgY2FzZXMuCj4gCj4gV2Ugc3RyaXAgYW55IGxlYWRpbmcgIk1PREFMSUFTPS4qOiIgdGh1 cyB0aGUgcmVzdWx0aW5nIGluZm9ybWF0aW9uIGlzCj4gY29tcGF0aWJsZSB3aXRoIGV4aXN0aW5n IGNvZGUgaW4gTWVzYS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBFbWlsIFZlbGlrb3YgPGVtaWwudmVs aWtvdkBjb2xsYWJvcmEuY29tPgo+IC0tLQo+ICB4Zjg2ZHJtLmMgfCA1NSArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFu Z2VkLCA0MiBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv eGY4NmRybS5jIGIveGY4NmRybS5jCj4gaW5kZXggMTBkZjY4MmIuLjM3NDczNGViIDEwMDY0NAo+ IC0tLSBhL3hmODZkcm0uYwo+ICsrKyBiL3hmODZkcm0uYwo+IEBAIC0zNTExLDE1ICszNTExLDI4 IEBAIGZyZWVfZGV2aWNlOgo+ICBzdGF0aWMgaW50IGRybVBhcnNlUGxhdGZvcm1CdXNJbmZvKGlu dCBtYWosIGludCBtaW4sIGRybVBsYXRmb3JtQnVzSW5mb1B0ciBpbmZvKQo+ICB7Cj4gICNpZmRl ZiBfX2xpbnV4X18KPiAtICAgIGNoYXIgcGF0aFtQQVRIX01BWCArIDFdLCAqbmFtZTsKPiArICAg IGNoYXIgcGF0aFtQQVRIX01BWCArIDFdLCAqbmFtZSwgKmZvbzsKCkkgYXNzdW1lIHlvdSBkaWRu J3QgbWVhbiB0byBzZW5kIHRoaXMgcGF0Y2ggeWV0PyA6UAoKPiAgCj4gICAgICBzbnByaW50Zihw YXRoLCBzaXplb2YocGF0aCksICIvc3lzL2Rldi9jaGFyLyVkOiVkL2RldmljZSIsIG1haiwgbWlu KTsKPiAgCj4gICAgICBuYW1lID0gc3lzZnNfdWV2ZW50X2dldChwYXRoLCAiT0ZfRlVMTE5BTUUi KTsKPiAtICAgIGlmICghbmFtZSkKPiAtICAgICAgICByZXR1cm4gLUVOT0VOVDsKPiArICAgIGZv byA9IG5hbWU7Cj4gKyAgICBpZiAoIW5hbWUpIHsKPiArICAgICAgICAvKiBJZiB0aGUgZGV2aWNl IGxhY2tzIE9GIGRhdGEsIHBpY2sgdGhlIE1PREFMSUFTIGluZm8gKi8KPiArICAgICAgICBuYW1l ID0gc3lzZnNfdWV2ZW50X2dldChwYXRoLCAiTU9EQUxJQVMiKTsKPiArICAgICAgICBpZiAoIW5h bWUpCj4gKyAgICAgICAgICAgIHJldHVybiAtRU5PRU5UOwo+ICsKPiArICAgICAgICAvKiAuLiBh bmQgc3RyaXAgdGhlIE1PREFMSUFTPVtwbGF0Zm9ybSx1c2IuLi5dOiBwYXJ0LiAqLwo+ICsgICAg ICAgIGZvbyA9IHN0cnJjaHIobmFtZSwgJzonKTsKPiArICAgICAgICBpZiAoIWZvbykgewo+ICsg ICAgICAgICAgICBmcmVlKG5hbWUpOwo+ICsgICAgICAgICAgICByZXR1cm4gLUVOT0VOVDsKPiAr ICAgICAgICB9Cj4gKyAgICAgICAgZm9vKys7Cj4gKyAgICB9Cj4gIAo+IC0gICAgc3RybmNweShp bmZvLT5mdWxsbmFtZSwgbmFtZSwgRFJNX1BMQVRGT1JNX0RFVklDRV9OQU1FX0xFTik7Cj4gKyAg ICBzdHJuY3B5KGluZm8tPmZ1bGxuYW1lLCBmb28sIERSTV9QTEFURk9STV9ERVZJQ0VfTkFNRV9M RU4pOwo+ICAgICAgaW5mby0+ZnVsbG5hbWVbRFJNX1BMQVRGT1JNX0RFVklDRV9OQU1FX0xFTiAt IDFdID0gJ1wwJzsKPiAgICAgIGZyZWUobmFtZSk7Cj4gIAo+IEBAIC0zNTM0LDE4ICszNTQ3LDIw IEBAIHN0YXRpYyBpbnQgZHJtUGFyc2VQbGF0Zm9ybURldmljZUluZm8oaW50IG1haiwgaW50IG1p biwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkcm1QbGF0Zm9ybURl dmljZUluZm9QdHIgaW5mbykKPiAgewo+ICAjaWZkZWYgX19saW51eF9fCj4gLSAgICBjaGFyIHBh dGhbUEFUSF9NQVggKyAxXSwgKnZhbHVlOwo+ICsgICAgY2hhciBwYXRoW1BBVEhfTUFYICsgMV0s ICp2YWx1ZSwgKmZvbzsKPiAgICAgIHVuc2lnbmVkIGludCBjb3VudCwgaTsKPiAgICAgIGludCBl cnI7Cj4gIAo+ICAgICAgc25wcmludGYocGF0aCwgc2l6ZW9mKHBhdGgpLCAiL3N5cy9kZXYvY2hh ci8lZDolZC9kZXZpY2UiLCBtYWosIG1pbik7Cj4gIAo+ICAgICAgdmFsdWUgPSBzeXNmc191ZXZl bnRfZ2V0KHBhdGgsICJPRl9DT01QQVRJQkxFX04iKTsKPiAtICAgIGlmICghdmFsdWUpCj4gLSAg ICAgICAgcmV0dXJuIC1FTk9FTlQ7Cj4gLQo+IC0gICAgc3NjYW5mKHZhbHVlLCAiJXUiLCAmY291 bnQpOwo+IC0gICAgZnJlZSh2YWx1ZSk7Cj4gKyAgICBpZiAodmFsdWUpIHsKPiArICAgICAgICBz c2NhbmYodmFsdWUsICIldSIsICZjb3VudCk7Cj4gKyAgICAgICAgZnJlZSh2YWx1ZSk7Cj4gKyAg ICB9IGVsc2Ugewo+ICsgICAgICAgIC8qIEFzc3VtZSBvbmUgZW50cnkgaWYgdGhlIGRldmljZSBs YWNrIE9GIGRhdGEgKi8KPiArICAgICAgICBjb3VudCA9IDE7Cj4gKyAgICB9Cj4gIAo+ICAgICAg aW5mby0+Y29tcGF0aWJsZSA9IGNhbGxvYyhjb3VudCArIDEsIHNpemVvZigqaW5mby0+Y29tcGF0 aWJsZSkpOwo+ICAgICAgaWYgKCFpbmZvLT5jb21wYXRpYmxlKQo+IEBAIC0zNTUzLDEyICszNTY4 LDI2IEBAIHN0YXRpYyBpbnQgZHJtUGFyc2VQbGF0Zm9ybURldmljZUluZm8oaW50IG1haiwgaW50 IG1pbiwKPiAgCj4gICAgICBmb3IgKGkgPSAwOyBpIDwgY291bnQ7IGkrKykgewo+ICAgICAgICAg IHZhbHVlID0gc3lzZnNfdWV2ZW50X2dldChwYXRoLCAiT0ZfQ09NUEFUSUJMRV8ldSIsIGkpOwo+ ICsgICAgICAgIGZvbyA9IHZhbHVlOwo+ICAgICAgICAgIGlmICghdmFsdWUpIHsKPiAtICAgICAg ICAgICAgZXJyID0gLUVOT0VOVDsKPiAtICAgICAgICAgICAgZ290byBmcmVlOwo+ICsgICAgICAg ICAgICAvKiBJZiB0aGUgZGV2aWNlIGxhY2tzIE9GIGRhdGEsIHBpY2sgdGhlIE1PREFMSUFTIGlu Zm8gKi8KPiArICAgICAgICAgICAgdmFsdWUgPSBzeXNmc191ZXZlbnRfZ2V0KHBhdGgsICJNT0RB TElBUyIpOwo+ICsgICAgICAgICAgICBpZiAoIXZhbHVlKSB7Cj4gKyAgICAgICAgICAgICAgICBl cnIgPSAtRU5PRU5UOwo+ICsgICAgICAgICAgICAgICAgZ290byBmcmVlOwo+ICsgICAgICAgICAg ICB9Cj4gKwo+ICsgICAgICAgICAgICAvKiAuLiBhbmQgc3RyaXAgdGhlIE1PREFMSUFTPVtwbGF0 Zm9ybSx1c2IuLi5dOiBwYXJ0LiAqLwo+ICsgICAgICAgICAgICBmb28gPSBzdHJyY2hyKHZhbHVl LCAnOicpOwo+ICsgICAgICAgICAgICBpZiAoIWZvbykgewo+ICsgICAgICAgICAgICAgICAgZnJl ZSh2YWx1ZSk7Cj4gKyAgICAgICAgICAgICAgICByZXR1cm4gLUVOT0VOVDsKPiArICAgICAgICAg ICAgfQo+ICsgICAgICAgICAgICBmb28gPSBzdHJkdXAoZm9vICsgMSk7Cj4gKyAgICAgICAgICAg IGZyZWUodmFsdWUpOwo+ICAgICAgICAgIH0KPiAgCj4gLSAgICAgICAgaW5mby0+Y29tcGF0aWJs ZVtpXSA9IHZhbHVlOwo+ICsgICAgICAgIGluZm8tPmNvbXBhdGlibGVbaV0gPSBmb287Cj4gICAg ICB9Cj4gIAo+ICAgICAgcmV0dXJuIDA7Cj4gLS0gCj4gMi4yMC4xCj4gCj4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBs aXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=