From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/4] drm/imx: only send commit done event when all state has been applied Date: Wed, 23 Jan 2019 14:04:07 +0100 Message-ID: <20190123130407.GO3271@phenom.ffwll.local> References: <20180914165917.8464-1-l.stach@pengutronix.de> <20180914165917.8464-4-l.stach@pengutronix.de> <1538752273.3545.36.camel@pengutronix.de> <1548243302.3904.10.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 802FC6EF2B for ; Wed, 23 Jan 2019 13:04:12 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id g22so1625486edr.7 for ; Wed, 23 Jan 2019 05:04:12 -0800 (PST) Content-Disposition: inline In-Reply-To: <1548243302.3904.10.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philipp Zabel Cc: patchwork-lst@pengutronix.de, kernel@pengutronix.de, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKYW4gMjMsIDIwMTkgYXQgMTI6MzU6MDJQTSArMDEwMCwgUGhpbGlwcCBaYWJlbCB3 cm90ZToKPiBPbiBGcmksIDIwMTgtMTAtMDUgYXQgMTc6MTEgKzAyMDAsIFBoaWxpcHAgWmFiZWwg d3JvdGU6Cj4gPiBPbiBGcmksIDIwMTgtMDktMTQgYXQgMTg6NTkgKzAyMDAsIEx1Y2FzIFN0YWNo IHdyb3RlOgo+ID4gPiBDdXJyZW50bHkgdGhlcmUgaXMgYSBzbWFsbCByYWNlIHdpbmRvdyB3aGVy ZSB3ZSBjb3VsZCBtYW5hZ2UgdG8gYXJtIHRoZQo+ID4gPiB2YmxhbmsgZXZlbnQgZnJvbSBhdG9t aWMgZmx1c2gsIGJ1dCBwcm9ncmFtbWluZyB0aGUgaGFyZHdhcmUgd2FzIHRvbyBjbG9zZQo+ID4g PiB0byB0aGUgZnJhbWUgZW5kLCBzbyB0aGUgaGFyZHdhcmUgd2lsbCBvbmx5IGFwcGx5IHRoZSBj dXJyZW50IHN0YXRlIG9uIHRoZQo+ID4gPiBuZXh0IHZibGFuay4gSW4gdGhpcyBjYXNlIHdlIHdp bGwgc2VuZCBvdXQgdGhlIGNvbW1pdCBkb25lIGV2ZW50IHRvbyBlYXJseQo+ID4gPiBjYXVzaW5n IHVzZXJzcGFjZSB0byByZXVzZSBmcmFtZWJ1ZmZlcyB0aGF0IGFyZSBzdGlsbCBpbiB1c2UuCj4g PiA+IAo+ID4gPiBJbnN0ZWFkIG9mIHVzaW5nIHRoZSBldmVudCBhcm1pbmcgbWVjaG5pc20sIGp1 c3QgcmVtZW1iZXIgdGhlIHBlbmRpbmcgZXZlbnQKPiA+ID4gYW5kIHNlbmQgaXQgZnJvbSB0aGUg dmJsYW5rIElSUSBoYW5kbGVyLCBvbmNlIHdlIGFyZSBzdXJlIHRoYXQgYWxsIHN0YXRlCj4gPiA+ IGhhcyBiZWVuIGFwcGxpZWQgc3VjZXNzZnVsbHkuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5 OiBMdWNhcyBTdGFjaCA8bC5zdGFjaEBwZW5ndXRyb25peC5kZT4KPiA+ID4gLS0tCj4gPiA+ICBk cml2ZXJzL2dwdS9kcm0vaW14L2lwdXYzLWNydGMuYyB8IDMyICsrKysrKysrKysrKysrKysrKysr KysrKysrKystLS0tCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgNCBk ZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaW14 L2lwdXYzLWNydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pbXgvaXB1djMtY3J0Yy5jCj4gPiA+IGlu ZGV4IDdkNGI3MTBiODM3YS4uYjBjOTU1NjVhMjhkIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaW14L2lwdXYzLWNydGMuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaW14 L2lwdXYzLWNydGMuYwo+ID4gPiBAQCAtNDIsNiArNDIsNyBAQCBzdHJ1Y3QgaXB1X2NydGMgewo+ ID4gPiAgCXN0cnVjdCBpcHVfZGMJCSpkYzsKPiA+ID4gIAlzdHJ1Y3QgaXB1X2RpCQkqZGk7Cj4g PiA+ICAJaW50CQkJaXJxOwo+ID4gPiArCXN0cnVjdCBkcm1fcGVuZGluZ192YmxhbmtfZXZlbnQg KmV2ZW50Owo+ID4gPiAgfTsKPiA+ID4gIAo+ID4gPiAgc3RhdGljIGlubGluZSBzdHJ1Y3QgaXB1 X2NydGMgKnRvX2lwdV9jcnRjKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiA+ID4gQEAgLTE4MSw4 ICsxODIsMzEgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fY3J0Y19mdW5jcyBpcHVfY3J0Y19m dW5jcyA9IHsKPiA+ID4gIHN0YXRpYyBpcnFyZXR1cm5fdCBpcHVfaXJxX2hhbmRsZXIoaW50IGly cSwgdm9pZCAqZGV2X2lkKQo+ID4gPiAgewo+ID4gPiAgCXN0cnVjdCBpcHVfY3J0YyAqaXB1X2Ny dGMgPSBkZXZfaWQ7Cj4gPiA+ICsJc3RydWN0IGRybV9jcnRjICpjcnRjID0gJmlwdV9jcnRjLT5i YXNlOwo+ID4gPiArCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4gPiA+ICsJaW50IGk7Cj4gPiA+ICsK PiA+ID4gKwlkcm1fY3J0Y19oYW5kbGVfdmJsYW5rKGNydGMpOwo+ID4gPiArCj4gPiA+ICsJaWYg KGlwdV9jcnRjLT5ldmVudCkgewo+ID4gPiArCQlmb3IgKGkgPSAwOyBpIDwgQVJSQVlfU0laRShp cHVfY3J0Yy0+cGxhbmUpOyBpKyspIHsKPiA+ID4gKwkJCXN0cnVjdCBpcHVfcGxhbmUgKnBsYW5l ID0gaXB1X2NydGMtPnBsYW5lW2ldOwo+ID4gPiArCj4gPiA+ICsJCQlpZiAoIXBsYW5lKQo+ID4g PiArCQkJCWNvbnRpbnVlOwo+ID4gPiArCj4gPiA+ICsJCQlpZiAoIWlwdV9wbGFuZV9hdG9taWNf dXBkYXRlX2RvbmUoJnBsYW5lLT5iYXNlKSkKPiA+IAo+ID4gCQkJaWYgKGlwdV9wbGFuZV9hdG9t aWNfdXBkYXRlX3BlbmRpbmcoJnBsYW5lLT5iYXNlKSkKPiA+IAo+ID4gPiArCQkJCWJyZWFrOwo+ ID4gPiArCQl9Cj4gPiA+ICAKPiA+ID4gLQlkcm1fY3J0Y19oYW5kbGVfdmJsYW5rKCZpcHVfY3J0 Yy0+YmFzZSk7Cj4gPiA+ICsJCWlmIChpID09IEFSUkFZX1NJWkUoaXB1X2NydGMtPnBsYW5lKSkg ewo+ID4gPiArCQkJc3Bpbl9sb2NrX2lycXNhdmUoJmNydGMtPmRldi0+ZXZlbnRfbG9jaywgZmxh Z3MpOwo+ID4gPiArCQkJZHJtX2NydGNfc2VuZF92YmxhbmtfZXZlbnQoY3J0YywgaXB1X2NydGMt PmV2ZW50KTsKPiA+ID4gKwkJCWlwdV9jcnRjLT5ldmVudCA9IE5VTEw7Cj4gPiAKPiA+IFRoZXNl IHR3byBoYXBwZW4gdW5kZXIgdGhlIGV2ZW50IHNwaW5sb2NrLCBidXQgd2hlcmUgZXZlbnQgaXMg c2V0IGluCj4gPiBpcHVfY3J0Y19hdG9taWNfZmx1c2gsIHRoZSBsb2NraW5nIGlzIHJlbW92ZWQu Cj4gPiAKPiA+ID4gKwkJCWRybV9jcnRjX3ZibGFua19wdXQoY3J0Yyk7Cj4gPiA+ICsJCQlzcGlu X3VubG9ja19pcnFyZXN0b3JlKCZjcnRjLT5kZXYtPmV2ZW50X2xvY2ssIGZsYWdzKTsKPiA+ID4g KwkJfQo+ID4gPiArCX0KPiA+ID4gIAo+ID4gPiAgCXJldHVybiBJUlFfSEFORExFRDsKPiA+ID4g IH0KPiA+ID4gQEAgLTIyOSwxMyArMjUzLDEzIEBAIHN0YXRpYyB2b2lkIGlwdV9jcnRjX2F0b21p Y19iZWdpbihzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gPiA+ICBzdGF0aWMgdm9pZCBpcHVfY3J0 Y19hdG9taWNfZmx1c2goc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ID4gPiAgCQkJCSAgc3RydWN0 IGRybV9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSkKPiA+ID4gIHsKPiA+ID4gLQlzcGluX2xv Y2tfaXJxKCZjcnRjLT5kZXYtPmV2ZW50X2xvY2spOwo+ID4gPiArCXN0cnVjdCBpcHVfY3J0YyAq aXB1X2NydGMgPSB0b19pcHVfY3J0YyhjcnRjKTsKPiA+ID4gKwo+ID4gPiAgCWlmIChjcnRjLT5z dGF0ZS0+ZXZlbnQpIHsKPiA+ID4gIAkJV0FSTl9PTihkcm1fY3J0Y192YmxhbmtfZ2V0KGNydGMp KTsKPiA+ID4gLQkJZHJtX2NydGNfYXJtX3ZibGFua19ldmVudChjcnRjLCBjcnRjLT5zdGF0ZS0+ ZXZlbnQpOwo+ID4gPiArCQlpcHVfY3J0Yy0+ZXZlbnQgPSBjcnRjLT5zdGF0ZS0+ZXZlbnQ7Cj4g PiAKPiA+IFdlIGFzc3VtZSBoZXJlIHRoYXQgaXB1X2NydGMtPmV2ZW50IGlzIE5VTEwgYW5kIHRo ZSBpcnEgaGFuZGxlciBpcyBuZXZlcgo+ID4gcnVubmluZyBhdCB0aGUgc2FtZSB0aW1lLCBvdGhl cndpc2Ugd2Ugd291bGQgZHJvcCBhbiBldmVudC4gVGhpcyBpcyBub24tCj4gPiBvYnZpb3VzIHRv IG1lLCBhbmQgSSB0aGluayBpdCB3YXJyYW50cyBhIGNvbW1lbnQuCj4gPiAKPiA+IE15IHVuZGVy c3RhbmRpbmcgaXMgdGhlIGZvbGxvd2luZzoKPiA+IAo+ID4gLSBJdCBpcyB2aXJ0dWFsbHkgaW1w b3NzaWJsZSBmb3IgYXRvbWljX2ZsdXNoIHRvIHJhY2UgYWdhaW5zdCBhIGRlbGF5ZWQKPiA+ICAg cHJldmlvdXMgaXB1X2lycV9oYW5kbGVyIGJlY2F1c2UgdGhlIHByZXZpb3VzIGNvbW1pdCdzIGNv bW1pdF90YWlsCj4gPiAgIHdvdWxkIHN0aWxsIGJlIHdhaXRpbmcgZm9yIHRoZSB2YmxhbmsgZXZl bnQgdG8gcmVsZWFzZSBpdCBmcm9tCj4gPiAgIGRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2Zs aXBfZG9uZS4KPiA+IAo+ID4gICBIb3dldmVyLCBpZiB0aGUgbGFzdCBjb21taXQncyB0YWlsIGZp bmlzaGVzwqBhZnRlciB0aGUgaXJxX2hhbmRsZXIKPiA+ICAgY2FsbHMgZHJtX2NydGNfc2VuZF92 YmxhbmtfZXZlbnQoKSwgYW5kIHRoZcKgbmV3IGNvbW1pdCBpcyBpc3N1ZWQsIGFuZAo+ID4gICBp dHMgdGFpbCB3b3JrIHNjaGVkdWxlZCwgYWxsIGJlZm9yZSB0aGUgbmV4dCBsaW5lIGluIHRoZSBp cnFfaGFuZGxlciwKPiA+ICAgaXB1X2NydGMtPmV2ZW50ID0gTlVMTCwgdGhlbiB0aGUgbmV3IGNv bW1pdCdzIHRhaWwgY291bGQgY2FsbAo+ID4gICBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfcGxh bmVzIGFuZCB0aGVyZWZvcmUgaXB1X2NydGNfYXRvbWljX2ZsdXNoCj4gPiAgIGFuZCBpcHVfY3J0 Yy0+ZXZlbnQgd291bGQgYmUgb3ZlcndyaXR0ZW4uCj4gPiAKPiA+IC0gSXQgaXMgdW5wcm9ibGVt YXRpYyBmb3IgYSBkZWxheWVkIGF0b21pY19mbHVzaCB0byByYWNlIGFnYWluc3QgdGhlCj4gPiAg IG5leHQgaXB1X2lycV9oYW5kbGVyIGJlY2F1c2UgaXB1X2NydGMtPmV2ZW50IHdpbGwganVzdCBu b3QgYmUgc2V0Cj4gPiAgIHdoZW4gdGhlIGlycSBoYW5kbGVyIGNoZWNrcyBpdCwgYW5kIHRoZSB2 YmxhbmsgZXZlbnQgd2lsbCBiZSBkZWZlcnJlZAo+ID4gICB0byB0aGUgbmV4dCBpbnRlcnJ1cHQu Cj4gCj4gSG93IGRvIHdlIHByb2NlZWQgd2l0aCB0aGlzPyBLZWVwIHRoZSBzcGluIGxvY2s/CgpZ ZWFoLCBzdGFuZGFyZCBwcmFjdGljZSBpcyB0byBwcm90ZWN0IHRoZXNlIHRoaW5ncyB3aXRoIGEg c3BpbmxvY2ssCnVzdWFsbHkgdGhlIGRybS0+ZXZlbnRfbG9jay4gVGhlbiB0aGUgZmxpcF9kb25l IHdhaXQgc2hvdWxkIG1ha2Ugc3VyZQpvdmVyYWxsIG9yZGVyaW5nIGlzIGNvcnJlY3QsIHRvby4K Ck1pZ2h0IGJlIGdvb2QgdG8gaW1wcm92ZSB0aGUga2VybmVsZG9jcyB0aGF0IHRoaXMgaXMgYSBy ZWNvbW1lbmRlZApwYXR0ZXJuLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK