From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 14/15] drm/i915/tv: Fix >1024 modes on gen3 Date: Wed, 23 Jan 2019 15:49:02 +0200 Message-ID: <20190123134902.GE17259@ideak-desk.fi.intel.com> References: <20181112170000.27531-1-ville.syrjala@linux.intel.com> <20181112170000.27531-16-ville.syrjala@linux.intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181112170000.27531-16-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBOb3YgMTIsIDIwMTggYXQgMDY6NTk6NTlQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IE9uIGdlbjMgd2UgbXVzdCBkaXNhYmxlIHRoZSBUViBlbmNvZGVyIHZlcnRpY2Fs IGZpbHRlciBmb3IgPjEwMjQKPiBwaXhlbCB3aWRlIHNvdXJjZXMuIE9uY2UgdGhhdCdzIGRvbmUg YWxsIHdlIGNhbiBpcyB0cnkgdG8gY2VudGVyCj4gdGhlIGltYWdlIG9uIHRoZSBzY3JlZW4uIE5h dHVyYWxseSB0aGUgVFYgbW9kZSB2ZXJ0aWNhbCByZXNvbHV0aW9uCj4gbXVzdCBiZSBlcXVhbCBv ciBsYXJnZXIgdGhhbiB0aGUgdXNlciBtb2RlIHZlcnRpY2FsIHJlc29sdXRpb24KPiBvciBlbHNl IHdlJ2QgaGF2ZSB0byBjdXQgb2ZmIHBhcnQgb2YgdGhlIHVzZXIgbW9kZS4KPiAKPiBBbmQgd2hp bGUgd2UgbWF5IG5vdCBiZSBhYmxlIHRvIHJlc3BlY3QgdGhlIHVzZXIncyBjaG9pY2Ugb2YKPiB0 b3AgYW5kIGJvdHRvbSBib3JkZXJzIGV4YWN0bHkgKG9yIHdlJ2QgaGF2ZSB0byByZWplY3QgaGUg bW9kZQo+IG1vc3QgbGlrZWx5KSwgd2UgY2FuIHRyeSB0byBtYWludGFpbiB0aGUgcmVsYXRpdmUg c2l6ZXMgb2YgdGhlCj4gdG9wIGFuZCBib3R0b20gYm9yZGVyIHdpdGggcmVzcGVjdCB0byBlYWNo IG9yaGVyLgo+IAo+IEFkZGl0aW9uYWxseSB3ZSBtdXN0IGNvbmZpZ3VyZSB0aGUgcGlwZSBhcyBp bnRlcmxhY2VkIGlmIHRoZQo+IFRWIG1vZGUgaXMgaW50ZXJsYWNlZC4KPiAKPiBTaWduZWQtb2Zm LWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IC0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF90di5jIHwgMTAwICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA5MiBpbnNlcnRpb25zKCspLCA4 IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF90di5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdHYuYwo+IGluZGV4IDc1MTI2ZmNl NjU1ZC4uNzA5OWQ4MzdlMzFhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3R2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF90di5jCj4gQEAgLTg2 MSw2ICs4NjEsNDQgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCB0dl9tb2RlIHR2X21vZGVzW10gPSB7 Cj4gIAl9LAo+ICB9Owo+ICAKPiArc3RydWN0IGludGVsX3R2X2Nvbm5lY3Rvcl9zdGF0ZSB7Cj4g KwlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSBiYXNlOwo+ICsKPiArCS8qCj4gKwkgKiBNYXkg bmVlZCB0byBvdmVycmlkZSB0aGUgdXNlciBtYXJnaW5zIGZvcgo+ICsJICogZ2VuMyA+MTAyNCB3 aWRlIHNvdXJjZSB2ZXJ0aWNhbCBjZW50ZXJpbmcuCj4gKwkgKi8KPiArCXN0cnVjdCB7Cj4gKwkJ dTE2IHRvcCwgYm90dG9tOwo+ICsJfSBtYXJnaW5zOwo+ICsKPiArCWJvb2wgYnlwYXNzX3ZmaWx0 ZXI7Cj4gK307Cj4gKwo+ICsjZGVmaW5lIHRvX2ludGVsX3R2X2Nvbm5lY3Rvcl9zdGF0ZSh4KSBj b250YWluZXJfb2YoeCwgc3RydWN0IGludGVsX3R2X2Nvbm5lY3Rvcl9zdGF0ZSwgYmFzZSkKPiAr Cj4gKy8qKgo+ICsgKiBpbnRlbF9kaWdpdGFsX2Nvbm5lY3Rvcl9kdXBsaWNhdGVfc3RhdGUgLSBk dXBsaWNhdGUgY29ubmVjdG9yIHN0YXRlCiAgICAgIF5pbnRlbF90dl9jb25uZWN0b3JfZHVwbGlj YXRlX3N0YXRlCj4gKyAqIEBjb25uZWN0b3I6IGRpZ2l0YWwgY29ubmVjdG9yCiAgICAgICAgICAg ICAgICAgIF50diBjb25uZWN0b3I/Cj4gKyAqCj4gKyAqIEFsbG9jYXRlcyBhbmQgcmV0dXJucyBh IGNvcHkgb2YgdGhlIGNvbm5lY3RvciBzdGF0ZSAoYm90aCBjb21tb24gYW5kCj4gKyAqIGRpZ2l0 YWwgY29ubmVjdG9yIHNwZWNpZmljKSBmb3IgdGhlIHNwZWNpZmllZCBjb25uZWN0b3IuCj4gKyAq Cj4gKyAqIFJldHVybnM6IFRoZSBuZXdseSBhbGxvY2F0ZWQgY29ubmVjdG9yIHN0YXRlLCBvciBO VUxMIG9uIGZhaWx1cmUuCj4gKyAqLwo+ICtzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqCj4g K2ludGVsX3R2X2Nvbm5lY3Rvcl9kdXBsaWNhdGVfc3RhdGUoc3RydWN0IGRybV9jb25uZWN0b3Ig KmNvbm5lY3RvcikKPiArewo+ICsJc3RydWN0IGludGVsX3R2X2Nvbm5lY3Rvcl9zdGF0ZSAqc3Rh dGU7Cj4gKwo+ICsJc3RhdGUgPSBrbWVtZHVwKGNvbm5lY3Rvci0+c3RhdGUsIHNpemVvZigqc3Rh dGUpLCBHRlBfS0VSTkVMKTsKPiArCWlmICghc3RhdGUpCj4gKwkJcmV0dXJuIE5VTEw7Cj4gKwo+ ICsJX19kcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0b3JfZHVwbGljYXRlX3N0YXRlKGNvbm5lY3Rv ciwgJnN0YXRlLT5iYXNlKTsKPiArCXJldHVybiAmc3RhdGUtPmJhc2U7Cj4gK30KCllvdSBkaWRu J3QgYWRkIHRoZSBjb3JyZXNwb25kaW5nIGNoZWNrcyBmb3IgdGhlIG5ldwppbnRlbF90dl9jb25u ZWN0b3Jfc3RhdGUgZmllbGRzIHRvIGludGVsX3R2X2F0b21pY19jaGVjaygpLiBJIHN1cHBvc2UK dGhhdCdzIG9rIHNpbmNlIHNvbWV0aGluZyByZXN1bHRpbmcgaW4gYSBjaGFuZ2UgaW4gdGhvc2Ug d2lsbCBmb3JjZSBhCm1vZGVzZXQgYW55d2F5OgoKUmV2aWV3ZWQtYnk6IEltcmUgRGVhayA8aW1y ZS5kZWFrQGludGVsLmNvbT4KCj4gKwo+ICBzdGF0aWMgc3RydWN0IGludGVsX3R2ICplbmNfdG9f dHYoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gIHsKPiAgCXJldHVybiBjb250YWlu ZXJfb2YoZW5jb2Rlciwgc3RydWN0IGludGVsX3R2LCBiYXNlKTsKPiBAQCAtMTEyOSw2ICsxMTY3 LDkgQEAgaW50ZWxfdHZfY29tcHV0ZV9jb25maWcoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29k ZXIsCj4gIAkJCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZywKPiAgCQkJc3Ry dWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGUpCj4gIHsKPiArCXN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZW5jb2Rlci0+YmFzZS5kZXYpOwo+ICsJ c3RydWN0IGludGVsX3R2X2Nvbm5lY3Rvcl9zdGF0ZSAqdHZfY29ubl9zdGF0ZSA9Cj4gKwkJdG9f aW50ZWxfdHZfY29ubmVjdG9yX3N0YXRlKGNvbm5fc3RhdGUpOwo+ICAJY29uc3Qgc3RydWN0IHR2 X21vZGUgKnR2X21vZGUgPSBpbnRlbF90dl9tb2RlX2ZpbmQoY29ubl9zdGF0ZSk7Cj4gIAlzdHJ1 Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqYWRqdXN0ZWRfbW9kZSA9Cj4gIAkJJnBpcGVfY29uZmlnLT5i YXNlLmFkanVzdGVkX21vZGU7Cj4gQEAgLTExNDksNiArMTE5MCw0MyBAQCBpbnRlbF90dl9jb21w dXRlX2NvbmZpZyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCXBpcGVfY29uZmln LT5wb3J0X2Nsb2NrID0gdHZfbW9kZS0+Y2xvY2s7Cj4gIAo+ICAJaW50ZWxfdHZfbW9kZV90b19t b2RlKGFkanVzdGVkX21vZGUsIHR2X21vZGUpOwo+ICsJZHJtX21vZGVfc2V0X2NydGNpbmZvKGFk anVzdGVkX21vZGUsIDApOwo+ICsKPiArCWlmIChJU19HRU4zKGRldl9wcml2KSAmJiBoZGlzcGxh eSA+IDEwMjQpIHsKPiArCQlpbnQgZXh0cmEsIHRvcCwgYm90dG9tOwo+ICsKPiArCQlleHRyYSA9 IGFkanVzdGVkX21vZGUtPmNydGNfdmRpc3BsYXkgLSB2ZGlzcGxheTsKPiArCj4gKwkJaWYgKGV4 dHJhIDwgMCkgewo+ICsJCQlEUk1fREVCVUdfS01TKCJObyB2ZXJ0aWNhbCBzY2FsaW5nIGZvciA+ MTAyNCBwaXhlbCB3aWRlIG1vZGVzXG4iKTsKPiArCQkJcmV0dXJuIGZhbHNlOwo+ICsJCX0KPiAr Cj4gKwkJLyogTmVlZCB0byB0dXJuIG9mZiB0aGUgdmVydGljYWwgZmlsdGVyIGFuZCBjZW50ZXIg dGhlIGltYWdlICovCj4gKwo+ICsJCS8qIEF0dGVtcHQgdG8gbWFpbnRhaW4gdGhlIHJlbGF0aXZl IHNpemVzIG9mIHRoZSBtYXJnaW5zICovCj4gKwkJdG9wID0gY29ubl9zdGF0ZS0+dHYubWFyZ2lu cy50b3A7Cj4gKwkJYm90dG9tID0gY29ubl9zdGF0ZS0+dHYubWFyZ2lucy5ib3R0b207Cj4gKwo+ ICsJCWlmICh0b3AgKyBib3R0b20pCj4gKwkJCXRvcCA9IGV4dHJhICogdG9wIC8gKHRvcCArIGJv dHRvbSk7Cj4gKwkJZWxzZQo+ICsJCQl0b3AgPSBleHRyYSAvIDI7Cj4gKwkJYm90dG9tID0gZXh0 cmEgLSB0b3A7Cj4gKwo+ICsJCXR2X2Nvbm5fc3RhdGUtPm1hcmdpbnMudG9wID0gdG9wOwo+ICsJ CXR2X2Nvbm5fc3RhdGUtPm1hcmdpbnMuYm90dG9tID0gYm90dG9tOwo+ICsKPiArCQl0dl9jb25u X3N0YXRlLT5ieXBhc3NfdmZpbHRlciA9IHRydWU7Cj4gKwo+ICsJCWlmICghdHZfbW9kZS0+cHJv Z3Jlc3NpdmUpCj4gKwkJCWFkanVzdGVkX21vZGUtPmZsYWdzIHw9IERSTV9NT0RFX0ZMQUdfSU5U RVJMQUNFOwo+ICsJfSBlbHNlIHsKPiArCQl0dl9jb25uX3N0YXRlLT5tYXJnaW5zLnRvcCA9IGNv bm5fc3RhdGUtPnR2Lm1hcmdpbnMudG9wOwo+ICsJCXR2X2Nvbm5fc3RhdGUtPm1hcmdpbnMuYm90 dG9tID0gY29ubl9zdGF0ZS0+dHYubWFyZ2lucy5ib3R0b207Cj4gKwo+ICsJCXR2X2Nvbm5fc3Rh dGUtPmJ5cGFzc192ZmlsdGVyID0gZmFsc2U7Cj4gKwl9Cj4gIAo+ICAJRFJNX0RFQlVHX0tNUygi VFYgbW9kZTpcbiIpOwo+ICAJZHJtX21vZGVfZGVidWdfcHJpbnRtb2RlbGluZShhZGp1c3RlZF9t b2RlKTsKPiBAQCAtMTIyMiw4ICsxMzAwLDggQEAgaW50ZWxfdHZfY29tcHV0ZV9jb25maWcoc3Ry dWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAkJCQkgIGNvbm5fc3RhdGUtPnR2Lm1hcmdp bnMubGVmdCwKPiAgCQkJCSAgY29ubl9zdGF0ZS0+dHYubWFyZ2lucy5yaWdodCk7Cj4gIAlpbnRl bF90dl9zY2FsZV9tb2RlX3ZlcnQoYWRqdXN0ZWRfbW9kZSwgdmRpc3BsYXksCj4gLQkJCQkgY29u bl9zdGF0ZS0+dHYubWFyZ2lucy50b3AsCj4gLQkJCQkgY29ubl9zdGF0ZS0+dHYubWFyZ2lucy5i b3R0b20pOwo+ICsJCQkJIHR2X2Nvbm5fc3RhdGUtPm1hcmdpbnMudG9wLAo+ICsJCQkJIHR2X2Nv bm5fc3RhdGUtPm1hcmdpbnMuYm90dG9tKTsKPiAgCWRybV9tb2RlX3NldF9jcnRjaW5mbyhhZGp1 c3RlZF9tb2RlLCAwKTsKPiAgCWFkanVzdGVkX21vZGUtPm5hbWVbMF0gPSAnXDAnOwo+ICAKPiBA QCAtMTMxNiw4ICsxMzk0LDEwIEBAIHN0YXRpYyB2b2lkIGludGVsX3R2X3ByZV9lbmFibGUoc3Ry dWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYgPSB0b19pOTE1KGVuY29kZXItPmJhc2UuZGV2KTsKPiAgCXN0cnVjdCBpbnRlbF9j cnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhwaXBlX2NvbmZpZy0+YmFzZS5jcnRjKTsK PiAgCXN0cnVjdCBpbnRlbF90diAqaW50ZWxfdHYgPSBlbmNfdG9fdHYoZW5jb2Rlcik7Cj4gKwlj b25zdCBzdHJ1Y3QgaW50ZWxfdHZfY29ubmVjdG9yX3N0YXRlICp0dl9jb25uX3N0YXRlID0KPiAr CQl0b19pbnRlbF90dl9jb25uZWN0b3Jfc3RhdGUoY29ubl9zdGF0ZSk7Cj4gIAljb25zdCBzdHJ1 Y3QgdHZfbW9kZSAqdHZfbW9kZSA9IGludGVsX3R2X21vZGVfZmluZChjb25uX3N0YXRlKTsKPiAt CXUzMiB0dl9jdGw7Cj4gKwl1MzIgdHZfY3RsLCB0dl9maWx0ZXJfY3RsOwo+ICAJdTMyIHNjY3Rs MSwgc2NjdGwyLCBzY2N0bDM7Cj4gIAlpbnQgaSwgajsKPiAgCWNvbnN0IHN0cnVjdCB2aWRlb19s ZXZlbHMgKnZpZGVvX2xldmVsczsKPiBAQCAtMTQyNSwxNiArMTUwNSwyMCBAQCBzdGF0aWMgdm9p ZCBpbnRlbF90dl9wcmVfZW5hYmxlKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJ YXNzZXJ0X3BpcGVfZGlzYWJsZWQoZGV2X3ByaXYsIGludGVsX2NydGMtPnBpcGUpOwo+ICAKPiAg CS8qIEZpbHRlciBjdGwgbXVzdCBiZSBzZXQgYmVmb3JlIFRWX1dJTl9TSVpFICovCj4gLQlJOTE1 X1dSSVRFKFRWX0ZJTFRFUl9DVExfMSwgVFZfQVVUT19TQ0FMRSk7Cj4gKwl0dl9maWx0ZXJfY3Rs ID0gVFZfQVVUT19TQ0FMRTsKPiArCWlmICh0dl9jb25uX3N0YXRlLT5ieXBhc3NfdmZpbHRlcikK PiArCQl0dl9maWx0ZXJfY3RsIHw9IFRWX1ZfRklMVEVSX0JZUEFTUzsKPiArCUk5MTVfV1JJVEUo VFZfRklMVEVSX0NUTF8xLCB0dl9maWx0ZXJfY3RsKTsKPiArCj4gIAl4c2l6ZSA9IHR2X21vZGUt PmhibGFua19zdGFydCAtIHR2X21vZGUtPmhibGFua19lbmQ7Cj4gIAl5c2l6ZSA9IGludGVsX3R2 X21vZGVfdmRpc3BsYXkodHZfbW9kZSk7Cj4gIAo+ICAJeHBvcyA9IGNvbm5fc3RhdGUtPnR2Lm1h cmdpbnMubGVmdDsKPiAtCXlwb3MgPSBjb25uX3N0YXRlLT50di5tYXJnaW5zLnRvcDsKPiArCXlw b3MgPSB0dl9jb25uX3N0YXRlLT5tYXJnaW5zLnRvcDsKPiAgCXhzaXplIC09IChjb25uX3N0YXRl LT50di5tYXJnaW5zLmxlZnQgKwo+ICAJCSAgY29ubl9zdGF0ZS0+dHYubWFyZ2lucy5yaWdodCk7 Cj4gLQl5c2l6ZSAtPSAoY29ubl9zdGF0ZS0+dHYubWFyZ2lucy50b3AgKwo+IC0JCSAgY29ubl9z dGF0ZS0+dHYubWFyZ2lucy5ib3R0b20pOwo+ICsJeXNpemUgLT0gKHR2X2Nvbm5fc3RhdGUtPm1h cmdpbnMudG9wICsKPiArCQkgIHR2X2Nvbm5fc3RhdGUtPm1hcmdpbnMuYm90dG9tKTsKPiAgCUk5 MTVfV1JJVEUoVFZfV0lOX1BPUywgKHhwb3M8PDE2KXx5cG9zKTsKPiAgCUk5MTVfV1JJVEUoVFZf V0lOX1NJWkUsICh4c2l6ZTw8MTYpfHlzaXplKTsKPiAgCj4gQEAgLTE3MDEsNyArMTc4NSw3IEBA IHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9mdW5jcyBpbnRlbF90dl9jb25uZWN0 b3JfZnVuY3MgPSB7Cj4gIAkuZGVzdHJveSA9IGludGVsX2Nvbm5lY3Rvcl9kZXN0cm95LAo+ICAJ LmZpbGxfbW9kZXMgPSBkcm1faGVscGVyX3Byb2JlX3NpbmdsZV9jb25uZWN0b3JfbW9kZXMsCj4g IAkuYXRvbWljX2Rlc3Ryb3lfc3RhdGUgPSBkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0b3JfZGVz dHJveV9zdGF0ZSwKPiAtCS5hdG9taWNfZHVwbGljYXRlX3N0YXRlID0gZHJtX2F0b21pY19oZWxw ZXJfY29ubmVjdG9yX2R1cGxpY2F0ZV9zdGF0ZSwKPiArCS5hdG9taWNfZHVwbGljYXRlX3N0YXRl ID0gaW50ZWxfdHZfY29ubmVjdG9yX2R1cGxpY2F0ZV9zdGF0ZSwKPiAgfTsKPiAgCj4gIHN0YXRp YyBpbnQgaW50ZWxfdHZfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0 b3IsCj4gLS0gCj4gMi4xOC4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=