From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v4 RESEND] drm/panel: add Kingdisplay kd097d04 panel driver Date: Thu, 24 Jan 2019 17:18:12 +0100 Message-ID: <20190124161812.GA10550@ulmo> References: <20181030091528.28211-1-heiko@sntech.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1075897227==" Return-path: Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1D56C6E244 for ; Thu, 24 Jan 2019 16:18:16 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id v13so7115869wrw.5 for ; Thu, 24 Jan 2019 08:18:16 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ezequiel Garcia Cc: maxime.ripard@bootlin.com, briannorris@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, padovan Gustavo , nickey.yang@rock-chips.com, seanpaul@chromium.org, hl@rock-chips.com List-Id: dri-devel@lists.freedesktop.org --===============1075897227== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UugvWAfsgieZRqgk" Content-Disposition: inline --UugvWAfsgieZRqgk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 24, 2019 at 12:01:55PM -0300, Ezequiel Garcia wrote: > On Tue, 2018-10-30 at 10:15 +0100, Heiko Stuebner wrote: > > From: Nickey Yang > >=20 > > Support Kingdisplay kd097d04 9.7" 1536x2048 TFT LCD panel, > > it is a MIPI dual-DSI panel. > >=20 > > v4-resend: > > - Thierry noted missing dt-bindings for v4 but forgot that he > > already had applied them one kernel release back in > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/co= mmit/?id=3Debc950fdff6d5f9250cd5a5a348af97f7d8508df > > v4: > > - address Philipp's comments > > - real range for usleep_range and > > - poweroff ordering in kingdisplay_panel_prepare > > - return value beautification in panel_probe > > - update author naming for full name > > v3: > > - address Thierry's comments > > - error handling for init dsi writes in init > > - unconditionally remove the panel > > - don't use drm_panel_detach > > - a bit of variable signednes wiggling > > - I did talk to ChromeOS people and the delays really should be as short > > as possible, so dropped the 100ms from the delay comments > > v2: > > - update timing + cmds from chromeos kernel > > - new backlight API including switch to devm_of_find_backlight > > - fix most of Sean Paul's comments > > enable/prepare tracking seems something all panels do > > - document origins of the init sequence > > - lanes per dsi interface to 4 (two interfaces). Matches how tegra > > and pending rockchip dual-dsi handle (dual-)dsi lanes > > - spdx header instead of license boilerplate > >=20 > > Signed-off-by: Nickey Yang > > Signed-off-by: Heiko Stuebner >=20 > Hm, this v4 patch has been stalling here for *four full months*. >=20 > Which deity do we need to pray to get this one moving? ;-) >=20 > Seriously, can someone please apply this? If you care about this driver, perhaps you'd like to review and provide a Reviewed-by? Thierry --UugvWAfsgieZRqgk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlxJ5UEACgkQ3SOs138+ s6EmExAAvc4oBTHIAOuiXuzeqfnnUZG1Gq+FK8pHDzW9mf6uRe5l21LRZwQMdIgQ NKYEr33uMEmDCBZOHKpNlcifAl3Ki2qRvWWlZnVnxiwXR1Sjz3mqNfW45Gxwcfeb sESMjjC5OCF/2xVvVkMQmEaVTWBhFi8jomAAGw5Shkvl//7MIrBzNGf4cT5kEbJF xD3U7++XbZMX0psPTo+p5fWx7ol3/C4C1GMmeGdf4WzDacqCHAUDbExdiI+4VT41 OSQ90q/lhABL4uZKm4qc1ZC0WcUsqITwfv2Z9w9o8x6CBB3mZxgj0EjivOUN7NK+ C5GLqoQ7IZ4BLKCpA6yqDN1Rbr6c4H98b5kYkFFX1NMvgDe5QkwwxLtEMyHGxTwj i86X0H9jXpgfT38Zyf9zVFzgrkItziqGe/uM7gNiSJG6isOFrNMdoDfJY+vkHNkF GZQ1GyWLC4p/nQ79arFu8WNfmonzxbcOTEQFp8rQWXQ6ajzSfADmqDJiQYOSdoVZ cXFSJXzH7ZpjnvfBBOF+FVEp919c7fZlYy5M4Z3DF5oIOJa+WM+FkyrQeXj6FQrc UnPkpIPxsUxiLS0CU9N7zOUXTkVEUE0JZTyErvohdYEwtCKW9VzlGfFma9m9hE9F hKCvVieZrAXkBQjRfQVwM0OA9EZEQ2DpLviq4vwdW5/74eMVjWA= =GTB1 -----END PGP SIGNATURE----- --UugvWAfsgieZRqgk-- --===============1075897227== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1075897227==--