From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v4 RESEND] drm/panel: add Kingdisplay kd097d04 panel driver Date: Thu, 24 Jan 2019 12:51:36 -0500 Message-ID: <20190124175136.GP114153@art_vandelay> References: <20181030091528.28211-1-heiko@sntech.de> <20190124161812.GA10550@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190124161812.GA10550@ulmo> Sender: linux-kernel-owner@vger.kernel.org To: Thierry Reding Cc: Ezequiel Garcia , Heiko Stuebner , padovan Gustavo , maxime.ripard@bootlin.com, seanpaul@chromium.org, hl@rock-chips.com, briannorris@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, nickey.yang@rock-chips.com List-Id: dri-devel@lists.freedesktop.org On Thu, Jan 24, 2019 at 05:18:12PM +0100, Thierry Reding wrote: > On Thu, Jan 24, 2019 at 12:01:55PM -0300, Ezequiel Garcia wrote: > > On Tue, 2018-10-30 at 10:15 +0100, Heiko Stuebner wrote: > > > From: Nickey Yang > > > > > > Support Kingdisplay kd097d04 9.7" 1536x2048 TFT LCD panel, > > > it is a MIPI dual-DSI panel. > > > > > > v4-resend: > > > - Thierry noted missing dt-bindings for v4 but forgot that he > > > already had applied them one kernel release back in > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ebc950fdff6d5f9250cd5a5a348af97f7d8508df > > > v4: > > > - address Philipp's comments > > > - real range for usleep_range and > > > - poweroff ordering in kingdisplay_panel_prepare > > > - return value beautification in panel_probe > > > - update author naming for full name > > > v3: > > > - address Thierry's comments > > > - error handling for init dsi writes in init > > > - unconditionally remove the panel > > > - don't use drm_panel_detach > > > - a bit of variable signednes wiggling > > > - I did talk to ChromeOS people and the delays really should be as short > > > as possible, so dropped the 100ms from the delay comments > > > v2: > > > - update timing + cmds from chromeos kernel > > > - new backlight API including switch to devm_of_find_backlight > > > - fix most of Sean Paul's comments > > > enable/prepare tracking seems something all panels do > > > - document origins of the init sequence > > > - lanes per dsi interface to 4 (two interfaces). Matches how tegra > > > and pending rockchip dual-dsi handle (dual-)dsi lanes > > > - spdx header instead of license boilerplate > > > > > > Signed-off-by: Nickey Yang > > > Signed-off-by: Heiko Stuebner > > > > Hm, this v4 patch has been stalling here for *four full months*. > > > > Which deity do we need to pray to get this one moving? ;-) > > > > Seriously, can someone please apply this? > > If you care about this driver, perhaps you'd like to review and provide > a Reviewed-by? Looks good to me, Reviewed-by: Sean Paul > > Thierry -- Sean Paul, Software Engineer, Google / Chromium OS