Re: [PATCH 09/26] drm/ast: Use drm_fb_helper_fill_info

Sam Ravnborg
2019-01-24T18:00:11Z

Hi Daniel.

On Thu, Jan 24, 2019 at 05:58:14PM +0100, Daniel Vetter wrote:
> Should not result in any changes.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Junwei Zhang <Jerry.Zhang@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Sean Paul <sean@poorly.run>
> Cc: YueHaibing <yuehaibing@huawei.com>
> Cc: Sam Bobroff <sbobroff@linux.ibm.com>
> ---
> drivers/gpu/drm/ast/ast_drv.h | 2 +-
> drivers/gpu/drm/ast/ast_fb.c | 7 +------
> 2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_drv.h b/drivers/gpu/drm/ast/ast_drv.h
> index bfc65040dfcb..ffce4608e0c5 100644
> --- a/drivers/gpu/drm/ast/ast_drv.h
> +++ b/drivers/gpu/drm/ast/ast_drv.h
> @@ -259,7 +259,7 @@ struct ast_framebuffer {
> };
>
> struct ast_fbdev {
> - struct drm_fb_helper helper;
> + struct drm_fb_helper helper; /* must be first */

Again in the category "I do not know the code",
but I failed to see whay "struct drm_fb_helper" have to be first.

I saw no ugly cast or similar when browsign the code, but I
must have missed something?

Sam
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org