Re: [PATCH 21/26] drm/rockchip: Use drm_fb_helper_fill_info

Heiko Stuebner
2019-01-27T19:18:58Z

Am Donnerstag, 24. Januar 2019, 17:58:26 CET schrieb Daniel Vetter:
> This will set an fb name for the first time!
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: "Heiko Stübner" <heiko@sntech.de>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org

After looking up the rest of the series and also realizing that
fbi->par seems to be set when a client attaches to the fb,
this looks good to me, so

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
> drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> index 7bd3b89022be..d12164878e05 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> @@ -90,13 +90,11 @@ static int rockchip_drm_fbdev_create(struct drm_fb_helper *helper,
> goto out;
> }
>
> - fbi->par = helper;
> fbi->flags = FBINFO_FLAG_DEFAULT;
> fbi->fbops = &rockchip_drm_fbdev_ops;
>
> fb = helper->fb;
> - drm_fb_helper_fill_fix(fbi, fb->pitches[0], fb->format->depth);
> - drm_fb_helper_fill_var(fbi, helper, sizes->fb_width, sizes->fb_height);
> + drm_fb_helper_fill_info(fbi, helper);
>
> offset = fbi->var.xoffset * bytes_per_pixel;
> offset += fbi->var.yoffset * fb->pitches[0];
>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org