From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH 4/4] drm/panel: Add Rondo RB070D30 panel Date: Sun, 27 Jan 2019 08:33:22 +0100 Message-ID: <20190127073321.GA9954@ravnborg.org> References: <15b81a58eddd5d3fbfa418293cf1c817ef46423a.1548236066.git-series.maxime.ripard@bootlin.com> <20190126153946.GB17756@ravnborg.org> <1548566815.202603076@f339.i.mail.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1548566815.202603076@f339.i.mail.ru> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Konstantin Sudakov Cc: bbrezillon@kernel.org, Maxime Ripard , Maarten Lankhorst , dri-devel@lists.freedesktop.org, Paul Kocialkowski , Chen-Yu Tsai , Sean Paul , Thomas Petazzoni , Jagan Teki , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org Hi Konstantin > >> + ctx->gpios.updn = devm_gpiod_get(&dsi->dev, "updn", GPIOD_OUT_LOW); > >> + if (IS_ERR(ctx->gpios.updn)) { > >> + dev_err(&dsi->dev, "Couldn't get our updn GPIO\n"); > >> + return PTR_ERR(ctx->gpios.updn); > >> + } > > This gpio is never used, it is only read from DT > The gpio is initialized with low state. The state may be inverted by DT. The same for the "shlr". > It is a vertical / horizontal inversion. Ohh, then it makes sense again. Consider adding a comment so this becomes more obvious Sam