From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v4 RESEND] drm/panel: add Kingdisplay kd097d04 panel driver Date: Mon, 28 Jan 2019 16:58:49 +0100 Message-ID: <20190128155849.GB26200@ulmo> References: <20181030091528.28211-1-heiko@sntech.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1214194988==" Return-path: Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 705866E4F7 for ; Mon, 28 Jan 2019 15:58:52 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id m1so14552594wml.2 for ; Mon, 28 Jan 2019 07:58:52 -0800 (PST) In-Reply-To: <20181030091528.28211-1-heiko@sntech.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Heiko Stuebner Cc: hl@rock-chips.com, briannorris@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, nickey.yang@rock-chips.com, seanpaul@chromium.org List-Id: dri-devel@lists.freedesktop.org --===============1214194988== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5I6of5zJg18YgZEa" Content-Disposition: inline --5I6of5zJg18YgZEa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 30, 2018 at 10:15:28AM +0100, Heiko Stuebner wrote: > From: Nickey Yang >=20 > Support Kingdisplay kd097d04 9.7" 1536x2048 TFT LCD panel, > it is a MIPI dual-DSI panel. >=20 > v4-resend: > - Thierry noted missing dt-bindings for v4 but forgot that he > already had applied them one kernel release back in > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/comm= it/?id=3Debc950fdff6d5f9250cd5a5a348af97f7d8508df > v4: > - address Philipp's comments > - real range for usleep_range and > - poweroff ordering in kingdisplay_panel_prepare > - return value beautification in panel_probe > - update author naming for full name > v3: > - address Thierry's comments > - error handling for init dsi writes in init > - unconditionally remove the panel > - don't use drm_panel_detach > - a bit of variable signednes wiggling > - I did talk to ChromeOS people and the delays really should be as short > as possible, so dropped the 100ms from the delay comments > v2: > - update timing + cmds from chromeos kernel > - new backlight API including switch to devm_of_find_backlight > - fix most of Sean Paul's comments > enable/prepare tracking seems something all panels do > - document origins of the init sequence > - lanes per dsi interface to 4 (two interfaces). Matches how tegra > and pending rockchip dual-dsi handle (dual-)dsi lanes > - spdx header instead of license boilerplate >=20 > Signed-off-by: Nickey Yang > Signed-off-by: Heiko Stuebner > --- > drivers/gpu/drm/panel/Kconfig | 11 + > drivers/gpu/drm/panel/Makefile | 1 + > .../drm/panel/panel-kingdisplay-kd097d04.c | 473 ++++++++++++++++++ > 3 files changed, 485 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c Applied to drm-misc-next, thanks. Thierry --5I6of5zJg18YgZEa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlxPJrkACgkQ3SOs138+ s6FSVQ/9EalnmSwrQ9J3DGelxqDMa1ePu6Ad25W/00aZtvCaY+wHqMWT70N2cr+q vPHjXDNbLuze3DuB7KGNTDd7iYt0Y6oYZBsG3zARfTenHrfMKNMRHl5oHkiImWAY 6ZtIKMuwPc+RHqX84iZ5ooBvoqPAlW4MW3Dt9POQ6hdxHDfcj2y8WM1Pj+6+5pxU eB2jvgIuHVSRljVcZDU3J3I3PIxRRMMxd+CCenP4SnrKYayeET+rXFYWqKOn2BBF 9xjhoIA7I4+3jU8RmT1ImEVIuFnFFpJEy3x83zyMIh1mGdn9nkP34kBtXGGJpfST 1eAzMAcgqNtU+eKyR0UthhYTA/G1ybfoPK7NqKgM9vzxIxA02UO7TN5/8UEldoFp KBXNK6sefbzL7iSK6X/aAC7rt0oMZCoxnvVNdB9Ouqyzm0aobQWzSQzvw27ynv6a 2JRD5tjFAYNPTPTF9vcqljqFUkYKJZz/6Pq8yU9LYHXWF3ImREww3BdEdxRc0P4R gj89Ng0UiiSFjflxSd52Ei5Olezlt6DoWjB/VDj9SZtVWCzUT55QU0kEfQXnO4mD lX5HnW2Dpj7DYdcqcLEa9BJKSgCrizyXM2ENNobZmr7ce1amhA/1UYN4SGkKk0ij bv8lsn3Y5V/JtHNauWTwoar7MR++8gKPs2xXcE443aC5OKsUOdM= =ozcE -----END PGP SIGNATURE----- --5I6of5zJg18YgZEa-- --===============1214194988== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1214194988==--