From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v4 RESEND] drm/panel: add Kingdisplay kd097d04 panel driver Date: Mon, 28 Jan 2019 16:59:38 +0100 Message-ID: <20190128155938.GC26200@ulmo> References: <20181030091528.28211-1-heiko@sntech.de> <20190124161812.GA10550@ulmo> <20190124175136.GP114153@art_vandelay> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1031205637==" Return-path: Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id B30556E505 for ; Mon, 28 Jan 2019 15:59:41 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id m1so14555627wml.2 for ; Mon, 28 Jan 2019 07:59:41 -0800 (PST) In-Reply-To: <20190124175136.GP114153@art_vandelay> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: maxime.ripard@bootlin.com, briannorris@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, padovan Gustavo , nickey.yang@rock-chips.com, seanpaul@chromium.org, Ezequiel Garcia , hl@rock-chips.com List-Id: dri-devel@lists.freedesktop.org --===============1031205637== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RIYY1s2vRbPFwWeW" Content-Disposition: inline --RIYY1s2vRbPFwWeW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 24, 2019 at 12:51:36PM -0500, Sean Paul wrote: > On Thu, Jan 24, 2019 at 05:18:12PM +0100, Thierry Reding wrote: > > On Thu, Jan 24, 2019 at 12:01:55PM -0300, Ezequiel Garcia wrote: > > > On Tue, 2018-10-30 at 10:15 +0100, Heiko Stuebner wrote: > > > > From: Nickey Yang > > > >=20 > > > > Support Kingdisplay kd097d04 9.7" 1536x2048 TFT LCD panel, > > > > it is a MIPI dual-DSI panel. > > > >=20 > > > > v4-resend: > > > > - Thierry noted missing dt-bindings for v4 but forgot that he > > > > already had applied them one kernel release back in > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi= t/commit/?id=3Debc950fdff6d5f9250cd5a5a348af97f7d8508df > > > > v4: > > > > - address Philipp's comments > > > > - real range for usleep_range and > > > > - poweroff ordering in kingdisplay_panel_prepare > > > > - return value beautification in panel_probe > > > > - update author naming for full name > > > > v3: > > > > - address Thierry's comments > > > > - error handling for init dsi writes in init > > > > - unconditionally remove the panel > > > > - don't use drm_panel_detach > > > > - a bit of variable signednes wiggling > > > > - I did talk to ChromeOS people and the delays really should be as = short > > > > as possible, so dropped the 100ms from the delay comments > > > > v2: > > > > - update timing + cmds from chromeos kernel > > > > - new backlight API including switch to devm_of_find_backlight > > > > - fix most of Sean Paul's comments > > > > enable/prepare tracking seems something all panels do > > > > - document origins of the init sequence > > > > - lanes per dsi interface to 4 (two interfaces). Matches how tegra > > > > and pending rockchip dual-dsi handle (dual-)dsi lanes > > > > - spdx header instead of license boilerplate > > > >=20 > > > > Signed-off-by: Nickey Yang > > > > Signed-off-by: Heiko Stuebner > > >=20 > > > Hm, this v4 patch has been stalling here for *four full months*. > > >=20 > > > Which deity do we need to pray to get this one moving? ;-) > > >=20 > > > Seriously, can someone please apply this? > >=20 > > If you care about this driver, perhaps you'd like to review and provide > > a Reviewed-by? >=20 > Looks good to me, >=20 > Reviewed-by: Sean Paul I was aiming for a Reviewed-by from Ezequiel, but I'll take yours as well, thanks very much. Thierry --RIYY1s2vRbPFwWeW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlxPJuoACgkQ3SOs138+ s6GT3xAAktaol5tKv4eewJCyY+h+SfNaQKhlpn4LOE6oJenisSHpIhpjr6Mm7txx KUZ4MD83dStwvQbaSZFE3soipuJ2vKFIN5cZV2IRjL8Z4C5K+wUsEpckr9HY7mLk XN8fw152VVr5Fh5tVUajOkIHseuSBNMHh2Bt3y+vUJ51KSgQ5ebWkW73U/RF1K0t rXAfsSlF8Avf5BiiwQg7WFb/Vbx7PceF0eVmhL0cU7K1dfievfjSemqkSwRQIiBn jyNYunjr1woqcdcPBsvOlVhoQXMpLYfGOM1xc3wS8JFL4rcvTb6aESh/cCgJvq5O DSBY7qTZ8P4IMGy5x4TXpuGwVajXsHswi3evFmi/Uplf2By7HiKO1+mAXz2sUXgy qsQBGin149yfbfi/huHlUf/7TtSI0FMd+DQWWZjJWpUydQ73z4VwUCaKjJAytjOd RcHaXMEuh4+hyM1U6dNaPysYXoozA9YmvFe9rgWCsO7UWFg8HFT+gBMFq6AW0IlS mKFHK2O0ho5PLBdMI6zzCTQQ304+Prh+ckliNKuG9i/4MfmxxRmBkVmOKkJTuagq x9ks8/wFOIrH5neMo87Azua+zuK521sC5EaaPWO99UpTd+Rh9rad7JxOU6Mhp7+6 hEMyqvGcQG59/1e0coEHBoGd3SgXc3w+lM6vr0xMVs5yROjTSqM= =GFFm -----END PGP SIGNATURE----- --RIYY1s2vRbPFwWeW-- --===============1031205637== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1031205637==--