From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 11/11] drm/fb-helper: generic: Don't take module ref for fbcon Date: Tue, 29 Jan 2019 09:45:35 +0100 Message-ID: <20190129084535.GJ3271@phenom.ffwll.local> References: <20190120114318.49199-1-noralf@tronnes.org> <20190120114318.49199-12-noralf@tronnes.org> <20190121090522.GJ3271@phenom.ffwll.local> <7e7850bd-076b-194a-dd90-a219496a096c@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 680516E09C for ; Tue, 29 Jan 2019 08:45:40 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id y56so15280540edd.11 for ; Tue, 29 Jan 2019 00:45:40 -0800 (PST) Content-Disposition: inline In-Reply-To: <7e7850bd-076b-194a-dd90-a219496a096c@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: dri-devel@lists.freedesktop.org, david@lechnology.com List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKYW4gMjgsIDIwMTkgYXQgMDM6NDA6NDdQTSArMDEwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IAo+IAo+IERlbiAyMS4wMS4yMDE5IDEwLjA1LCBza3JldiBEYW5pZWwgVmV0dGVy Ogo+ID4gT24gU3VuLCBKYW4gMjAsIDIwMTkgYXQgMTI6NDM6MThQTSArMDEwMCwgTm9yYWxmIFRy w7hubmVzIHdyb3RlOgo+ID4+IEl0J3Mgbm93IHNhZmUgdG8gbGV0IGZiY29uIHVuYmluZCBhdXRv bWF0aWNhbGx5IG9uIGZiZGV2IHVucmVnaXN0ZXIuCj4gPj4gVGhlIGNyYXNoIHByb2JsZW0gd2Fz IGZpeGVkIGluIGNvbW1pdCAyMTIyYjQwNTgwZGQKPiA+PiAoImZiZGV2OiBmYmNvbjogRml4IHVu cmVnaXN0ZXIgY3Jhc2ggd2hlbiBtb3JlIHRoYW4gb25lIGZyYW1lYnVmZmVyIikKPiA+Pgo+ID4+ IFNpZ25lZC1vZmYtYnk6IE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgo+ID4+ IC0tLQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIHwgNiArKysrLS0KPiA+ PiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+Pgo+ ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+ID4+IGluZGV4IDMxZmNmOTRiZjgyNS4uNWQwMzI3 ZjYwM2JiIDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMK PiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gPj4gQEAgLTI5OTks NyArMjk5OSw4IEBAIHN0YXRpYyBpbnQgZHJtX2ZiZGV2X2ZiX29wZW4oc3RydWN0IGZiX2luZm8g KmluZm8sIGludCB1c2VyKQo+ID4+ICB7Cj4gPj4gIAlzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJf aGVscGVyID0gaW5mby0+cGFyOwo+ID4+ICAKPiA+PiAtCWlmICghdHJ5X21vZHVsZV9nZXQoZmJf aGVscGVyLT5kZXYtPmRyaXZlci0+Zm9wcy0+b3duZXIpKQo+ID4+ICsJLyogTm8gbmVlZCB0byB0 YWtlIGEgcmVmIGZvciBmYmNvbiBiZWNhdXNlIGl0IHVuYmluZHMgb24gdW5yZWdpc3RlciAqLwo+ ID4+ICsJaWYgKHVzZXIgJiYgIXRyeV9tb2R1bGVfZ2V0KGZiX2hlbHBlci0+ZGV2LT5kcml2ZXIt PmZvcHMtPm93bmVyKSkKPiA+IAo+ID4gTW9kdWxlIHJlZmNvdW50ICE9IGRyaXZlciByZWZjb3Vu dC4gWW91IGNhbiBhbHdheXMgdW5iaW5kIGEgZHJpdmVyIHRocm91Z2gKPiA+IHRoZSBzeXNmcyB1 bmJpbmQgZmlsZSwgbm8gbWF0dGVyIHdoZXRoZXIgdGhlIG1vZHVsZSBpcyBwaW5uZWQgb3Igbm90 LiBTbyBJCj4gPiB0aGluayBwaW5uZyB0aGUgbW9kdWxlIGlzIHN0aWxsIHRoZSByaWdodCB0aGlu ZyB0byBkbywganVzdCB0byBhdm9pZCByYWNlcwo+ID4gYW5kIGZ1biBzdHVmZi4KPiA+IAo+ID4g YnR3LCBJIGxvb2tlZCBpbnRvIG1ha2luZyBmYmRldiBob3R1bnBsdWcgc2FmZSAoaS5lLiBkcm1f ZGV2X2VudGVyL2V4aXQsCj4gPiBidXQgZm9yIGZiZGV2KSBvdmVyIHRoZSBob2xpZGF5cy4gRml4 aW5nIHRoYXQgcHJvcGVybHkgZm9yIGZiZGV2IHVzZXJzcGFjZQo+ID4gY2xpZW50cyBsb29rcyBs aWtlIHNlcmlvdXMgYW1vdW50cyBvZiB3b3JrLCBhbmQgSSB0aGluayBpdCdzIGltcG9zc2libGUK PiA+IGZvciBmYmNvbi4gT3IgYXQgbGVhc3QgSSBkaWRuJ3QgY29tZSB1cCB3aXRoIGEgd29ya2Fi bGUgaWRlYSB0byBzcHJpbmtsZQo+ID4gdGhlIGRldl9lbnRlci9leGl0IHN0dWZmIGFyb3VuZC4g Rm9yIHRoZSB1c2Vyc3BhY2Ugc2lkZSB0aGUgYmFzaWMKPiA+IGluZnJhc3RydWN0dXJlIHdpdGgg Z2V0X2ZiX2luZm8oKSBhbmQgcHV0X2ZiX2luZm8oKSBpcyB0aGVyZSBhbHJlYWR5Lgo+ID4gCj4g Cj4gZmJkZXYgYmxvY2tzIGZpbGUgb3BlcmF0aW9ucyBhZnRlciB1bnJlZ2lzdGVyIHRocm91Z2gg dGhpcyBmdW5jdGlvbjoKPiAKPiBzdGF0aWMgc3RydWN0IGZiX2luZm8gKmZpbGVfZmJfaW5mbyhz dHJ1Y3QgZmlsZSAqZmlsZSkKPiB7Cj4gCXN0cnVjdCBpbm9kZSAqaW5vZGUgPSBmaWxlX2lub2Rl KGZpbGUpOwo+IAlpbnQgZmJpZHggPSBpbWlub3IoaW5vZGUpOwo+IAlzdHJ1Y3QgZmJfaW5mbyAq aW5mbyA9IHJlZ2lzdGVyZWRfZmJbZmJpZHhdOwo+IAo+IAlpZiAoaW5mbyAhPSBmaWxlLT5wcml2 YXRlX2RhdGEpCj4gCQlpbmZvID0gTlVMTDsKPiAJcmV0dXJuIGluZm87Cj4gfQo+IAo+IHN0YXRp YyBpbnQgZG9fdW5yZWdpc3Rlcl9mcmFtZWJ1ZmZlcihzdHJ1Y3QgZmJfaW5mbyAqZmJfaW5mbykK PiB7Cj4gLi4uCj4gCXJlZ2lzdGVyZWRfZmJbZmJfaW5mby0+bm9kZV0gPSBOVUxMOwo+IC4uLgo+ IH0KPiAKPiBUaGUgb25seSB3YXkgZm9yIGZiZGV2IHVzZXJzcGFjZSB0byB0cmlnZ2VyIGRyaXZl ciBhY3Rpb25zIGlzIHRocm91Z2gKPiBtbWFwIGFuZCBkZWZpby4gQXQgZmlyc3QgSSBwbGFubmVk IHRvIHB1dCBkcm1fZGV2X2VudGVyL2V4aXQgaW4KPiBkcm1fZmJfaGVscGVyX2RpcnR5X3dvcmso KSwgYnV0IHJlYWxpc2VkIHRoYXQgdGhlIGRyaXZlciB3b3VsZCBuZWVkIHRvCj4gZG8gdGhlIHNh bWUgaW4gaXQncyBkaXJ0eSBmdW5jdGlvbiB0byBjb3ZlciBEUk0gdXNlcnNwYWNlIGFueXdheXMs IHNvIEkKPiBkcm9wcGVkIGl0LiBJdCdzIHRoZSBkcml2ZXIncyByZXNwb25zaWJpbGl0eSB0byBw cm90ZWN0IGl0J3MgcmVzb3VyY2VzLgoKVGhlIGFib3ZlIGlzIGFsbCBhYm91dCB0aGUgZHJpdmVy IHJlZmNvdW50aW5nLiBXaGljaCBkb2VzIGV4aXN0IChidXQgcmFjZXMKYmFkbHkpIGZvciBmYmRl di4gVGhlIHByb2JsZW0gaXMgeW91J3JlIGNoYW5naW5nIHRoZSBtb2R1bGUgcmVmY291bnQsCndo aWNoIGlzIHRoZXJlIHRvIG1ha2Ugc3VyZSB0aGUgZnVuY3Rpb25zIGRvbid0IGRpc2FwcGVhci4g Tm90ZSB0aGF0IG9uCnRoZSBkcm0gc2lkZSB3ZSBkbyB0aGUgZXhhY3Qgc2FtZSB0aGluZywgc28g bGVhc3QgZm9yIHN5bW1ldHJ5IHJlYXNvbnMgSQp0aGluayB3ZSBzaG91bGQga2VlcCBpdC4gVGhl IHJlZmNvdW50aW5nIGlzIGRvbmUgYnkgdGhlIGZpbGUgb3Blbi9jbG9zZQpmdW5jdGlvbnMgc2lu Y2Ugd2Ugc2V0IGZvcHMtPm93bmVyLCBub3QgZHJtIGNvZGUgaXRzZWxmLCBidXQgaXQncyB0aGVy ZS4KIAo+IEFzIGZvciBmYmNvbiwgeWVzIHRoaXMgaXMgYWxsIGEgc3BhZ2hldHRpIG1vbnN0ZXIs IHNvIGJldHRlciBzYWZlIHRoYW4KPiBzb3JyeSBJIGd1ZXNzLiBBbmQgaXQncyBqdXN0IGRldmVs b3BlcnMgdGhhdCB3b3VsZCBiZW5lZml0IGZyb20gdGhpcwo+IGFueXdheXMsIG5vdCBoYXZpbmcg dG8gdW5iaW5kIGZiY29uIGJlZm9yZSB1bmxhb2RpbmcgdGhlIGRyaXZlciBtb2R1bGUuCgpIbSB5 ZWFoLCBtYWtlIHNlbnNlLiBPbiBzZWNvbmQgdGhvdWdodCwgb24gdGhpcyBwYXRjaDoKClJldmll d2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgotRGFuaWVsCgo+ IAo+IE5vcmFsZi4KPiAKPiA+IENoZWVycywgRGFuaWVsCj4gPiAKPiA+PiAgCQlyZXR1cm4gLUVO T0RFVjsKPiA+PiAgCj4gPj4gIAlyZXR1cm4gMDsKPiA+PiBAQCAtMzAwOSw3ICszMDEwLDggQEAg c3RhdGljIGludCBkcm1fZmJkZXZfZmJfcmVsZWFzZShzdHJ1Y3QgZmJfaW5mbyAqaW5mbywgaW50 IHVzZXIpCj4gPj4gIHsKPiA+PiAgCXN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIgPSBp bmZvLT5wYXI7Cj4gPj4gIAo+ID4+IC0JbW9kdWxlX3B1dChmYl9oZWxwZXItPmRldi0+ZHJpdmVy LT5mb3BzLT5vd25lcik7Cj4gPj4gKwlpZiAodXNlcikKPiA+PiArCQltb2R1bGVfcHV0KGZiX2hl bHBlci0+ZGV2LT5kcml2ZXItPmZvcHMtPm93bmVyKTsKPiA+PiAgCj4gPj4gIAlyZXR1cm4gMDsK PiA+PiAgfQo+ID4+IC0tIAo+ID4+IDIuMjAuMQo+ID4+Cj4gPj4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+PiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0 Cj4gPj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4+IGh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCj4gPiAKCi0tIApEYW5p ZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxv Zy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK