From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v4.1 3/3] drm/i915/gen9+: Add support for pipe background color (v4) Date: Wed, 30 Jan 2019 23:08:56 +0200 Message-ID: <20190130210856.GT20097@intel.com> References: <20190130185122.10322-1-matthew.d.roper@intel.com> <20190130185122.10322-4-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190130185122.10322-4-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: wei.c.li@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, harish.krupo.kps@intel.com List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKYW4gMzAsIDIwMTkgYXQgMTA6NTE6MjJBTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBHZW45KyBwbGF0Zm9ybXMgYWxsb3cgQ1JUQydzIHRvIGJlIHByb2dyYW1tZWQgd2l0aCBh IGJhY2tncm91bmQvY2FudmFzCj4gY29sb3IgYmVsb3cgdGhlIHByb2dyYW1tYWJsZSBwbGFuZXMu ICBMZXQncyBleHBvc2UgdGhpcyBmb3IgdXNlIGJ5Cj4gY29tcG9zaXRvcnMuCj4gCj4gdjI6Cj4g IC0gU3BsaXQgb3V0IGJnY29sb3Igc2FuaXRpemF0aW9uIGFuZCBwcm9ncmFtbWluZyBvZiBjc2Mv Z2FtbWEgYml0cyB0byBhCj4gICAgc2VwYXJhdGUgcGF0Y2ggdGhhdCB3ZSBjYW4gbGFuZCBiZWZv cmUgdGhlIEFCSSBjaGFuZ2VzIGFyZSByZWFkeSB0bwo+ICAgIGdvIGluLiAgKFZpbGxlKQo+ICAt IENoYW5nZSBhIHRlbXBvcmFyeSB2YXJpYWJsZSBuYW1lIHRvIGJlIG1vcmUgY29uc2lzdGVudCB3 aXRoCj4gICAgb3RoZXIgc2ltaWxhciBmdW5jdGlvbnMuICAoVmlsbGUpCj4gIC0gQ2hhbmdlIHJl Z2lzdGVyIG5hbWUgdG8gU0tMX0NBTlZBUyBmb3IgY29uc2lzdGVuY3kgd2l0aCB0aGUKPiAgICBD SFZfQ0FOVkFTIHJlZ2lzdGVyLgo+IAo+IHYzOgo+ICAtIFN3aXRjaCByZWdpc3RlciBuYW1lIGJh Y2sgdG8gU0tMX0JPVFRPTV9DT0xPUi4gIChWaWxsZSkKPiAgLSBVc2Ugbm9uLV9GVyByZWdpc3Rl ciB3cml0ZS4gIChWaWxsZSkKPiAgLSBNaW5vciBwYXJhbWV0ZXIgcmVuYW1lIGZvciBjb25zaXN0 ZW5jeS4gIChWaWxsZSkKPiAKPiB2NDoKPiAgLSBSZW1vdmVkIHVzZSBvZiBiZ2NvbG9yX2NoYW5n ZWQgZmxhZy4KPiAKPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENjOiB3 ZWkuYy5saUBpbnRlbC5jb20KPiBDYzogaGFyaXNoLmtydXBvLmtwc0BpbnRlbC5jb20KPiBDYzog VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQt b2ZmLWJ5OiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyAgfCAgOSArKysrKysrCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDQ2ICsrKysrKysrKysrKysrKysrKysr KysrKysrKy0tLS0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKyksIDEx IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2RlYnVnZnMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gaW5kZXgg ZmEyYzIyNmZjNzc5Li44YjA3ZGQwNWM1NGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rl YnVnZnMuYwo+IEBAIC0zMDkyLDYgKzMwOTIsMTUgQEAgc3RhdGljIGludCBpOTE1X2Rpc3BsYXlf aW5mbyhzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQgKnVudXNlZCkKPiAgCQkJaW50ZWxfcGxhbmVf aW5mbyhtLCBjcnRjKTsKPiAgCQl9Cj4gIAo+ICsJCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49 IDkgJiYgcGlwZV9jb25maWctPmJhc2UuYWN0aXZlKSB7Cj4gKwkJCXVpbnQ2NF90IGJhY2tncm91 bmQgPSBwaXBlX2NvbmZpZy0+YmFzZS5iZ2NvbG9yOwo+ICsKPiArCQkJc2VxX3ByaW50ZihtLCAi XHRiYWNrZ3JvdW5kIGNvbG9yICgxMGJwYyk6IHI9JXggZz0leCBiPSV4XG4iLAo+ICsJCQkJICAg RFJNX0FSR0JfUkVEKGJhY2tncm91bmQsIDEwKSwKPiArCQkJCSAgIERSTV9BUkdCX0dSRUVOKGJh Y2tncm91bmQsIDEwKSwKPiArCQkJCSAgIERSTV9BUkdCX0JMVUUoYmFja2dyb3VuZCwgMTApKTsK PiArCQl9Cj4gKwo+ICAJCXNlcV9wcmludGYobSwgIlx0dW5kZXJydW4gcmVwb3J0aW5nOiBjcHU9 JXMgcGNoPSVzIFxuIiwKPiAgCQkJICAgeWVzbm8oIWNydGMtPmNwdV9maWZvX3VuZGVycnVuX2Rp c2FibGVkKSwKPiAgCQkJICAgeWVzbm8oIWNydGMtPnBjaF9maWZvX3VuZGVycnVuX2Rpc2FibGVk KSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IGEwMjVlZmIxZDdj Ni4uYmM3ODc0M2UxNDExIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ IEBAIC0zODk2LDYgKzM4OTYsMjggQEAgdm9pZCBpbnRlbF9maW5pc2hfcmVzZXQoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJY2xlYXJfYml0KEk5MTVfUkVTRVRfTU9ERVNF VCwgJmRldl9wcml2LT5ncHVfZXJyb3IuZmxhZ3MpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZAo+ ICtza2xfdXBkYXRlX2JhY2tncm91bmRfY29sb3IoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKmNydGNfc3RhdGUpCj4gK3sKPiArCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gdG9faW50 ZWxfY3J0YyhjcnRjX3N0YXRlLT5iYXNlLmNydGMpOwo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRjLT5iYXNlLmRldik7Cj4gKwl1aW50NjRfdCBwcm9w dmFsID0gY3J0Y19zdGF0ZS0+YmFzZS5iZ2NvbG9yOwo+ICsJdWludDMyX3QgdG1wOwo+ICsKPiAr CS8qIEhhcmR3YXJlIGlzIHByb2dyYW1tZWQgd2l0aCAxMCBiaXRzIG9mIHByZWNpc2lvbiAqLwo+ ICsJdG1wID0gRFJNX0FSR0JfUkVEKHByb3B2YWwsIDEwKSA8PCAyMAo+ICsJICAgIHwgRFJNX0FS R0JfR1JFRU4ocHJvcHZhbCwgMTApIDw8IDEwCj4gKwkgICAgfCBEUk1fQVJHQl9CTFVFKHByb3B2 YWwsIDEwKTsKPiArCj4gKwkvKgo+ICsJICogU2V0IENTQyBhbmQgZ2FtbWEgZm9yIGJvdHRvbSBj b2xvciB0byBlbnN1cmUgYmFja2dyb3VuZCBwaXhlbHMKPiArCSAqIHJlY2VpdmUgdGhlIHNhbWUg Y29sb3IgdHJhbnNmb3JtYXRpb25zIGFzIHBsYW5lIGNvbnRlbnQuCj4gKwkgKi8KPiArCXRtcCB8 PSBTS0xfQk9UVE9NX0NPTE9SX0NTQ19FTkFCTEUgfCBTS0xfQk9UVE9NX0NPTE9SX0dBTU1BX0VO QUJMRTsKPiArCj4gKwlJOTE1X1dSSVRFKFNLTF9CT1RUT01fQ09MT1IoY3J0Yy0+cGlwZSksIHRt cCk7Cj4gK30KClJlYWRvdXQgKyBzdGF0ZSBjaGVjayB3b3VsZCBiZSBuaWNlIHRvby4KCkFueXdh eXMKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cgo+ICsKPiAgc3RhdGljIHZvaWQgaW50ZWxfdXBkYXRlX3BpcGVfY29uZmlnKGNvbnN0 IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSwKPiAgCQkJCSAgICAgY29u c3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRlKQo+ICB7Cj4gQEAgLTM5 MzEsMTUgKzM5NTMsOCBAQCBzdGF0aWMgdm9pZCBpbnRlbF91cGRhdGVfcGlwZV9jb25maWcoY29u c3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YQo+ICAJCQlpcm9ubGFrZV9w Zml0X2Rpc2FibGUob2xkX2NydGNfc3RhdGUpOwo+ICAJfQo+ICAKPiAtCS8qCj4gLQkgKiBXZSBk b24ndCAoeWV0KSBhbGxvdyB1c2Vyc3BhY2UgdG8gY29udHJvbCB0aGUgcGlwZSBiYWNrZ3JvdW5k IGNvbG9yLAo+IC0JICogc28gZm9yY2UgaXQgdG8gYmxhY2ssIGJ1dCBhcHBseSBwaXBlIGdhbW1h IGFuZCBDU0Mgc28gdGhhdCBpdHMKPiAtCSAqIGhhbmRsaW5nIHdpbGwgbWF0Y2ggaG93IHdlIHBy b2dyYW0gb3VyIHBsYW5lcy4KPiAtCSAqLwo+ICAJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0g OSkKPiAtCQlJOTE1X1dSSVRFKFNLTF9CT1RUT01fQ09MT1IoY3J0Yy0+cGlwZSksCj4gLQkJCSAg IFNLTF9CT1RUT01fQ09MT1JfR0FNTUFfRU5BQkxFIHwKPiAtCQkJICAgU0tMX0JPVFRPTV9DT0xP Ul9DU0NfRU5BQkxFKTsKPiArCQlza2xfdXBkYXRlX2JhY2tncm91bmRfY29sb3IobmV3X2NydGNf c3RhdGUpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBpbnRlbF9mZGlfbm9ybWFsX3RyYWluKHN0 cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+IEBAIC0xMTA0Miw2ICsxMTA1Nyw4IEBAIHN0YXRpYyBp bnQgaW50ZWxfY3J0Y19hdG9taWNfY2hlY2soc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJc3Ry dWN0IGludGVsX2NydGMgKmludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGNydGMpOwo+ICAJc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnID0KPiAgCQl0b19pbnRlbF9jcnRjX3N0 YXRlKGNydGNfc3RhdGUpOwo+ICsJc3RydWN0IGRybV9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0 ZSA9Cj4gKwkJZHJtX2F0b21pY19nZXRfb2xkX2NydGNfc3RhdGUoY3J0Y19zdGF0ZS0+c3RhdGUs IGNydGMpOwo+ICAJaW50IHJldDsKPiAgCWJvb2wgbW9kZV9jaGFuZ2VkID0gbmVlZHNfbW9kZXNl dChjcnRjX3N0YXRlKTsKPiAgCj4gQEAgLTExMDY5LDYgKzExMDg2LDkgQEAgc3RhdGljIGludCBp bnRlbF9jcnRjX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJY3J0Y19z dGF0ZS0+cGxhbmVzX2NoYW5nZWQgPSB0cnVlOwo+ICAJfQo+ICAKPiArCWlmIChjcnRjX3N0YXRl LT5iZ2NvbG9yICE9IG9sZF9jcnRjX3N0YXRlLT5iZ2NvbG9yKQo+ICsJCXBpcGVfY29uZmlnLT51 cGRhdGVfcGlwZSA9IHRydWU7Cj4gKwo+ICAJcmV0ID0gMDsKPiAgCWlmIChkZXZfcHJpdi0+ZGlz cGxheS5jb21wdXRlX3BpcGVfd20pIHsKPiAgCQlyZXQgPSBkZXZfcHJpdi0+ZGlzcGxheS5jb21w dXRlX3BpcGVfd20ocGlwZV9jb25maWcpOwo+IEBAIC0xNDIzOCw2ICsxNDI1OCw5IEBAIHN0YXRp YyBpbnQgaW50ZWxfY3J0Y19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwg ZW51bSBwaXBlIHBpcGUpCj4gIAo+ICAJV0FSTl9PTihkcm1fY3J0Y19pbmRleCgmaW50ZWxfY3J0 Yy0+YmFzZSkgIT0gaW50ZWxfY3J0Yy0+cGlwZSk7Cj4gIAo+ICsJaWYgKElOVEVMX0dFTihkZXZf cHJpdikgPj0gOSkKPiArCQlkcm1fY3J0Y19hZGRfYmdjb2xvcl9wcm9wZXJ0eSgmaW50ZWxfY3J0 Yy0+YmFzZSk7Cj4gKwo+ICAJcmV0dXJuIDA7Cj4gIAo+ICBmYWlsOgo+IEBAIC0xNTQ3OCw2ICsx NTUwMSw5IEBAIHN0YXRpYyB2b2lkIGludGVsX3Nhbml0aXplX2NydGMoc3RydWN0IGludGVsX2Ny dGMgKmNydGMsCj4gIAlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSA9IHRvX2lu dGVsX2NydGNfc3RhdGUoY3J0Yy0+YmFzZS5zdGF0ZSk7Cj4gIAllbnVtIHRyYW5zY29kZXIgY3B1 X3RyYW5zY29kZXIgPSBjcnRjX3N0YXRlLT5jcHVfdHJhbnNjb2RlcjsKPiAgCj4gKwkvKiBBbHdh eXMgZm9yY2UgYmdjb2xvciB0byBzb2xpZCBibGFjayAqLwo+ICsJY3J0Y19zdGF0ZS0+YmFzZS5i Z2NvbG9yID0gZHJtX2FyZ2IoMTYsIDB4RkZGRiwgMCwgMCwgMCk7Cj4gKwo+ICAJLyogQ2xlYXIg YW55IGZyYW1lIHN0YXJ0IGRlbGF5cyB1c2VkIGZvciBkZWJ1Z2dpbmcgbGVmdCBieSB0aGUgQklP UyAqLwo+ICAJaWYgKGNydGMtPmFjdGl2ZSAmJiAhdHJhbnNjb2Rlcl9pc19kc2koY3B1X3RyYW5z Y29kZXIpKSB7Cj4gIAkJaTkxNV9yZWdfdCByZWcgPSBQSVBFQ09ORihjcHVfdHJhbnNjb2Rlcik7 Cj4gQEAgLTE1NTA0LDkgKzE1NTMwLDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfc2FuaXRpemVfY3J0 YyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgCQkgKiBnYW1tYSBhbmQgQ1NDIHRvIG1hdGNo IGhvdyB3ZSBwcm9ncmFtIG91ciBwbGFuZXMuCj4gIAkJICovCj4gIAkJaWYgKElOVEVMX0dFTihk ZXZfcHJpdikgPj0gOSkKPiAtCQkJSTkxNV9XUklURShTS0xfQk9UVE9NX0NPTE9SKGNydGMtPnBp cGUpLAo+IC0JCQkJICAgU0tMX0JPVFRPTV9DT0xPUl9HQU1NQV9FTkFCTEUgfAo+IC0JCQkJICAg U0tMX0JPVFRPTV9DT0xPUl9DU0NfRU5BQkxFKTsKPiArCQkJc2tsX3VwZGF0ZV9iYWNrZ3JvdW5k X2NvbG9yKGNydGNfc3RhdGUpOwo+ICAJfQo+ICAKPiAgCS8qIEFkanVzdCB0aGUgc3RhdGUgb2Yg dGhlIG91dHB1dCBwaXBlIGFjY29yZGluZyB0byB3aGV0aGVyIHdlCj4gLS0gCj4gMi4xNC41Cgot LSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=