From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] staging: android: ion: fix sys heap pool's gfp_flags
Date: Fri, 1 Feb 2019 11:15:30 +0300
Message-ID: <20190201081530.GC14343@kadam>
References: <1549004386-38778-1-git-send-email-saberlily.xia@hisilicon.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <driverdev-devel-bounces@linuxdriverproject.org>
Content-Disposition: inline
In-Reply-To: <1549004386-38778-1-git-send-email-saberlily.xia@hisilicon.com>
List-Unsubscribe: <http://driverdev.linuxdriverproject.org/mailman/options/driverdev-devel>,
 <mailto:driverdev-devel-request@linuxdriverproject.org?subject=unsubscribe>
List-Archive: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/>
List-Post: <mailto:driverdev-devel@linuxdriverproject.org>
List-Help: <mailto:driverdev-devel-request@linuxdriverproject.org?subject=help>
List-Subscribe: <http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel>,
 <mailto:driverdev-devel-request@linuxdriverproject.org?subject=subscribe>
Errors-To: driverdev-devel-bounces@linuxdriverproject.org
Sender: "devel" <driverdev-devel-bounces@linuxdriverproject.org>
To: Qing Xia <saberlily.xia@hisilicon.com>
Cc: devel@driverdev.osuosl.org, yudongbin@hisilicon.com, tkjos@android.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kongfei@hisilicon.com, linaro-mm-sig@lists.linaro.org, arve@android.com, puck.chen@hisilicon.com, daniel.liuyi@hisilicon.com, maco@android.com, sumit.semwal@linaro.org
List-Id: dri-devel@lists.freedesktop.org

On Fri, Feb 01, 2019 at 02:59:46PM +0800, Qing Xia wrote:
> In the first loop, gfp_flags will be modified to high_order_gfp_flags,
> and there will be no chance to change back to low_order_gfp_flags.
> 
> Fixes: e7f63771 ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc")

Huh...  Presumably you found this bug just by reading the code.  I
wonder how it affects runtime?

regards,
dan carpenter