From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH AUTOSEL 4.19 083/258] drm: Move drm_mode_setcrtc() local re-init to failure path Date: Sat, 2 Feb 2019 12:32:16 -0500 Message-ID: <20190202173216.GZ3973@sasha-vm> References: <20190128155924.51521-1-sashal@kernel.org> <20190128155924.51521-83-sashal@kernel.org> <20190128210341.GT114153@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Content-Disposition: inline In-Reply-To: <20190128210341.GT114153@art_vandelay> Sender: stable-owner@vger.kernel.org To: Sean Paul Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sean Paul , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Mon, Jan 28, 2019 at 04:03:41PM -0500, Sean Paul wrote: >On Mon, Jan 28, 2019 at 10:56:29AM -0500, Sasha Levin wrote: >> From: Sean Paul >> >> [ Upstream commit c232e9f41b136c141df9938024e521191a7b910d ] >> >> Instead of always re-initializing the variables we need to clean up on >> out, move the re-initialization into the branch that goes back to retry >> label. >> >> This is a lateral move right now, but will allow us to pull out the >> modeset locking into common code. I kept this change separate to make >> things easier to review. >> >> Changes in v2: >> - None >> >> Reviewed-by: Daniel Vetter >> Signed-off-by: Sean Paul >> Link: https://patchwork.freedesktop.org/patch/msgid/20181129150423.239081-2-sean@poorly.run >> Signed-off-by: Sasha Levin > >This probably doesn't need to get pulled back to stable. It was a pre-cursor for >some new helper macros that also don't need to be pulled back. > >(Same comment for the 4.20 version) Now dropped, thank you.