From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 4/4] drm/panel: Add Rondo RB070D30 panel Date: Tue, 5 Feb 2019 16:31:38 +0100 Message-ID: <20190205153138.ofvsxbajmm44natx@flea> References: <15b81a58eddd5d3fbfa418293cf1c817ef46423a.1548236066.git-series.maxime.ripard@bootlin.com> <20190126153946.GB17756@ravnborg.org> <20190129153748.4jpx4kkortmlgq4r@flea> <20190129154833.GA22238@ravnborg.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0339814634==" Return-path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by gabe.freedesktop.org (Postfix) with ESMTPS id E08AD6E6AB for ; Tue, 5 Feb 2019 15:31:42 +0000 (UTC) In-Reply-To: <20190129154833.GA22238@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sam Ravnborg Cc: Konstantin Sudakov , bbrezillon@kernel.org, dri-devel@lists.freedesktop.org, Paul Kocialkowski , Chen-Yu Tsai , Sean Paul , Thomas Petazzoni , Jagan Teki , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org --===============0339814634== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fur4zl6sdynv7n6b" Content-Disposition: inline --fur4zl6sdynv7n6b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Sam, On Tue, Jan 29, 2019 at 04:48:33PM +0100, Sam Ravnborg wrote: > > > > + } > > > > + > > > > + drm_mode_set_name(mode); > > > > + > > > > + mode->type =3D DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; > > > > + drm_mode_probed_add(connector, mode); > > > > + > > > > + panel->connector->display_info.bpc =3D 8; > > > > + panel->connector->display_info.width_mm =3D 154; > > > > + panel->connector->display_info.height_mm =3D 85; > > > See comment on height above. > > > Same goes for bpc > >=20 > > Sorry, I'm not sure to follow you here. bpc and height are both set? >=20 > I assumed that if we had specified height and width in display_mode > then we did not have to do it here. But I may be wrong. It looks like it's not done by the core, but panel-simple simply copies it, so I'll do it as well. Thanks for the suggestion! Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --fur4zl6sdynv7n6b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXFmsWgAKCRDj7w1vZxhR xScVAQDpdrNCJQJrJsogvF71LeaoutFHtNdkfVooENKBFCGPlwEArOJmMvMcPMsM ntGFnTeclFzQgSva9F75LlgKuKje2AQ= =NQ8z -----END PGP SIGNATURE----- --fur4zl6sdynv7n6b-- --===============0339814634== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0339814634==--