From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] staging/vboxvideo: Add TODO Date: Wed, 6 Feb 2019 16:58:56 +0100 Message-ID: <20190206155856.GK3271@phenom.ffwll.local> References: <20190204103114.30772-1-daniel.vetter@ffwll.ch> <20190204103114.30772-2-daniel.vetter@ffwll.ch> <20190204185416.GC2834@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190204185416.GC2834@ravnborg.org> Sender: linux-kernel-owner@vger.kernel.org To: Sam Ravnborg Cc: Daniel Vetter , DRI Development , LKML , Hans de Goede , Nicholas Mc Guire , Greg Kroah-Hartman , Daniel Vetter , Fabio Rafael da Rosa List-Id: dri-devel@lists.freedesktop.org On Mon, Feb 04, 2019 at 07:54:16PM +0100, Sam Ravnborg wrote: > Hi Daniel > > On Mon, Feb 04, 2019 at 11:31:14AM +0100, Daniel Vetter wrote: > > Noticed why wonder what vboxvideo is using the ->master_set/drop hooks > > for. > Can you improve the gammar a little, I find it hard to read. > > > > > Signed-off-by: Daniel Vetter > > Cc: Greg Kroah-Hartman > > Cc: Fabio Rafael da Rosa > > Cc: Nicholas Mc Guire > > Cc: Daniel Vetter > > Cc: Hans de Goede > > --- > > drivers/staging/vboxvideo/TODO | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/staging/vboxvideo/TODO b/drivers/staging/vboxvideo/TODO > > index 2e0f99c3f10c..2953e7f794fb 100644 > > --- a/drivers/staging/vboxvideo/TODO > > +++ b/drivers/staging/vboxvideo/TODO > > @@ -1,5 +1,7 @@ > > TODO: > > -Get a full review from the drm-maintainers on dri-devel done on this driver > > +-Drop all the logic around initial_mode_queried/master_set&_drop and everything > > +related to this. kms clients can handle hotplugs. > > -Extend this TODO with the results of that review > > > > Please send any patches to Greg Kroah-Hartman , > > The syntax around "master_set&_drop" could be better. > I wondered if the "&" was some rst syntax. > > But anyway, despite grammar nit and syntax nit: > Reviewed-by: Sam Ravnborg Both patches queued for 5.1 in drm-misc, thanks for taking a look. > Which bring me back to a question asked a week ago or so. > What is missing before we can move vboxvideo out of staging/ I think it boils down to someone needs to submit it and we'll take a look. > Could we carry a few TODO items over in drm/ ar do we need a clean TODO? We carry todos in drm too, it's going to be a judgement call. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch