On Wed, Feb 13, 2019 at 11:13:23AM +0100, David SantamarĂ­a Rogado wrote: > Sorry previous one wasn't signed off by. And now you've got this comment in the commit message that's going to confuse people looking at the log. It's usually to put this kind of comment below the --- line... > The (void *) casting in the driver_data variable assignment is superfluous. > Spotted by Jani Nikula. > > Signed-off-by: David SantamarĂ­a Rogado > --- ... right here. > drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) Otherwise, looks good to me: Acked-by: Thierry Reding