From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Simon Horman <horms@verge.net.au>
Cc: linux-renesas-soc@vger.kernel.org,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 5/6] arm64: dts: renesas: r8a77990: ebisu: Enable LVDS1 encoder
Date: Fri, 15 Feb 2019 13:44:43 +0200 [thread overview]
Message-ID: <20190215114443.GA6737@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20190123100303.yujjpgm7wqxp2e4b@verge.net.au>
Hi Simon,
On Wed, Jan 23, 2019 at 11:03:04AM +0100, Simon Horman wrote:
> On Wed, Jan 23, 2019 at 11:55:52AM +0200, Laurent Pinchart wrote:
> > On Wed, Jan 23, 2019 at 09:56:57AM +0100, Simon Horman wrote:
> >> On Wed, Jan 23, 2019 at 12:54:04AM +0200, Laurent Pinchart wrote:
> >>> The LVDS1 encoder must supply a pixel clock to the DU for the DPAD
> >>> output when the LVDS0 encoder is used. Enable it despite its output not
> >>> being connected.
> >>>
> >>> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> >>> ---
> >>> Changes since v1:
> >>>
> >>> - Add a comment in the DT to explain why the LVDS1 encoder needs to be
> >>> enabled.
> >>
> >> Thanks,
> >>
> >> This looks fine to me but I will wait to see if there are other reviews
> >> before applying.
> >>
> >> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > Please note that this will likely cause probe failures if applied
> > without the driver patches from this series. Would it be OK to merge the
> > DT changes through the DRM tree ?
>
> I'm not sure that the probe failures are a problem unless they move
> something that was in a working state to a non-working state. Nonetheless
> they are at the very least not very nice.
>
> I generally shy away from having DT patches merged in other trees
> to avoid the chance of merge conflicts (that need to be resolved by Linus).
> What is your feeling on the risk of such a conflict?
I would have said low, but given that it's too late to get the DT
changes in v5.1 anyway, it's no big deal. The driver patches have been
merged for v5.1, so could you queue the DT changes for v5.2 ?
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-02-15 11:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 22:53 [PATCH v2 0/6] R-Car DU DPAD support for D3 and E3 Laurent Pinchart
2019-01-22 22:54 ` [PATCH v2 1/6] drm: rcar-du: Simplify encoder registration Laurent Pinchart
2019-01-22 22:54 ` [PATCH v2 2/6] drm: rcar-du: lvds: Don't fail probe if output is not connected on D3/E3 Laurent Pinchart
2019-01-22 22:54 ` [PATCH v2 3/6] drm: rcar-du: lvds: Add API to enable/disable clock output Laurent Pinchart
2019-01-22 22:54 ` [PATCH v2 4/6] drm: rcar-du: Turn LVDS clock output on/off for DPAD0 output on D3/E3 Laurent Pinchart
2019-01-22 22:54 ` [PATCH v2 5/6] arm64: dts: renesas: r8a77990: ebisu: Enable LVDS1 encoder Laurent Pinchart
2019-01-23 8:56 ` Simon Horman
2019-01-23 9:55 ` Laurent Pinchart
2019-01-23 10:03 ` Simon Horman
2019-02-15 11:44 ` Laurent Pinchart [this message]
2019-02-25 9:13 ` Simon Horman
2019-01-22 22:54 ` [PATCH v2 6/6] arm64: dts: renesas: r8a77995: draak: " Laurent Pinchart
2019-01-23 8:57 ` Simon Horman
2019-02-25 7:44 ` [PATCH v2 0/6] R-Car DU DPAD support for D3 and E3 Kuninori Morimoto
2019-02-25 8:30 ` Laurent Pinchart
2019-02-25 8:40 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215114443.GA6737@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=horms@verge.net.au \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox