From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 5/7] media: vsp1: Refactor vsp1_video_complete_buffer() for later reuse Date: Tue, 19 Feb 2019 01:43:42 +0200 Message-ID: <20190218234342.GD5082@pendragon.ideasonboard.com> References: <20190217024852.23328-1-laurent.pinchart+renesas@ideasonboard.com> <20190217024852.23328-6-laurent.pinchart+renesas@ideasonboard.com> <7b388ea1-fc35-01b9-64a4-7710068cb5e1@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 915F4891FD for ; Mon, 18 Feb 2019 23:43:48 +0000 (UTC) Content-Disposition: inline In-Reply-To: <7b388ea1-fc35-01b9-64a4-7710068cb5e1@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKT24gU3VuLCBGZWIgMTcsIDIwMTkgYXQgMDg6MzU6MjVQTSArMDAwMCwgS2ll cmFuIEJpbmdoYW0gd3JvdGU6Cj4gT24gMTcvMDIvMjAxOSAwMjo0OCwgTGF1cmVudCBQaW5jaGFy dCB3cm90ZToKPiA+IFRoZSB2c3AxX3ZpZGVvX2NvbXBsZXRlX2J1ZmZlcigpIGZ1bmN0aW9uIGNv bXBsZXRlcyB0aGUgY3VycmVudCBidWZmZXIKPiA+IGFuZCByZXR1cm5zIGEgcG9pbnRlciB0byB0 aGUgbmV4dCBidWZmZXIuIFNwbGl0IHRoZSBjb2RlIHRoYXQgY29tcGxldGVzCj4gPiB0aGUgYnVm ZmVyIHRvIGEgc2VwYXJhdGUgZnVuY3Rpb24gZm9yIGxhdGVyIHJldXNlLCBhbmQgcmVuYW1lCj4g PiB2c3AxX3ZpZGVvX2NvbXBsZXRlX2J1ZmZlcigpIHRvIHZzcDFfdmlkZW9fY29tcGxldGVfbmV4 dF9idWZmZXIoKS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1 cmVudC5waW5jaGFydCtyZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+Cj4gCj4gVGhpcyBsb29rcyBn b29kIHRvIG1lIC0gZXhjZXB0IHBlcmhhcHMgdGhlIGRvY3VtZW50YXRpb24gL21pZ2h0LyBuZWVk Cj4gc29tZSByZWZyZXNoLiBXaXRoIG9yIHdpdGhvdXQgdXBkYXRlcyB0aGVyZSwgdGhlIGNvZGUg Y2hhbmdlcyBsb29rIGdvb2QKPiB0byBtZToKPiAKPiBSZXZpZXdlZC1ieTogS2llcmFuIEJpbmdo YW0gPGtpZXJhbi5iaW5naGFtK3JlbmVzYXNAaWRlYXNvbmJvYXJkLmNvbT4KPiAKPiA+IC0tLQo+ ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX3ZpZGVvLmMgfCAzNSArKysrKysr KysrKysrKy0tLS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwg MTUgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3BsYXRm b3JtL3ZzcDEvdnNwMV92aWRlby5jIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFf dmlkZW8uYwo+ID4gaW5kZXggMzI4ZDY4NjE4OWJlLi5jZmJhYjE2YzQ4MjAgMTAwNjQ0Cj4gPiAt LS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV92aWRlby5jCj4gPiArKysgYi9k cml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV92aWRlby5jCj4gPiBAQCAtMzAwLDggKzMw MCwyMiBAQCBzdGF0aWMgaW50IHZzcDFfdmlkZW9fcGlwZWxpbmVfc2V0dXBfcGFydGl0aW9ucyhz dHJ1Y3QgdnNwMV9waXBlbGluZSAqcGlwZSkKPiA+ICAgKiBQaXBlbGluZSBNYW5hZ2VtZW50Cj4g PiAgICovCj4gPiAgCj4gPiArc3RhdGljIHZvaWQgdnNwMV92aWRlb19jb21wbGV0ZV9idWZmZXIo c3RydWN0IHZzcDFfdmlkZW8gKnZpZGVvLAo+ID4gKwkJCQkgICAgICAgc3RydWN0IHZzcDFfdmIy X2J1ZmZlciAqYnVmZmVyKQo+ID4gK3sKPiA+ICsJc3RydWN0IHZzcDFfcGlwZWxpbmUgKnBpcGUg PSB2aWRlby0+cndwZi0+ZW50aXR5LnBpcGU7Cj4gPiArCXVuc2lnbmVkIGludCBpOwo+ID4gKwo+ ID4gKwlidWZmZXItPmJ1Zi5zZXF1ZW5jZSA9IHBpcGUtPnNlcXVlbmNlOwo+ID4gKwlidWZmZXIt PmJ1Zi52YjJfYnVmLnRpbWVzdGFtcCA9IGt0aW1lX2dldF9ucygpOwo+ID4gKwlmb3IgKGkgPSAw OyBpIDwgYnVmZmVyLT5idWYudmIyX2J1Zi5udW1fcGxhbmVzOyArK2kpCj4gPiArCQl2YjJfc2V0 X3BsYW5lX3BheWxvYWQoJmJ1ZmZlci0+YnVmLnZiMl9idWYsIGksCj4gPiArCQkJCSAgICAgIHZi Ml9wbGFuZV9zaXplKCZidWZmZXItPmJ1Zi52YjJfYnVmLCBpKSk7Cj4gPiArCXZiMl9idWZmZXJf ZG9uZSgmYnVmZmVyLT5idWYudmIyX2J1ZiwgVkIyX0JVRl9TVEFURV9ET05FKTsKPiA+ICt9Cj4g PiArCj4gPiAgLyoKPiA+IC0gKiB2c3AxX3ZpZGVvX2NvbXBsZXRlX2J1ZmZlciAtIENvbXBsZXRl IHRoZSBjdXJyZW50IGJ1ZmZlcgo+ID4gKyAqIHZzcDFfdmlkZW9fY29tcGxldGVfbmV4dF9idWZm ZXIgLSBDb21wbGV0ZSB0aGUgY3VycmVudCBidWZmZXIKPiAKPiBTaG91bGQgdGhlIGJyaWVmIGJl IHVwZGF0ZWQ/Cj4gSXQgbG9va3MgcXVpdGUgb2RkIHRvIGNhbGwgdGhlIGZ1bmN0aW9uICJjb21w bGV0ZSBuZXh0IGJ1ZmZlciIgYnV0IHdpdGgKPiBhIGJyaWVmIHNheWluZyAiY29tcGxldGUgdGhl IGN1cnJlbnQgYnVmZmVyIi4KPiAKPiBUZWNobmljYWxseSBpdCdzIHN0aWxsIGNvcnJlY3QsIGJ1 dCBpdCdzIG1vcmUgbGlrZQo+ICJDb21wbGV0ZSB0aGUgY3VycmVudCBidWZmZXIgYW5kIHJldHVy biB0aGUgbmV4dCBidWZmZXIiCj4gb3Igc3VjaC4KCkdvb2QgcG9pbnQuIEknbGwgdXBkYXRlIHRo ZSBicmllZiB0byB0aGF0LgoKPiA+ICAgKiBAdmlkZW86IHRoZSB2aWRlbyBub2RlCj4gPiAgICoK PiA+ICAgKiBUaGlzIGZ1bmN0aW9uIGNvbXBsZXRlcyB0aGUgY3VycmVudCBidWZmZXIgYnkgZmls bGluZyBpdHMgc2VxdWVuY2UgbnVtYmVyLAo+IAo+IElzIHRoaXMgc3RpbGwgYWNjdXJhdGUgZW5v dWdoIHRvIGtlZXAgdGhlIHRleHQgYXMgaXMgPwoKSXQncyBzdGlsbCB0cnVlLCBpc24ndCBpdCA/ Cgo+ID4gQEAgLTMxMCwxMyArMzI0LDExIEBAIHN0YXRpYyBpbnQgdnNwMV92aWRlb19waXBlbGlu ZV9zZXR1cF9wYXJ0aXRpb25zKHN0cnVjdCB2c3AxX3BpcGVsaW5lICpwaXBlKQo+ID4gICAqIFJl dHVybiB0aGUgbmV4dCBxdWV1ZWQgYnVmZmVyIG9yIE5VTEwgaWYgdGhlIHF1ZXVlIGlzIGVtcHR5 Lgo+ID4gICAqLwo+ID4gIHN0YXRpYyBzdHJ1Y3QgdnNwMV92YjJfYnVmZmVyICoKPiA+IC12c3Ax X3ZpZGVvX2NvbXBsZXRlX2J1ZmZlcihzdHJ1Y3QgdnNwMV92aWRlbyAqdmlkZW8pCj4gPiArdnNw MV92aWRlb19jb21wbGV0ZV9uZXh0X2J1ZmZlcihzdHJ1Y3QgdnNwMV92aWRlbyAqdmlkZW8pCj4g PiAgewo+ID4gLQlzdHJ1Y3QgdnNwMV9waXBlbGluZSAqcGlwZSA9IHZpZGVvLT5yd3BmLT5lbnRp dHkucGlwZTsKPiA+IC0Jc3RydWN0IHZzcDFfdmIyX2J1ZmZlciAqbmV4dCA9IE5VTEw7Cj4gPiAr CXN0cnVjdCB2c3AxX3ZiMl9idWZmZXIgKm5leHQ7Cj4gPiAgCXN0cnVjdCB2c3AxX3ZiMl9idWZm ZXIgKmRvbmU7Cj4gPiAgCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4gPiAtCXVuc2lnbmVkIGludCBp Owo+ID4gIAo+ID4gIAlzcGluX2xvY2tfaXJxc2F2ZSgmdmlkZW8tPmlycWxvY2ssIGZsYWdzKTsK PiA+ICAKPiA+IEBAIC0zMjcsMjEgKzMzOSwxNCBAQCB2c3AxX3ZpZGVvX2NvbXBsZXRlX2J1ZmZl cihzdHJ1Y3QgdnNwMV92aWRlbyAqdmlkZW8pCj4gPiAgCj4gPiAgCWRvbmUgPSBsaXN0X2ZpcnN0 X2VudHJ5KCZ2aWRlby0+aXJxcXVldWUsCj4gPiAgCQkJCXN0cnVjdCB2c3AxX3ZiMl9idWZmZXIs IHF1ZXVlKTsKPiA+IC0KPiA+ICAJbGlzdF9kZWwoJmRvbmUtPnF1ZXVlKTsKPiA+ICAKPiA+IC0J aWYgKCFsaXN0X2VtcHR5KCZ2aWRlby0+aXJxcXVldWUpKQo+ID4gLQkJbmV4dCA9IGxpc3RfZmly c3RfZW50cnkoJnZpZGVvLT5pcnFxdWV1ZSwKPiA+ICsJbmV4dCA9IGxpc3RfZmlyc3RfZW50cnlf b3JfbnVsbCgmdmlkZW8tPmlycXF1ZXVlLAo+IAo+IFRoYXQncyBhIG5pY2Ugd2F5IHRvIHNhdmUg YSBsaW5lLgo+IAo+ID4gIAkJCQkJc3RydWN0IHZzcDFfdmIyX2J1ZmZlciwgcXVldWUpOwo+ID4g IAo+ID4gIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZ2aWRlby0+aXJxbG9jaywgZmxhZ3MpOwo+ ID4gIAo+ID4gLQlkb25lLT5idWYuc2VxdWVuY2UgPSBwaXBlLT5zZXF1ZW5jZTsKPiA+IC0JZG9u ZS0+YnVmLnZiMl9idWYudGltZXN0YW1wID0ga3RpbWVfZ2V0X25zKCk7Cj4gPiAtCWZvciAoaSA9 IDA7IGkgPCBkb25lLT5idWYudmIyX2J1Zi5udW1fcGxhbmVzOyArK2kpCj4gPiAtCQl2YjJfc2V0 X3BsYW5lX3BheWxvYWQoJmRvbmUtPmJ1Zi52YjJfYnVmLCBpLAo+ID4gLQkJCQkgICAgICB2YjJf cGxhbmVfc2l6ZSgmZG9uZS0+YnVmLnZiMl9idWYsIGkpKTsKPiA+IC0JdmIyX2J1ZmZlcl9kb25l KCZkb25lLT5idWYudmIyX2J1ZiwgVkIyX0JVRl9TVEFURV9ET05FKTsKPiA+ICsJdnNwMV92aWRl b19jb21wbGV0ZV9idWZmZXIodmlkZW8sIGRvbmUpOwo+ID4gIAo+ID4gIAlyZXR1cm4gbmV4dDsK PiA+ICB9Cj4gPiBAQCAtMzUyLDcgKzM1Nyw3IEBAIHN0YXRpYyB2b2lkIHZzcDFfdmlkZW9fZnJh bWVfZW5kKHN0cnVjdCB2c3AxX3BpcGVsaW5lICpwaXBlLAo+ID4gIAlzdHJ1Y3QgdnNwMV92aWRl byAqdmlkZW8gPSByd3BmLT52aWRlbzsKPiA+ICAJc3RydWN0IHZzcDFfdmIyX2J1ZmZlciAqYnVm Owo+ID4gIAo+ID4gLQlidWYgPSB2c3AxX3ZpZGVvX2NvbXBsZXRlX2J1ZmZlcih2aWRlbyk7Cj4g PiArCWJ1ZiA9IHZzcDFfdmlkZW9fY29tcGxldGVfbmV4dF9idWZmZXIodmlkZW8pOwo+ID4gIAlp ZiAoYnVmID09IE5VTEwpCj4gPiAgCQlyZXR1cm47Cj4gPiAgCgotLSAKUmVnYXJkcywKCkxhdXJl bnQgUGluY2hhcnQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs