From mboxrd@z Thu Jan 1 00:00:00 1970 From: "james qian wang (Arm Technology China)" Subject: Re: [PATCH] drm: Fix writeback_job leak when state is check only or check failed Date: Fri, 22 Feb 2019 07:39:55 +0000 Message-ID: <20190222073948.GA4855@james-ThinkStation-P300> References: <20190221111304.846-1-james.qian.wang@arm.com> <0d1a7597-2c08-0fce-035e-bf8764ff88d8@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140047.outbound.protection.outlook.com [40.107.14.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id C0EC4892A5 for ; Fri, 22 Feb 2019 07:39:58 +0000 (UTC) In-Reply-To: <0d1a7597-2c08-0fce-035e-bf8764ff88d8@linux.intel.com> Content-Language: en-US Content-ID: <9847587C1A60854A9A49CD173BD4D06C@eurprd08.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: "airlied@linux.ie" , "Jonathan Chai (Arm Technology China)" , Liviu Dudau , "dri-devel@lists.freedesktop.org" , "Julien Yin (Arm Technology China)" , "maxime.ripard@bootlin.com" , nd , "sean@poorly.run" List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBGZWIgMjEsIDIwMTkgYXQgMDI6NTY6NTZQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gSGV5Cj4gCj4gT3AgMjEtMDItMjAxOSBvbSAxMjoxNCBzY2hyZWVmIGphbWVz IHFpYW4gd2FuZyAoQXJtIFRlY2hub2xvZ3kgQ2hpbmEpOgo+ID4gVGhlIHdyaXRlYmFjayBqb2Ig d2lsbCBub3QgYmUgYWRkZWQgdG8gd3JpdGViYWNrIHF1ZXVlIGlmIHRoZSBzdGF0ZSBpcwo+ID4g Y2hlY2sgb25seSBvciBjaGVjayBmYWlsZWQsIHRvIGF2b2lkIGxlYWssIG5lZWQgdG8gY2xlYW51 cCB3cml0ZWJhY2sgam9iCj4gPiBpbiBjb25uZWN0b3JfZGVzdHJveV9zdGF0ZSBpZiB0aGUgam9i IGV4aXN0ZWQuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogSmFtZXMgUWlhbiBXYW5nIChBcm0gVGVj aG5vbG9neSBDaGluYSkgPGphbWVzLnFpYW4ud2FuZ0Bhcm0uY29tPgo+IAo+IElzIHdyaXRlYmFj a19qb2IgaW4gdGhlIGNvbm5fc3RhdGUgc2V0IHRvIG51bGwgc29tZXdoZXJlPyBJJ20gd29ycmll ZCB3ZSBtaWdodCBlbmQgdXAgZnJlZWluZyB3cml0ZWJhY2tfam9iIHR3aWNlIG9uIHN1Y2Nlc3Mu Cj4gCj4gfk1hYXJ0ZW4KClllcywgdGhlIHN0YXRlLT53cml0ZWJhY2tfam9iIG5lZWQgdG8gYmUg c2V0IHRvIG51bGwgb25jZSB0aGUgam9iIGhhcyBiZWVuCnF1ZXVlZC4KTWF5YmUgd2UgY2FuIHJl ZmluZSB0aGUgcXVldWVfam9iIGZ1bmN0aW9uIGFuZCBhZGQgdGhpcyBzZXQgTlVMTCBpbnRvCml0 LgoKdm9pZCBkcm1fd3JpdGViYWNrX3F1ZXVlX2pvYihzdHJ1Y3QgZHJtX3dyaXRlYmFja19jb25u ZWN0b3IgKndiX2Nvbm5lY3RvciwKCQkJICAgICBzdHJ1Y3QgZHJtX3dyaXRlYmFja19qb2IgKipu ZXdfam9iKQp7CiAgICAgICAgc3RydWN0IGRybV93cml0ZWJhY2tfam9iICpqb2IgPSAqbmV3X2pv YjsKCXVuc2lnbmVkIGxvbmcgZmxhZ3M7CgogICAgICAgICpuZXdfam9iID0gTlVMTDsKCglzcGlu X2xvY2tfaXJxc2F2ZSgmd2JfY29ubmVjdG9yLT5qb2JfbG9jaywgZmxhZ3MpOwoJbGlzdF9hZGRf dGFpbCgmam9iLT5saXN0X2VudHJ5LCAmd2JfY29ubmVjdG9yLT5qb2JfcXVldWUpOwoJc3Bpbl91 bmxvY2tfaXJxcmVzdG9yZSgmd2JfY29ubmVjdG9yLT5qb2JfbG9jaywgZmxhZ3MpOwp9CgpUaGFu a3MKSmFtZXMKCj4gCj4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfc3RhdGVfaGVscGVy LmMgfCAgNCArKysrCj4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV93cml0ZWJhY2suYyAgICAgICAg ICAgfCAyMSArKysrKysrKysrKysrKysrKystLS0KPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDIyIGlu c2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9kcm1fYXRvbWljX3N0YXRlX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9h dG9taWNfc3RhdGVfaGVscGVyLmMKPiA+IGluZGV4IDQ5ODUzODRlNTFmNi4uNmE4ZTQxNDIzM2Rl IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfc3RhdGVfaGVscGVy LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3N0YXRlX2hlbHBlci5jCj4g PiBAQCAtMjgsNiArMjgsNyBAQAo+ID4gICNpbmNsdWRlIDxkcm0vZHJtX2NydGMuaD4KPiA+ICAj aW5jbHVkZSA8ZHJtL2RybV9wbGFuZS5oPgo+ID4gICNpbmNsdWRlIDxkcm0vZHJtX2Nvbm5lY3Rv ci5oPgo+ID4gKyNpbmNsdWRlIDxkcm0vZHJtX3dyaXRlYmFjay5oPgo+ID4gICNpbmNsdWRlIDxk cm0vZHJtX2F0b21pYy5oPgo+ID4gICNpbmNsdWRlIDxkcm0vZHJtX2RldmljZS5oPgo+ID4gIAo+ ID4gQEAgLTQwNyw2ICs0MDgsOSBAQCBFWFBPUlRfU1lNQk9MKGRybV9hdG9taWNfaGVscGVyX2Nv bm5lY3Rvcl9kdXBsaWNhdGVfc3RhdGUpOwo+ID4gIHZvaWQKPiA+ICBfX2RybV9hdG9taWNfaGVs cGVyX2Nvbm5lY3Rvcl9kZXN0cm95X3N0YXRlKHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpz dGF0ZSkKPiA+ICB7Cj4gPiArCWlmIChzdGF0ZS0+d3JpdGViYWNrX2pvYikKPiA+ICsJCWRybV93 cml0ZWJhY2tfY2xlYW51cF9qb2Ioc3RhdGUtPndyaXRlYmFja19qb2IpOwo+ID4gKwo+ID4gIAlp ZiAoc3RhdGUtPmNydGMpCj4gPiAgCQlkcm1fY29ubmVjdG9yX3B1dChzdGF0ZS0+Y29ubmVjdG9y KTsKPiA+ICAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3dyaXRlYmFjay5j IGIvZHJpdmVycy9ncHUvZHJtL2RybV93cml0ZWJhY2suYwo+ID4gaW5kZXggYzIwZTZmZTAwY2Iz Li40ODYxMjExNTBlYWEgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3dyaXRl YmFjay5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3dyaXRlYmFjay5jCj4gPiBAQCAt MjY4LDYgKzI2OCwyMiBAQCB2b2lkIGRybV93cml0ZWJhY2tfcXVldWVfam9iKHN0cnVjdCBkcm1f d3JpdGViYWNrX2Nvbm5lY3RvciAqd2JfY29ubmVjdG9yLAo+ID4gIH0KPiA+ICBFWFBPUlRfU1lN Qk9MKGRybV93cml0ZWJhY2tfcXVldWVfam9iKTsKPiA+ICAKPiA+ICsvKioKPiA+ICsgKiBkcm1f d3JpdGViYWNrX2NsZWFudXBfam9iIC0gY2xlYW51cCBhIHdyaXRlYmFjayBqb2IKPiA+ICsgKiBA am9iOiBUaGUgam9iIHRvIGNsZWFudXAKPiA+ICsgKi8KPiA+ICt2b2lkIGRybV93cml0ZWJhY2tf Y2xlYW51cF9qb2Ioc3RydWN0IGRybV93cml0ZWJhY2tfam9iICpqb2IpCj4gPiArewo+ID4gKwlp ZiAoam9iLT5mYikKPiA+ICsJCWRybV9mcmFtZWJ1ZmZlcl9wdXQoam9iLT5mYik7Cj4gPiArCj4g PiArCWlmIChqb2ItPm91dF9mZW5jZSkKPiA+ICsJCWRtYV9mZW5jZV9wdXQoam9iLT5vdXRfZmVu Y2UpOwo+ID4gKwo+ID4gKwlrZnJlZShqb2IpOwo+ID4gK30KPiA+ICtFWFBPUlRfU1lNQk9MKGRy bV93cml0ZWJhY2tfY2xlYW51cF9qb2IpOwo+ID4gKwo+ID4gIC8qCj4gPiAgICogQGNsZWFudXBf d29yazogZGVmZXJyZWQgY2xlYW51cCBvZiBhIHdyaXRlYmFjayBqb2IKPiA+ICAgKgo+ID4gQEAg LTI4MCwxMSArMjk2LDkgQEAgc3RhdGljIHZvaWQgY2xlYW51cF93b3JrKHN0cnVjdCB3b3JrX3N0 cnVjdCAqd29yaykKPiA+ICAJc3RydWN0IGRybV93cml0ZWJhY2tfam9iICpqb2IgPSBjb250YWlu ZXJfb2Yod29yaywKPiA+ICAJCQkJCQkgICAgIHN0cnVjdCBkcm1fd3JpdGViYWNrX2pvYiwKPiA+ ICAJCQkJCQkgICAgIGNsZWFudXBfd29yayk7Cj4gPiAtCWRybV9mcmFtZWJ1ZmZlcl9wdXQoam9i LT5mYik7Cj4gPiAtCWtmcmVlKGpvYik7Cj4gPiArCWRybV93cml0ZWJhY2tfY2xlYW51cF9qb2Io am9iKTsKPiA+ICB9Cj4gPiAgCj4gPiAtCj4gPiAgLyoqCj4gPiAgICogZHJtX3dyaXRlYmFja19z aWduYWxfY29tcGxldGlvbiAtIFNpZ25hbCB0aGUgY29tcGxldGlvbiBvZiBhIHdyaXRlYmFjayBq b2IKPiA+ICAgKiBAd2JfY29ubmVjdG9yOiBUaGUgd3JpdGViYWNrIGNvbm5lY3RvciB3aG9zZSBq b2IgaXMgY29tcGxldGUKPiA+IEBAIC0zMTksNiArMzMzLDcgQEAgZHJtX3dyaXRlYmFja19zaWdu YWxfY29tcGxldGlvbihzdHJ1Y3QgZHJtX3dyaXRlYmFja19jb25uZWN0b3IgKndiX2Nvbm5lY3Rv ciwKPiA+ICAJCQkJZG1hX2ZlbmNlX3NldF9lcnJvcihqb2ItPm91dF9mZW5jZSwgc3RhdHVzKTsK PiA+ICAJCQlkbWFfZmVuY2Vfc2lnbmFsKGpvYi0+b3V0X2ZlbmNlKTsKPiA+ICAJCQlkbWFfZmVu Y2VfcHV0KGpvYi0+b3V0X2ZlbmNlKTsKPiA+ICsJCQlqb2ItPm91dF9mZW5jZSA9IE5VTEw7Cj4g PiAgCQl9Cj4gPiAgCX0KPiA+ICAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmd2JfY29ubmVjdG9y LT5qb2JfbG9jaywgZmxhZ3MpOwo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWw=