From: Sam Ravnborg <sam@ravnborg.org>
To: Jerry Han <jerry.han.hq@gmail.com>
Cc: Jerry Han <hanxu5@huaqin.corp-partner.google.com>,
Jitao Shi <jitao.shi@mediatek.com>,
YH Lin <yueherngl@chromium.org>,
dri-devel@lists.freedesktop.org,
Nick Sanders <nsanders@google.com>,
Rock wang <rock_wang@himax.com.cn>
Subject: Re: [PATCH] [v2, 1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel
Date: Sun, 3 Mar 2019 20:57:15 +0100 [thread overview]
Message-ID: <20190303195715.GC13157@ravnborg.org> (raw)
In-Reply-To: <1551430248-9177-1-git-send-email-hanxu5@huaqin.corp-partner.google.com>
Hi Jerry.
Thanks for the nice patch.
On Fri, Mar 01, 2019 at 04:50:48PM +0800, Jerry Han wrote:
> Add dt-bingings for it.
>
> Signed-off-by: Jerry Han <hanxu5@huaqin.corp-partner.google.com>
One general comment.
In the kernel (at least in drm sub-system) the changelog should be complete.
Do not expect the reader to read $subject and continue with the changelog.
It is better to repeat yourself a little.
And then please be a bit more verbose - so the cangelog capture what you are doing (and why).
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-03 19:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 8:50 [PATCH] [v2, 1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel Jerry Han
2019-03-03 19:57 ` Sam Ravnborg [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-01 10:29 Jerry Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190303195715.GC13157@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hanxu5@huaqin.corp-partner.google.com \
--cc=jerry.han.hq@gmail.com \
--cc=jitao.shi@mediatek.com \
--cc=nsanders@google.com \
--cc=rock_wang@himax.com.cn \
--cc=yueherngl@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox