From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Subject: [PATCH] drm/vmwgfx: Don't double-free the mode stored in par->set_mode Date: Mon, 4 Mar 2019 11:08:43 +0100 Message-ID: <20190304100843.844-1-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B7F1898E1 for ; Mon, 4 Mar 2019 10:09:18 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: thellstrom@vmware.com, linux-graphics-maintainer@vmware.com Cc: Thomas Zimmermann , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org V2hlbiBjYWxsaW5nIHZtd19mYl9zZXRfcGFyKCksIHRoZSBtb2RlIHN0b3JlZCBpbiBwYXItPnNl dF9tb2RlIGdldHMgZnJlZSdkCnR3aWNlLiBUaGUgZmlyc3QgZnJlZSBpcyBpbiB2bXdfZmJfa21z X2RldGFjaCgpLCB0aGUgc2Vjb25kIGlzIG5lYXIgdGhlCmVuZCBvZiB2bXdfZmJfc2V0X3Bhcigp IHVuZGVyIHRoZSBuYW1lIG9mICdvbGRfbW9kZScuIFRoZSBtb2RlLXNldHRpbmcgY29kZQpvbmx5 IHdvcmtzIGNvcnJlY3RseSBpZiB0aGUgbW9kZSBkb2Vzbid0IGFjdHVhbGx5IGNoYW5nZS4gUmVt b3ZpbmcgJ29sZF9tb2RlJwppbiBmYXZvciBvZiB1c2luZyBwYXItPnNldF9tb2RlIGRpcmVjdGx5 IGZpeGVzIHRoZSBwcm9ibGVtLgoKU2lnbmVkLW9mZi1ieTogVGhvbWFzIFppbW1lcm1hbm4gPHR6 aW1tZXJtYW5uQHN1c2UuZGU+Ci0tLQogZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfZmIu YyB8IDEyICsrKy0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgOSBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9m Yi5jIGIvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfZmIuYwppbmRleCBiOTEzYTU2ZjM0 MjYuLjJhOTExMjUxNWY0NiAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdn ZnhfZmIuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9mYi5jCkBAIC01NjQs MTEgKzU2NCw5IEBAIHN0YXRpYyBpbnQgdm13X2ZiX3NldF9wYXIoc3RydWN0IGZiX2luZm8gKmlu Zm8pCiAJCTAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsCiAJCURSTV9NT0RFX0ZMQUdf TkhTWU5DIHwgRFJNX01PREVfRkxBR19QVlNZTkMpCiAJfTsKLQlzdHJ1Y3QgZHJtX2Rpc3BsYXlf bW9kZSAqb2xkX21vZGU7CiAJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGU7CiAJaW50IHJl dDsKIAotCW9sZF9tb2RlID0gcGFyLT5zZXRfbW9kZTsKIAltb2RlID0gZHJtX21vZGVfZHVwbGlj YXRlKHZtd19wcml2LT5kZXYsICZuZXdfbW9kZSk7CiAJaWYgKCFtb2RlKSB7CiAJCURSTV9FUlJP UigiQ291bGQgbm90IGNyZWF0ZSBuZXcgZmIgbW9kZS5cbiIpOwpAQCAtNTc5LDExICs1NzcsNyBA QCBzdGF0aWMgaW50IHZtd19mYl9zZXRfcGFyKHN0cnVjdCBmYl9pbmZvICppbmZvKQogCW1vZGUt PnZkaXNwbGF5ID0gdmFyLT55cmVzOwogCXZtd19ndWVzc19tb2RlX3RpbWluZyhtb2RlKTsKIAot CWlmIChvbGRfbW9kZSAmJiBkcm1fbW9kZV9lcXVhbChvbGRfbW9kZSwgbW9kZSkpIHsKLQkJZHJt X21vZGVfZGVzdHJveSh2bXdfcHJpdi0+ZGV2LCBtb2RlKTsKLQkJbW9kZSA9IG9sZF9tb2RlOwot CQlvbGRfbW9kZSA9IE5VTEw7Ci0JfSBlbHNlIGlmICghdm13X2ttc192YWxpZGF0ZV9tb2RlX3Zy YW0odm13X3ByaXYsCisJaWYgKCF2bXdfa21zX3ZhbGlkYXRlX21vZGVfdnJhbSh2bXdfcHJpdiwK IAkJCQkJbW9kZS0+aGRpc3BsYXkgKgogCQkJCQlESVZfUk9VTkRfVVAodmFyLT5iaXRzX3Blcl9w aXhlbCwgOCksCiAJCQkJCW1vZGUtPnZkaXNwbGF5KSkgewpAQCAtNjIwLDggKzYxNCw4IEBAIHN0 YXRpYyBpbnQgdm13X2ZiX3NldF9wYXIoc3RydWN0IGZiX2luZm8gKmluZm8pCiAJc2NoZWR1bGVf ZGVsYXllZF93b3JrKCZwYXItPmxvY2FsX3dvcmssIDApOwogCiBvdXRfdW5sb2NrOgotCWlmIChv bGRfbW9kZSkKLQkJZHJtX21vZGVfZGVzdHJveSh2bXdfcHJpdi0+ZGV2LCBvbGRfbW9kZSk7CisJ aWYgKHBhci0+c2V0X21vZGUpCisJCWRybV9tb2RlX2Rlc3Ryb3kodm13X3ByaXYtPmRldiwgcGFy LT5zZXRfbW9kZSk7CiAJcGFyLT5zZXRfbW9kZSA9IG1vZGU7CiAKIAltdXRleF91bmxvY2soJnBh ci0+Ym9fbXV0ZXgpOwotLSAKMi4yMC4xCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWw=