From: Sam Ravnborg <sam@ravnborg.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Turn bus flags macros into an enum
Date: Wed, 6 Mar 2019 07:00:02 +0100 [thread overview]
Message-ID: <20190306060002.GA24396@ravnborg.org> (raw)
In-Reply-To: <20190306023749.GA521@pendragon.ideasonboard.com>
Hi Laurent.
> > > + * @DRM_BUS_FLAG_DE_LOW: The Data Enable signal is active low
> > > + * @DRM_BUS_FLAG_DE_HIGH: The Data Enable signal is active high
> > > + * @DRM_BUS_FLAG_PIXDATA_POSEDGE: Legacy value, do not use
> > > + * @DRM_BUS_FLAG_PIXDATA_NEGEDGE: Legacy value, do not use
> >
> > Could you extend the comment to expalin what there replacements are?
> > Otherwise we leave it to someone with less understanding of the subject
> > to find out.
> > There are 30+ cases we need to fix and we better do it right.
>
> This patch will be merged as part of a series that replaces all the
> existing users of the legacy values. I'm leaving them here just in case
> another patch using them would be merged at the same time, and will then
> submit a patch to remove them.
>
> > It would also be nice to have the legacy values grouped so they are
> > easier to ignore.
>
> Can I keep this patch as-is given that I will remove the legacy values
> soon ?
Thats much better so we gid of some legacy.
With this you can add my:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-03-06 6:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 1:10 [PATCH] drm: Turn bus flags macros into an enum Laurent Pinchart
2019-01-12 12:11 ` Daniel Vetter
2019-01-12 12:41 ` Sam Ravnborg
2019-03-06 2:37 ` Laurent Pinchart
2019-03-06 6:00 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190306060002.GA24396@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox